From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 37A3E20945BAE for ; Mon, 25 Sep 2017 05:41:13 -0700 (PDT) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Sep 2017 05:44:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,436,1500966000"; d="scan'208";a="155660633" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga006.fm.intel.com with ESMTP; 25 Sep 2017 05:44:24 -0700 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 25 Sep 2017 05:44:24 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 25 Sep 2017 05:44:24 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by shsmsx102.ccr.corp.intel.com ([169.254.2.175]) with mapi id 14.03.0319.002; Mon, 25 Sep 2017 20:44:22 +0800 From: "Ni, Ruiyu" To: "Gao, Liming" , "edk2-devel@lists.01.org" Thread-Topic: [Patch 02/11] FatPkg: Update Ppi/Protocol usage in Fat INF to match source code logic Thread-Index: AQHTNe5eN85pHo5540mjFP6vTDSoi6LFi/vw Date: Mon, 25 Sep 2017 12:44:22 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5BA68B41@SHSMSX103.ccr.corp.intel.com> References: <1506337584-9588-1-git-send-email-liming.gao@intel.com> <1506337584-9588-3-git-send-email-liming.gao@intel.com> In-Reply-To: <1506337584-9588-3-git-send-email-liming.gao@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch 02/11] FatPkg: Update Ppi/Protocol usage in Fat INF to match source code logic X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Sep 2017 12:41:14 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Liming, There is no keyword such as "SOMETIMES_TO_START"? The DiskIo2 is indeed a TO_START protocol, but optional. -----Original Message----- From: Gao, Liming=20 Sent: Monday, September 25, 2017 7:06 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu Subject: [Patch 02/11] FatPkg: Update Ppi/Protocol usage in Fat INF to matc= h source code logic Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Ruiyu Ni --- FatPkg/EnhancedFatDxe/Fat.inf | 2 +- FatPkg/FatPei/FatPei.inf | 10 +++++++--- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/FatPkg/EnhancedFatDxe/Fat.inf b/FatPkg/EnhancedFatDxe/Fat.inf = index e7044cd..686b371 100644 --- a/FatPkg/EnhancedFatDxe/Fat.inf +++ b/FatPkg/EnhancedFatDxe/Fat.inf @@ -81,7 +81,7 @@ =20 [Protocols] gEfiDiskIoProtocolGuid ## TO_START - gEfiDiskIo2ProtocolGuid ## TO_START + gEfiDiskIo2ProtocolGuid ## SOMETIMES_CONSUMES gEfiBlockIoProtocolGuid ## TO_START gEfiSimpleFileSystemProtocolGuid ## BY_START gEfiUnicodeCollationProtocolGuid ## TO_START diff --git a/FatPkg/FatPei/FatPei.inf b/FatPkg/FatPei/FatPei.inf index 273f= 72d..c963429 100644 --- a/FatPkg/FatPei/FatPei.inf +++ b/FatPkg/FatPei/FatPei.inf @@ -61,9 +61,13 @@ =20 =20 [Ppis] - gEfiPeiVirtualBlockIoPpiGuid ## SOMETIMES_CONSUMES PPI_= NOTIFY - gEfiPeiVirtualBlockIo2PpiGuid ## SOMETIMES_CONSUMES PPI_= NOTIFY - gEfiPeiDeviceRecoveryModulePpiGuid ## SOMETIMES_PRODUCES + ## NOTIFY + ## SOMETIMES_CONSUMES + gEfiPeiVirtualBlockIoPpiGuid + ## NOTIFY + ## SOMETIMES_CONSUMES + gEfiPeiVirtualBlockIo2PpiGuid + gEfiPeiDeviceRecoveryModulePpiGuid ## PRODUCES =20 =20 [FeaturePcd] -- 2.8.0.windows.1