From: "Ni, Ruiyu" <ruiyu.ni@intel.com>
To: "Bi, Dandan" <dandan.bi@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Carsey, Jaben" <jaben.carsey@intel.com>
Subject: Re: [patch] ShellPkg/Dh: Refine variable naming style
Date: Thu, 28 Sep 2017 05:56:30 +0000 [thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5BA6E707@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1506566725-444288-1-git-send-email-dandan.bi@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
Thanks/Ray
> -----Original Message-----
> From: Bi, Dandan
> Sent: Thursday, September 28, 2017 10:45 AM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; Carsey, Jaben <jaben.carsey@intel.com>
> Subject: [patch] ShellPkg/Dh: Refine variable naming style
>
> Avoid using only lower-case characters for variable name.
>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
> ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c
> b/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c
> index 7d06163..a7bd251 100644
> --- a/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c
> +++ b/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c
> @@ -284,11 +284,11 @@ GetProtocolInfoString(
> EFI_STATUS Status;
> CHAR16 *RetVal;
> UINTN Size;
> CHAR16 *Temp;
> CHAR16 GuidStr[40];
> - VOID *instance;
> + VOID *Instance;
> CHAR16 InstanceStr[17];
>
> ProtocolGuidArray = NULL;
> RetVal = NULL;
> Size = 0;
> @@ -314,14 +314,14 @@ GetProtocolInfoString(
> FreePool(Temp);
> }
> StrnCatGrow(&RetVal, &Size, L"%N", 0);
>
> if(Verbose) {
> - Status = gBS->HandleProtocol (TheHandle,
> ProtocolGuidArray[ProtocolIndex], &instance);
> + Status = gBS->HandleProtocol (TheHandle,
> ProtocolGuidArray[ProtocolIndex], &Instance);
> if (!EFI_ERROR (Status)) {
> StrnCatGrow (&RetVal, &Size, L"(%H", 0);
> - UnicodeSPrint (InstanceStr, sizeof (InstanceStr), L"%x", instance);
> + UnicodeSPrint (InstanceStr, sizeof (InstanceStr), L"%x", Instance);
> StrnCatGrow (&RetVal, &Size, InstanceStr, 0);
> StrnCatGrow (&RetVal, &Size, L"%N)", 0);
> }
> }
>
> --
> 1.9.5.msysgit.1
next prev parent reply other threads:[~2017-09-28 5:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-28 2:45 [patch] ShellPkg/Dh: Refine variable naming style Dandan Bi
2017-09-28 5:56 ` Ni, Ruiyu [this message]
2017-09-28 13:41 ` Carsey, Jaben
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=734D49CCEBEEF84792F5B80ED585239D5BA6E707@SHSMSX103.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox