From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.65; helo=mga03.intel.com; envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9F4AB21EC8D09 for ; Wed, 27 Sep 2017 22:53:20 -0700 (PDT) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Sep 2017 22:56:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,448,1500966000"; d="scan'208";a="154251828" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga005.jf.intel.com with ESMTP; 27 Sep 2017 22:56:34 -0700 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 27 Sep 2017 22:56:34 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 27 Sep 2017 22:56:33 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.159]) with mapi id 14.03.0319.002; Thu, 28 Sep 2017 13:56:31 +0800 From: "Ni, Ruiyu" To: "Bi, Dandan" , "edk2-devel@lists.01.org" CC: "Carsey, Jaben" Thread-Topic: [patch] ShellPkg/Dh: Refine variable naming style Thread-Index: AQHTOAPhQ21COVFHKUaII0rhjARna6LJzL+g Date: Thu, 28 Sep 2017 05:56:30 +0000 Deferred-Delivery: Thu, 28 Sep 2017 05:56:00 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5BA6E707@SHSMSX103.ccr.corp.intel.com> References: <1506566725-444288-1-git-send-email-dandan.bi@intel.com> In-Reply-To: <1506566725-444288-1-git-send-email-dandan.bi@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [patch] ShellPkg/Dh: Refine variable naming style X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Sep 2017 05:53:20 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ruiyu Ni Thanks/Ray > -----Original Message----- > From: Bi, Dandan > Sent: Thursday, September 28, 2017 10:45 AM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Carsey, Jaben > Subject: [patch] ShellPkg/Dh: Refine variable naming style >=20 > Avoid using only lower-case characters for variable name. >=20 > Cc: Ruiyu Ni > Cc: Jaben Carsey > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Dandan Bi > --- > ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c > b/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c > index 7d06163..a7bd251 100644 > --- a/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c > +++ b/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c > @@ -284,11 +284,11 @@ GetProtocolInfoString( > EFI_STATUS Status; > CHAR16 *RetVal; > UINTN Size; > CHAR16 *Temp; > CHAR16 GuidStr[40]; > - VOID *instance; > + VOID *Instance; > CHAR16 InstanceStr[17]; >=20 > ProtocolGuidArray =3D NULL; > RetVal =3D NULL; > Size =3D 0; > @@ -314,14 +314,14 @@ GetProtocolInfoString( > FreePool(Temp); > } > StrnCatGrow(&RetVal, &Size, L"%N", 0); >=20 > if(Verbose) { > - Status =3D gBS->HandleProtocol (TheHandle, > ProtocolGuidArray[ProtocolIndex], &instance); > + Status =3D gBS->HandleProtocol (TheHandle, > ProtocolGuidArray[ProtocolIndex], &Instance); > if (!EFI_ERROR (Status)) { > StrnCatGrow (&RetVal, &Size, L"(%H", 0); > - UnicodeSPrint (InstanceStr, sizeof (InstanceStr), L"%x", insta= nce); > + UnicodeSPrint (InstanceStr, sizeof (InstanceStr), L"%x", Insta= nce); > StrnCatGrow (&RetVal, &Size, InstanceStr, 0); > StrnCatGrow (&RetVal, &Size, L"%N)", 0); > } > } >=20 > -- > 1.9.5.msysgit.1