From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.100; helo=mga07.intel.com; envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D102C21D046B3 for ; Thu, 28 Sep 2017 17:23:27 -0700 (PDT) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP; 28 Sep 2017 17:26:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,451,1500966000"; d="scan'208";a="1176856348" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga001.jf.intel.com with ESMTP; 28 Sep 2017 17:26:42 -0700 Received: from fmsmsx125.amr.corp.intel.com (10.18.125.40) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 28 Sep 2017 17:26:41 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX125.amr.corp.intel.com (10.18.125.40) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 28 Sep 2017 17:26:41 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.159]) with mapi id 14.03.0319.002; Fri, 29 Sep 2017 08:26:38 +0800 From: "Ni, Ruiyu" To: "Carsey, Jaben" , "edk2-devel@lists.01.org" Thread-Topic: [PATCH 1/2] ShellPkg/dh: Correct typo in help Thread-Index: AQHTOIfNU//kPSXYD0yoq6bjD6P5gqLLAfHg Date: Fri, 29 Sep 2017 00:26:37 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5BA6F465@SHSMSX103.ccr.corp.intel.com> References: <20170928172123.152656-1-ruiyu.ni@intel.com> <20170928172123.152656-2-ruiyu.ni@intel.com> In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 1/2] ShellPkg/dh: Correct typo in help X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Sep 2017 00:23:28 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Yes I think so. Thanks/Ray > -----Original Message----- > From: Carsey, Jaben > Sent: Friday, September 29, 2017 2:30 AM > To: Ni, Ruiyu ; edk2-devel@lists.01.org > Subject: RE: [PATCH 1/2] ShellPkg/dh: Correct typo in help >=20 > Ray, >=20 > This text is taken directly from the shell spec. Do we need to fix that = also? >=20 > > -----Original Message----- > > From: Ni, Ruiyu > > Sent: Thursday, September 28, 2017 10:21 AM > > To: edk2-devel@lists.01.org > > Cc: Carsey, Jaben > > Subject: [PATCH 1/2] ShellPkg/dh: Correct typo in help > > Importance: High > > > > Help message of "dh" gives an example to display all handles with > > "Image" protocol but actually "LoadedImage" protocol should be used. > > > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Ruiyu Ni > > Cc: Jaben Carsey > > --- > > .../UefiShellDriver1CommandsLib/UefiShellDriver1CommandsLib.uni = | 4 > > ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git > > a/ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1Command > > sLib.uni > > b/ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1Comman > > dsLib.uni > > index e4bff68838..3804fa7d28 100644 > > --- > > a/ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1Command > > sLib.uni > > +++ > > b/ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1Comman > > dsLib.uni > > @@ -401,9 +401,9 @@ > > " * To display all handles with 'diskio' protocol:\r\n" > > " Shell> dh -p diskio\r\n" > > " \r\n" > > -" * To display all handles with 'Image' protocol and break when the > > screen is\r\n" > > +" * To display all handles with 'LoadedImage' protocol and break > > +when the > > screen is\r\n" > > " full:\r\n" > > -" Shell> dh -p Image -b\r\n" > > +" Shell> dh -p LoadedImage -b\r\n" > > ".SH RETURNVALUES\r\n" > > " \r\n" > > "RETURN VALUES:\r\n" > > -- > > 2.12.2.windows.2