Re: [Patch 1/4] MdePkg: Disable VS warning 4701 & 4703 for VS2017

["Ni, Ruiyu" <ruiyu.ni@intel.com>]

Liming,
How many build failures are there if 4701 and 4703 are enabled for VS2017?
I am asking this because we sometimes met VS2008 build failures due to 4701 and 4703 are enabled for VS2008.
But the two warnings are disabled for VS2013 and later.
Can we have a consistent policy for the two warnings? Just disabling them for all VS versions is also OK I think.

Thanks/Ray

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Liming Gao
> Sent: Wednesday, October 18, 2017 6:49 PM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [Patch 1/4] MdePkg: Disable VS warning 4701 & 4703 for
> VS2017
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> ---
>  MdePkg/Include/Ia32/ProcessorBind.h | 4 ++--
> MdePkg/Include/X64/ProcessorBind.h  | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/MdePkg/Include/Ia32/ProcessorBind.h
> b/MdePkg/Include/Ia32/ProcessorBind.h
> index 8ba2348..aeecf3f 100644
> --- a/MdePkg/Include/Ia32/ProcessorBind.h
> +++ b/MdePkg/Include/Ia32/ProcessorBind.h
> @@ -1,7 +1,7 @@
>  /** @file
>    Processor or Compiler specific defines and types for IA-32 architecture.
> 
> -Copyright (c) 2006 - 2015, Intel Corporation. All rights reserved.<BR>
> +Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.<BR>
>  This program and the accompanying materials are licensed and made
> available under  the terms and conditions of the BSD License that
> accompanies this distribution.
>  The full text of the license may be found at @@ -93,7 +93,7 @@ WITHOUT
> WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR
> IMPLIED.
>  //
>  #pragma warning ( disable : 4206 )
> 
> -#if _MSC_VER == 1800 || _MSC_VER == 1900
> +#if _MSC_VER == 1800 || _MSC_VER == 1900 || _MSC_VER >= 1910
> 
>  //
>  // Disable these warnings for VS2013.
> diff --git a/MdePkg/Include/X64/ProcessorBind.h
> b/MdePkg/Include/X64/ProcessorBind.h
> index 72cc851..e637d86 100644
> --- a/MdePkg/Include/X64/ProcessorBind.h
> +++ b/MdePkg/Include/X64/ProcessorBind.h
> @@ -1,7 +1,7 @@
>  /** @file
>    Processor or Compiler specific defines and types x64 (Intel 64, AMD64).
> 
> -  Copyright (c) 2006 - 2015, Intel Corporation. All rights reserved.<BR>
> +  Copyright (c) 2006 - 2017, Intel Corporation. All rights
> + reserved.<BR>
>    This program and the accompanying materials
>    are licensed and made available under the terms and conditions of the BSD
> License
>    which accompanies this distribution.  The full text of the license may be
> found at
> @@ -107,7 +107,7 @@
>  //
>  #pragma warning ( disable : 4206 )
> 
> -#if _MSC_VER == 1800 || _MSC_VER == 1900
> +#if _MSC_VER == 1800 || _MSC_VER == 1900 || _MSC_VER >= 1910
> 
>  //
>  // Disable these warnings for VS2013.
> --
> 2.8.0.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel