From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id EA8B221E781E8 for ; Wed, 18 Oct 2017 19:22:49 -0700 (PDT) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Oct 2017 19:26:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,399,1503385200"; d="scan'208";a="1207427364" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga001.fm.intel.com with ESMTP; 18 Oct 2017 19:26:26 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 18 Oct 2017 19:26:24 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.152]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.93]) with mapi id 14.03.0319.002; Thu, 19 Oct 2017 10:26:13 +0800 From: "Ni, Ruiyu" To: "Gao, Liming" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [Patch 1/4] MdePkg: Disable VS warning 4701 & 4703 for VS2017 Thread-Index: AQHTSADUZpTnkaepMU68cE7/kZ5bXaLqclZQ Date: Thu, 19 Oct 2017 02:26:13 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5BA9DBC7@SHSMSX104.ccr.corp.intel.com> References: <1508323735-14344-1-git-send-email-liming.gao@intel.com> <1508323735-14344-2-git-send-email-liming.gao@intel.com> In-Reply-To: <1508323735-14344-2-git-send-email-liming.gao@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch 1/4] MdePkg: Disable VS warning 4701 & 4703 for VS2017 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Oct 2017 02:22:50 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Liming, How many build failures are there if 4701 and 4703 are enabled for VS2017? I am asking this because we sometimes met VS2008 build failures due to 4701= and 4703 are enabled for VS2008. But the two warnings are disabled for VS2013 and later. Can we have a consistent policy for the two warnings? Just disabling them f= or all VS versions is also OK I think. Thanks/Ray > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Liming Gao > Sent: Wednesday, October 18, 2017 6:49 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [Patch 1/4] MdePkg: Disable VS warning 4701 & 4703 for > VS2017 >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Liming Gao > --- > MdePkg/Include/Ia32/ProcessorBind.h | 4 ++-- > MdePkg/Include/X64/ProcessorBind.h | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/MdePkg/Include/Ia32/ProcessorBind.h > b/MdePkg/Include/Ia32/ProcessorBind.h > index 8ba2348..aeecf3f 100644 > --- a/MdePkg/Include/Ia32/ProcessorBind.h > +++ b/MdePkg/Include/Ia32/ProcessorBind.h > @@ -1,7 +1,7 @@ > /** @file > Processor or Compiler specific defines and types for IA-32 architectur= e. >=20 > -Copyright (c) 2006 - 2015, Intel Corporation. All rights reserved.
> +Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.
> This program and the accompanying materials are licensed and made > available under the terms and conditions of the BSD License that > accompanies this distribution. > The full text of the license may be found at @@ -93,7 +93,7 @@ WITHOUT > WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR > IMPLIED. > // > #pragma warning ( disable : 4206 ) >=20 > -#if _MSC_VER =3D=3D 1800 || _MSC_VER =3D=3D 1900 > +#if _MSC_VER =3D=3D 1800 || _MSC_VER =3D=3D 1900 || _MSC_VER >=3D 1910 >=20 > // > // Disable these warnings for VS2013. > diff --git a/MdePkg/Include/X64/ProcessorBind.h > b/MdePkg/Include/X64/ProcessorBind.h > index 72cc851..e637d86 100644 > --- a/MdePkg/Include/X64/ProcessorBind.h > +++ b/MdePkg/Include/X64/ProcessorBind.h > @@ -1,7 +1,7 @@ > /** @file > Processor or Compiler specific defines and types x64 (Intel 64, AMD64)= . >=20 > - Copyright (c) 2006 - 2015, Intel Corporation. All rights reserved.
> + Copyright (c) 2006 - 2017, Intel Corporation. All rights > + reserved.
> This program and the accompanying materials > are licensed and made available under the terms and conditions of the = BSD > License > which accompanies this distribution. The full text of the license may= be > found at > @@ -107,7 +107,7 @@ > // > #pragma warning ( disable : 4206 ) >=20 > -#if _MSC_VER =3D=3D 1800 || _MSC_VER =3D=3D 1900 > +#if _MSC_VER =3D=3D 1800 || _MSC_VER =3D=3D 1900 || _MSC_VER >=3D 1910 >=20 > // > // Disable these warnings for VS2013. > -- > 2.8.0.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel