public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ni, Ruiyu" <ruiyu.ni@intel.com>
To: Tim Lewis <tim.lewis@insyde.com>,
	"Jarlstrom, Laurie" <laurie.jarlstrom@intel.com>,
	"Carsey, Jaben" <jaben.carsey@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH] ShellPkg/UefiShellLib: Use a more bright blue/green color
Date: Thu, 19 Oct 2017 05:20:08 +0000	[thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5BA9E338@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <7236196A5DF6C040855A6D96F556A53FD3D290@msmail.insydesw.com.tw>

All,
Check the latest colors. The text should be easier to read.

Thanks/Ray

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Tim Lewis
> Sent: Tuesday, October 17, 2017 5:15 AM
> To: Jarlstrom, Laurie <laurie.jarlstrom@intel.com>; Carsey, Jaben
> <jaben.carsey@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>; edk2-
> devel@lists.01.org
> Subject: Re: [edk2] [PATCH] ShellPkg/UefiShellLib: Use a more bright
> blue/green color
> 
> And we always turn off the multiple colors. Tim
> 
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Jarlstrom, Laurie
> Sent: Monday, October 16, 2017 12:47 PM
> To: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>;
> edk2-devel@lists.01.org
> Subject: Re: [edk2] [PATCH] ShellPkg/UefiShellLib: Use a more bright
> blue/green color
> 
> The Idea of PCDs would be great.  I always change the UefiShellLib EFI_BLUE
> to EFI_CYAN to get a brighter blue.
> 
> thanks,
> Laurie
> 
> laurie.jarlstrom@intel.com
> 
> Intel SSG/STO/EBP
> (503) 712-9395
> 
> 
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Carsey, Jaben
> Sent: Monday, October 16, 2017 9:32 AM
> To: Ni, Ruiyu <ruiyu.ni@intel.com>; edk2-devel@lists.01.org
> Subject: Re: [edk2] [PATCH] ShellPkg/UefiShellLib: Use a more bright
> blue/green color
> 
> Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> 
> We could also use some PCDs if different people really want different colors
> in the future...
> 
> > -----Original Message-----
> > From: Ni, Ruiyu
> > Sent: Monday, October 16, 2017 12:31 AM
> > To: edk2-devel@lists.01.org
> > Cc: Carsey, Jaben <jaben.carsey@intel.com>
> > Subject: [PATCH] ShellPkg/UefiShellLib: Use a more bright blue/green
> > color
> > Importance: High
> >
> > Some developers/QAs complain the color of directory or executable
> > files is hard to see and suggest to use a more bright color.
> > I agree with this suggestion so make this patch.
> > The look and feel is much better now.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
> > Cc: Jaben Carsey <jaben.carsey@intel.com>
> > ---
> >  ShellPkg/Library/UefiShellLib/UefiShellLib.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/ShellPkg/Library/UefiShellLib/UefiShellLib.c
> > b/ShellPkg/Library/UefiShellLib/UefiShellLib.c
> > index 64565f81d8..25d3e33533 100644
> > --- a/ShellPkg/Library/UefiShellLib/UefiShellLib.c
> > +++ b/ShellPkg/Library/UefiShellLib/UefiShellLib.c
> > @@ -2849,10 +2849,10 @@ InternalShellPrintWorker(
> >              gST->ConOut->SetAttribute(gST->ConOut,
> > EFI_TEXT_ATTR(EFI_WHITE, ((OriginalAttribute&(BIT4|BIT5|BIT6))>>4)));
> >              break;
> >            case (L'B'):
> > -            gST->ConOut->SetAttribute(gST->ConOut,
> EFI_TEXT_ATTR(EFI_BLUE,
> > ((OriginalAttribute&(BIT4|BIT5|BIT6))>>4)));
> > +            gST->ConOut->SetAttribute(gST->ConOut,
> > EFI_TEXT_ATTR(EFI_LIGHTBLUE,
> ((OriginalAttribute&(BIT4|BIT5|BIT6))>>4)));
> >              break;
> >            case (L'V'):
> > -            gST->ConOut->SetAttribute(gST->ConOut,
> > EFI_TEXT_ATTR(EFI_GREEN, ((OriginalAttribute&(BIT4|BIT5|BIT6))>>4)));
> > +            gST->ConOut->SetAttribute(gST->ConOut,
> > EFI_TEXT_ATTR(EFI_LIGHTGREEN,
> > ((OriginalAttribute&(BIT4|BIT5|BIT6))>>4)));
> >              break;
> >            default:
> >              //
> > --
> > 2.12.2.windows.2
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel


      reply	other threads:[~2017-10-19  5:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-16  7:30 [PATCH] ShellPkg/UefiShellLib: Use a more bright blue/green color Ruiyu Ni
2017-10-16 16:32 ` Carsey, Jaben
2017-10-16 19:46   ` Jarlstrom, Laurie
2017-10-16 21:14     ` Tim Lewis
2017-10-19  5:20       ` Ni, Ruiyu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=734D49CCEBEEF84792F5B80ED585239D5BA9E338@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox