From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.24; helo=mga09.intel.com; envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6F73B21EA15BE for ; Wed, 18 Oct 2017 22:16:36 -0700 (PDT) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Oct 2017 22:20:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,400,1503385200"; d="scan'208";a="1207469450" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga001.fm.intel.com with ESMTP; 18 Oct 2017 22:20:13 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 18 Oct 2017 22:20:13 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.152]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.218]) with mapi id 14.03.0319.002; Thu, 19 Oct 2017 13:20:09 +0800 From: "Ni, Ruiyu" To: Tim Lewis , "Jarlstrom, Laurie" , "Carsey, Jaben" , "edk2-devel@lists.01.org" Thread-Topic: [PATCH] ShellPkg/UefiShellLib: Use a more bright blue/green color Thread-Index: AQHTRpxYVDdJPBTWC0e4OM7ig5dpFaLmW5iAgAAYs4CABDI0sA== Date: Thu, 19 Oct 2017 05:20:08 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5BA9E338@SHSMSX104.ccr.corp.intel.com> References: <20171016073048.236980-1-ruiyu.ni@intel.com> <10380531DF222B45964BE3E93EFE5F0488F7E837@fmsmsx104.amr.corp.intel.com> <7236196A5DF6C040855A6D96F556A53FD3D290@msmail.insydesw.com.tw> In-Reply-To: <7236196A5DF6C040855A6D96F556A53FD3D290@msmail.insydesw.com.tw> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] ShellPkg/UefiShellLib: Use a more bright blue/green color X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Oct 2017 05:16:36 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable All, Check the latest colors. The text should be easier to read. Thanks/Ray > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Tim Lewis > Sent: Tuesday, October 17, 2017 5:15 AM > To: Jarlstrom, Laurie ; Carsey, Jaben > ; Ni, Ruiyu ; edk2- > devel@lists.01.org > Subject: Re: [edk2] [PATCH] ShellPkg/UefiShellLib: Use a more bright > blue/green color >=20 > And we always turn off the multiple colors. Tim >=20 > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Jarlstrom, Laurie > Sent: Monday, October 16, 2017 12:47 PM > To: Carsey, Jaben ; Ni, Ruiyu ; > edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH] ShellPkg/UefiShellLib: Use a more bright > blue/green color >=20 > The Idea of PCDs would be great. I always change the UefiShellLib EFI_BL= UE > to EFI_CYAN to get a brighter blue. >=20 > thanks, > Laurie >=20 > laurie.jarlstrom@intel.com >=20 > Intel SSG/STO/EBP > (503) 712-9395 >=20 >=20 > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Carsey, Jaben > Sent: Monday, October 16, 2017 9:32 AM > To: Ni, Ruiyu ; edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH] ShellPkg/UefiShellLib: Use a more bright > blue/green color >=20 > Reviewed-by: Jaben Carsey >=20 > We could also use some PCDs if different people really want different col= ors > in the future... >=20 > > -----Original Message----- > > From: Ni, Ruiyu > > Sent: Monday, October 16, 2017 12:31 AM > > To: edk2-devel@lists.01.org > > Cc: Carsey, Jaben > > Subject: [PATCH] ShellPkg/UefiShellLib: Use a more bright blue/green > > color > > Importance: High > > > > Some developers/QAs complain the color of directory or executable > > files is hard to see and suggest to use a more bright color. > > I agree with this suggestion so make this patch. > > The look and feel is much better now. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Ruiyu Ni > > Cc: Jaben Carsey > > --- > > ShellPkg/Library/UefiShellLib/UefiShellLib.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/ShellPkg/Library/UefiShellLib/UefiShellLib.c > > b/ShellPkg/Library/UefiShellLib/UefiShellLib.c > > index 64565f81d8..25d3e33533 100644 > > --- a/ShellPkg/Library/UefiShellLib/UefiShellLib.c > > +++ b/ShellPkg/Library/UefiShellLib/UefiShellLib.c > > @@ -2849,10 +2849,10 @@ InternalShellPrintWorker( > > gST->ConOut->SetAttribute(gST->ConOut, > > EFI_TEXT_ATTR(EFI_WHITE, ((OriginalAttribute&(BIT4|BIT5|BIT6))>>4))); > > break; > > case (L'B'): > > - gST->ConOut->SetAttribute(gST->ConOut, > EFI_TEXT_ATTR(EFI_BLUE, > > ((OriginalAttribute&(BIT4|BIT5|BIT6))>>4))); > > + gST->ConOut->SetAttribute(gST->ConOut, > > EFI_TEXT_ATTR(EFI_LIGHTBLUE, > ((OriginalAttribute&(BIT4|BIT5|BIT6))>>4))); > > break; > > case (L'V'): > > - gST->ConOut->SetAttribute(gST->ConOut, > > EFI_TEXT_ATTR(EFI_GREEN, ((OriginalAttribute&(BIT4|BIT5|BIT6))>>4))); > > + gST->ConOut->SetAttribute(gST->ConOut, > > EFI_TEXT_ATTR(EFI_LIGHTGREEN, > > ((OriginalAttribute&(BIT4|BIT5|BIT6))>>4))); > > break; > > default: > > // > > -- > > 2.12.2.windows.2 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel