* [PATCH] ShellPkg/UefiShellLib: Use a more bright blue/green color @ 2017-10-16 7:30 Ruiyu Ni 2017-10-16 16:32 ` Carsey, Jaben 0 siblings, 1 reply; 5+ messages in thread From: Ruiyu Ni @ 2017-10-16 7:30 UTC (permalink / raw) To: edk2-devel; +Cc: Jaben Carsey Some developers/QAs complain the color of directory or executable files is hard to see and suggest to use a more bright color. I agree with this suggestion so make this patch. The look and feel is much better now. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com> Cc: Jaben Carsey <jaben.carsey@intel.com> --- ShellPkg/Library/UefiShellLib/UefiShellLib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ShellPkg/Library/UefiShellLib/UefiShellLib.c b/ShellPkg/Library/UefiShellLib/UefiShellLib.c index 64565f81d8..25d3e33533 100644 --- a/ShellPkg/Library/UefiShellLib/UefiShellLib.c +++ b/ShellPkg/Library/UefiShellLib/UefiShellLib.c @@ -2849,10 +2849,10 @@ InternalShellPrintWorker( gST->ConOut->SetAttribute(gST->ConOut, EFI_TEXT_ATTR(EFI_WHITE, ((OriginalAttribute&(BIT4|BIT5|BIT6))>>4))); break; case (L'B'): - gST->ConOut->SetAttribute(gST->ConOut, EFI_TEXT_ATTR(EFI_BLUE, ((OriginalAttribute&(BIT4|BIT5|BIT6))>>4))); + gST->ConOut->SetAttribute(gST->ConOut, EFI_TEXT_ATTR(EFI_LIGHTBLUE, ((OriginalAttribute&(BIT4|BIT5|BIT6))>>4))); break; case (L'V'): - gST->ConOut->SetAttribute(gST->ConOut, EFI_TEXT_ATTR(EFI_GREEN, ((OriginalAttribute&(BIT4|BIT5|BIT6))>>4))); + gST->ConOut->SetAttribute(gST->ConOut, EFI_TEXT_ATTR(EFI_LIGHTGREEN, ((OriginalAttribute&(BIT4|BIT5|BIT6))>>4))); break; default: // -- 2.12.2.windows.2 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ShellPkg/UefiShellLib: Use a more bright blue/green color 2017-10-16 7:30 [PATCH] ShellPkg/UefiShellLib: Use a more bright blue/green color Ruiyu Ni @ 2017-10-16 16:32 ` Carsey, Jaben 2017-10-16 19:46 ` Jarlstrom, Laurie 0 siblings, 1 reply; 5+ messages in thread From: Carsey, Jaben @ 2017-10-16 16:32 UTC (permalink / raw) To: Ni, Ruiyu, edk2-devel@lists.01.org Reviewed-by: Jaben Carsey <jaben.carsey@intel.com> We could also use some PCDs if different people really want different colors in the future... > -----Original Message----- > From: Ni, Ruiyu > Sent: Monday, October 16, 2017 12:31 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.carsey@intel.com> > Subject: [PATCH] ShellPkg/UefiShellLib: Use a more bright blue/green color > Importance: High > > Some developers/QAs complain the color of directory or executable > files is hard to see and suggest to use a more bright color. > I agree with this suggestion so make this patch. > The look and feel is much better now. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com> > Cc: Jaben Carsey <jaben.carsey@intel.com> > --- > ShellPkg/Library/UefiShellLib/UefiShellLib.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/ShellPkg/Library/UefiShellLib/UefiShellLib.c > b/ShellPkg/Library/UefiShellLib/UefiShellLib.c > index 64565f81d8..25d3e33533 100644 > --- a/ShellPkg/Library/UefiShellLib/UefiShellLib.c > +++ b/ShellPkg/Library/UefiShellLib/UefiShellLib.c > @@ -2849,10 +2849,10 @@ InternalShellPrintWorker( > gST->ConOut->SetAttribute(gST->ConOut, > EFI_TEXT_ATTR(EFI_WHITE, ((OriginalAttribute&(BIT4|BIT5|BIT6))>>4))); > break; > case (L'B'): > - gST->ConOut->SetAttribute(gST->ConOut, EFI_TEXT_ATTR(EFI_BLUE, > ((OriginalAttribute&(BIT4|BIT5|BIT6))>>4))); > + gST->ConOut->SetAttribute(gST->ConOut, > EFI_TEXT_ATTR(EFI_LIGHTBLUE, ((OriginalAttribute&(BIT4|BIT5|BIT6))>>4))); > break; > case (L'V'): > - gST->ConOut->SetAttribute(gST->ConOut, > EFI_TEXT_ATTR(EFI_GREEN, ((OriginalAttribute&(BIT4|BIT5|BIT6))>>4))); > + gST->ConOut->SetAttribute(gST->ConOut, > EFI_TEXT_ATTR(EFI_LIGHTGREEN, > ((OriginalAttribute&(BIT4|BIT5|BIT6))>>4))); > break; > default: > // > -- > 2.12.2.windows.2 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ShellPkg/UefiShellLib: Use a more bright blue/green color 2017-10-16 16:32 ` Carsey, Jaben @ 2017-10-16 19:46 ` Jarlstrom, Laurie 2017-10-16 21:14 ` Tim Lewis 0 siblings, 1 reply; 5+ messages in thread From: Jarlstrom, Laurie @ 2017-10-16 19:46 UTC (permalink / raw) To: Carsey, Jaben, Ni, Ruiyu, edk2-devel@lists.01.org The Idea of PCDs would be great. I always change the UefiShellLib EFI_BLUE to EFI_CYAN to get a brighter blue. thanks, Laurie laurie.jarlstrom@intel.com Intel SSG/STO/EBP (503) 712-9395 -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Carsey, Jaben Sent: Monday, October 16, 2017 9:32 AM To: Ni, Ruiyu <ruiyu.ni@intel.com>; edk2-devel@lists.01.org Subject: Re: [edk2] [PATCH] ShellPkg/UefiShellLib: Use a more bright blue/green color Reviewed-by: Jaben Carsey <jaben.carsey@intel.com> We could also use some PCDs if different people really want different colors in the future... > -----Original Message----- > From: Ni, Ruiyu > Sent: Monday, October 16, 2017 12:31 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.carsey@intel.com> > Subject: [PATCH] ShellPkg/UefiShellLib: Use a more bright blue/green > color > Importance: High > > Some developers/QAs complain the color of directory or executable > files is hard to see and suggest to use a more bright color. > I agree with this suggestion so make this patch. > The look and feel is much better now. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com> > Cc: Jaben Carsey <jaben.carsey@intel.com> > --- > ShellPkg/Library/UefiShellLib/UefiShellLib.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/ShellPkg/Library/UefiShellLib/UefiShellLib.c > b/ShellPkg/Library/UefiShellLib/UefiShellLib.c > index 64565f81d8..25d3e33533 100644 > --- a/ShellPkg/Library/UefiShellLib/UefiShellLib.c > +++ b/ShellPkg/Library/UefiShellLib/UefiShellLib.c > @@ -2849,10 +2849,10 @@ InternalShellPrintWorker( > gST->ConOut->SetAttribute(gST->ConOut, > EFI_TEXT_ATTR(EFI_WHITE, ((OriginalAttribute&(BIT4|BIT5|BIT6))>>4))); > break; > case (L'B'): > - gST->ConOut->SetAttribute(gST->ConOut, EFI_TEXT_ATTR(EFI_BLUE, > ((OriginalAttribute&(BIT4|BIT5|BIT6))>>4))); > + gST->ConOut->SetAttribute(gST->ConOut, > EFI_TEXT_ATTR(EFI_LIGHTBLUE, ((OriginalAttribute&(BIT4|BIT5|BIT6))>>4))); > break; > case (L'V'): > - gST->ConOut->SetAttribute(gST->ConOut, > EFI_TEXT_ATTR(EFI_GREEN, ((OriginalAttribute&(BIT4|BIT5|BIT6))>>4))); > + gST->ConOut->SetAttribute(gST->ConOut, > EFI_TEXT_ATTR(EFI_LIGHTGREEN, > ((OriginalAttribute&(BIT4|BIT5|BIT6))>>4))); > break; > default: > // > -- > 2.12.2.windows.2 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ShellPkg/UefiShellLib: Use a more bright blue/green color 2017-10-16 19:46 ` Jarlstrom, Laurie @ 2017-10-16 21:14 ` Tim Lewis 2017-10-19 5:20 ` Ni, Ruiyu 0 siblings, 1 reply; 5+ messages in thread From: Tim Lewis @ 2017-10-16 21:14 UTC (permalink / raw) To: Jarlstrom, Laurie, Carsey, Jaben, Ni, Ruiyu, edk2-devel@lists.01.org And we always turn off the multiple colors. Tim -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Jarlstrom, Laurie Sent: Monday, October 16, 2017 12:47 PM To: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>; edk2-devel@lists.01.org Subject: Re: [edk2] [PATCH] ShellPkg/UefiShellLib: Use a more bright blue/green color The Idea of PCDs would be great. I always change the UefiShellLib EFI_BLUE to EFI_CYAN to get a brighter blue. thanks, Laurie laurie.jarlstrom@intel.com Intel SSG/STO/EBP (503) 712-9395 -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Carsey, Jaben Sent: Monday, October 16, 2017 9:32 AM To: Ni, Ruiyu <ruiyu.ni@intel.com>; edk2-devel@lists.01.org Subject: Re: [edk2] [PATCH] ShellPkg/UefiShellLib: Use a more bright blue/green color Reviewed-by: Jaben Carsey <jaben.carsey@intel.com> We could also use some PCDs if different people really want different colors in the future... > -----Original Message----- > From: Ni, Ruiyu > Sent: Monday, October 16, 2017 12:31 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.carsey@intel.com> > Subject: [PATCH] ShellPkg/UefiShellLib: Use a more bright blue/green > color > Importance: High > > Some developers/QAs complain the color of directory or executable > files is hard to see and suggest to use a more bright color. > I agree with this suggestion so make this patch. > The look and feel is much better now. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com> > Cc: Jaben Carsey <jaben.carsey@intel.com> > --- > ShellPkg/Library/UefiShellLib/UefiShellLib.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/ShellPkg/Library/UefiShellLib/UefiShellLib.c > b/ShellPkg/Library/UefiShellLib/UefiShellLib.c > index 64565f81d8..25d3e33533 100644 > --- a/ShellPkg/Library/UefiShellLib/UefiShellLib.c > +++ b/ShellPkg/Library/UefiShellLib/UefiShellLib.c > @@ -2849,10 +2849,10 @@ InternalShellPrintWorker( > gST->ConOut->SetAttribute(gST->ConOut, > EFI_TEXT_ATTR(EFI_WHITE, ((OriginalAttribute&(BIT4|BIT5|BIT6))>>4))); > break; > case (L'B'): > - gST->ConOut->SetAttribute(gST->ConOut, EFI_TEXT_ATTR(EFI_BLUE, > ((OriginalAttribute&(BIT4|BIT5|BIT6))>>4))); > + gST->ConOut->SetAttribute(gST->ConOut, > EFI_TEXT_ATTR(EFI_LIGHTBLUE, ((OriginalAttribute&(BIT4|BIT5|BIT6))>>4))); > break; > case (L'V'): > - gST->ConOut->SetAttribute(gST->ConOut, > EFI_TEXT_ATTR(EFI_GREEN, ((OriginalAttribute&(BIT4|BIT5|BIT6))>>4))); > + gST->ConOut->SetAttribute(gST->ConOut, > EFI_TEXT_ATTR(EFI_LIGHTGREEN, > ((OriginalAttribute&(BIT4|BIT5|BIT6))>>4))); > break; > default: > // > -- > 2.12.2.windows.2 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ShellPkg/UefiShellLib: Use a more bright blue/green color 2017-10-16 21:14 ` Tim Lewis @ 2017-10-19 5:20 ` Ni, Ruiyu 0 siblings, 0 replies; 5+ messages in thread From: Ni, Ruiyu @ 2017-10-19 5:20 UTC (permalink / raw) To: Tim Lewis, Jarlstrom, Laurie, Carsey, Jaben, edk2-devel@lists.01.org All, Check the latest colors. The text should be easier to read. Thanks/Ray > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Tim Lewis > Sent: Tuesday, October 17, 2017 5:15 AM > To: Jarlstrom, Laurie <laurie.jarlstrom@intel.com>; Carsey, Jaben > <jaben.carsey@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>; edk2- > devel@lists.01.org > Subject: Re: [edk2] [PATCH] ShellPkg/UefiShellLib: Use a more bright > blue/green color > > And we always turn off the multiple colors. Tim > > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Jarlstrom, Laurie > Sent: Monday, October 16, 2017 12:47 PM > To: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>; > edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH] ShellPkg/UefiShellLib: Use a more bright > blue/green color > > The Idea of PCDs would be great. I always change the UefiShellLib EFI_BLUE > to EFI_CYAN to get a brighter blue. > > thanks, > Laurie > > laurie.jarlstrom@intel.com > > Intel SSG/STO/EBP > (503) 712-9395 > > > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Carsey, Jaben > Sent: Monday, October 16, 2017 9:32 AM > To: Ni, Ruiyu <ruiyu.ni@intel.com>; edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH] ShellPkg/UefiShellLib: Use a more bright > blue/green color > > Reviewed-by: Jaben Carsey <jaben.carsey@intel.com> > > We could also use some PCDs if different people really want different colors > in the future... > > > -----Original Message----- > > From: Ni, Ruiyu > > Sent: Monday, October 16, 2017 12:31 AM > > To: edk2-devel@lists.01.org > > Cc: Carsey, Jaben <jaben.carsey@intel.com> > > Subject: [PATCH] ShellPkg/UefiShellLib: Use a more bright blue/green > > color > > Importance: High > > > > Some developers/QAs complain the color of directory or executable > > files is hard to see and suggest to use a more bright color. > > I agree with this suggestion so make this patch. > > The look and feel is much better now. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com> > > Cc: Jaben Carsey <jaben.carsey@intel.com> > > --- > > ShellPkg/Library/UefiShellLib/UefiShellLib.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/ShellPkg/Library/UefiShellLib/UefiShellLib.c > > b/ShellPkg/Library/UefiShellLib/UefiShellLib.c > > index 64565f81d8..25d3e33533 100644 > > --- a/ShellPkg/Library/UefiShellLib/UefiShellLib.c > > +++ b/ShellPkg/Library/UefiShellLib/UefiShellLib.c > > @@ -2849,10 +2849,10 @@ InternalShellPrintWorker( > > gST->ConOut->SetAttribute(gST->ConOut, > > EFI_TEXT_ATTR(EFI_WHITE, ((OriginalAttribute&(BIT4|BIT5|BIT6))>>4))); > > break; > > case (L'B'): > > - gST->ConOut->SetAttribute(gST->ConOut, > EFI_TEXT_ATTR(EFI_BLUE, > > ((OriginalAttribute&(BIT4|BIT5|BIT6))>>4))); > > + gST->ConOut->SetAttribute(gST->ConOut, > > EFI_TEXT_ATTR(EFI_LIGHTBLUE, > ((OriginalAttribute&(BIT4|BIT5|BIT6))>>4))); > > break; > > case (L'V'): > > - gST->ConOut->SetAttribute(gST->ConOut, > > EFI_TEXT_ATTR(EFI_GREEN, ((OriginalAttribute&(BIT4|BIT5|BIT6))>>4))); > > + gST->ConOut->SetAttribute(gST->ConOut, > > EFI_TEXT_ATTR(EFI_LIGHTGREEN, > > ((OriginalAttribute&(BIT4|BIT5|BIT6))>>4))); > > break; > > default: > > // > > -- > > 2.12.2.windows.2 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-10-19 5:16 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-10-16 7:30 [PATCH] ShellPkg/UefiShellLib: Use a more bright blue/green color Ruiyu Ni 2017-10-16 16:32 ` Carsey, Jaben 2017-10-16 19:46 ` Jarlstrom, Laurie 2017-10-16 21:14 ` Tim Lewis 2017-10-19 5:20 ` Ni, Ruiyu
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox