From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.65; helo=mga03.intel.com; envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E037920355214 for ; Tue, 7 Nov 2017 23:45:20 -0800 (PST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Nov 2017 23:49:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,363,1505804400"; d="scan'208";a="147315489" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga004.jf.intel.com with ESMTP; 07 Nov 2017 23:49:20 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 7 Nov 2017 23:48:18 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.152]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.213]) with mapi id 14.03.0319.002; Wed, 8 Nov 2017 15:47:21 +0800 From: "Ni, Ruiyu" To: "Kinney, Michael D" , "edk2-devel@lists.01.org" CC: "Dong, Eric" , "Zeng, Star" Thread-Topic: [edk2] [Patch] MdeModulePkg/TerminalDxe: Fix PCANSI mapping for TRIANGLE and ARROW Thread-Index: AQHTWEliL0ceE4JK0kmcFXT2YWqL9KMKGmIw Date: Wed, 8 Nov 2017 07:47:19 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5BAB6C7F@SHSMSX104.ccr.corp.intel.com> References: <20171108042341.16684-1-michael.d.kinney@intel.com> In-Reply-To: <20171108042341.16684-1-michael.d.kinney@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] MdeModulePkg/TerminalDxe: Fix PCANSI mapping for TRIANGLE and ARROW X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Nov 2017 07:45:21 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Mike, I am a bit confused about mapping 0x18 to upper arrow. I remembered that in old days, pressing ALT+18 in DOS window can generate u= pper arrow. Thanks/Ray > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Michael D Kinney > Sent: Wednesday, November 8, 2017 12:24 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric ; Zeng, Star > Subject: [edk2] [Patch] MdeModulePkg/TerminalDxe: Fix PCANSI mapping > for TRIANGLE and ARROW >=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D761 >=20 > When a TerminalType is set to PCANSI, characters in the range 0x00 to 0x1= F > are control characters. The mapping table for PCANSI maps TRIANGLE glyph= s, > ARROW_UP glyph, and ARROW_DOWN glyph into this control character > range and that causes no characters to be displayed by PCANSI compatible > terminal emulators. >=20 > The mappings are updated so these glyphs are mapped to ANSI characters in > the range 0x20 to 0x7E. >=20 > GEOMETRICSHAPE_UP_TRIANGLE '^' > GEOMETRICSHAPE_RIGHT_TRIANGLE '>' > GEOMETRICSHAPE_DOWN_TRIANGLE 'v' > GEOMETRICSHAPE_LEFT_TRIANGLE '<' > ARROW_UP '^' > ARROW_DOWN 'v' >=20 > Cc: Star Zeng > Cc: Eric Dong > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Michael D Kinney > --- > .../Universal/Console/TerminalDxe/TerminalConOut.c | 18 +++++++++---= - > ----- > 1 file changed, 9 insertions(+), 9 deletions(-) >=20 > diff --git > a/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConOut.c > b/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConOut.c > index e677a76e6b..5a8343162f 100644 > --- a/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConOut.c > +++ b/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConOut.c > @@ -66,15 +66,15 @@ UNICODE_TO_CHAR UnicodeToPcAnsiOrAscii[] =3D { > { BLOCKELEMENT_FULL_BLOCK, 0xdb, L'*' }, > { BLOCKELEMENT_LIGHT_SHADE, 0xb0, L'+' }, >=20 > - { GEOMETRICSHAPE_UP_TRIANGLE, 0x1e, L'^' }, > - { GEOMETRICSHAPE_RIGHT_TRIANGLE, 0x10, L'>' }, > - { GEOMETRICSHAPE_DOWN_TRIANGLE, 0x1f, L'v' }, > - { GEOMETRICSHAPE_LEFT_TRIANGLE, 0x11, L'<' }, > - > - { ARROW_LEFT, 0x3c, L'<' }, > - { ARROW_UP, 0x18, L'^' }, > - { ARROW_RIGHT, 0x3e, L'>' }, > - { ARROW_DOWN, 0x19, L'v' }, > + { GEOMETRICSHAPE_UP_TRIANGLE, '^', L'^' }, > + { GEOMETRICSHAPE_RIGHT_TRIANGLE, '>', L'>' }, > + { GEOMETRICSHAPE_DOWN_TRIANGLE, 'v', L'v' }, > + { GEOMETRICSHAPE_LEFT_TRIANGLE, '<', L'<' }, > + > + { ARROW_LEFT, '<', L'<' }, > + { ARROW_UP, '^', L'^' }, > + { ARROW_RIGHT, '>', L'>' }, > + { ARROW_DOWN, 'v', L'v' }, >=20 > { 0x0000, 0x00, L'\0' } > }; > -- > 2.14.2.windows.3 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel