From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.120; helo=mga04.intel.com; envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 55EDC21B00DC6 for ; Wed, 8 Nov 2017 18:54:36 -0800 (PST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Nov 2017 18:58:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,367,1505804400"; d="scan'208";a="147731198" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga004.jf.intel.com with ESMTP; 08 Nov 2017 18:58:36 -0800 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 8 Nov 2017 18:58:35 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 8 Nov 2017 18:58:35 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.152]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.218]) with mapi id 14.03.0319.002; Thu, 9 Nov 2017 10:58:33 +0800 From: "Ni, Ruiyu" To: "Kinney, Michael D" , "edk2-devel@lists.01.org" CC: "Dong, Eric" , "Zeng, Star" Thread-Topic: [edk2] [Patch] MdeModulePkg/TerminalDxe: Fix PCANSI mapping for TRIANGLE and ARROW Thread-Index: AQHTWEliL0ceE4JK0kmcFXT2YWqL9KMKGmIwgAAMXYCAATVtcA== Date: Thu, 9 Nov 2017 02:58:33 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5BAB7B24@SHSMSX104.ccr.corp.intel.com> References: <20171108042341.16684-1-michael.d.kinney@intel.com> <734D49CCEBEEF84792F5B80ED585239D5BAB6C7F@SHSMSX104.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] MdeModulePkg/TerminalDxe: Fix PCANSI mapping for TRIANGLE and ARROW X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Nov 2017 02:54:36 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks for the explanation. Reviewed-by: Ruiyu Ni Thanks/Ray > -----Original Message----- > From: Kinney, Michael D > Sent: Thursday, November 9, 2017 12:29 AM > To: Ni, Ruiyu ; edk2-devel@lists.01.org; Kinney, Mich= ael > D > Cc: Dong, Eric ; Zeng, Star > Subject: RE: [edk2] [Patch] MdeModulePkg/TerminalDxe: Fix PCANSI > mapping for TRIANGLE and ARROW >=20 > When DOS uses CodePage 437, 18 is an up arrow glyph. >=20 > A PC ANSI terminal interprets 18 as a control character. >=20 > Mike >=20 > > -----Original Message----- > > From: Ni, Ruiyu > > Sent: Tuesday, November 7, 2017 11:47 PM > > To: Kinney, Michael D ; > > edk2-devel@lists.01.org > > Cc: Dong, Eric ; Zeng, Star > > Subject: RE: [edk2] [Patch] MdeModulePkg/TerminalDxe: > > Fix PCANSI mapping for TRIANGLE and ARROW > > > > Mike, > > I am a bit confused about mapping 0x18 to upper arrow. > > I remembered that in old days, pressing ALT+18 in DOS window can > > generate upper arrow. > > > > Thanks/Ray > > > > > -----Original Message----- > > > From: edk2-devel [mailto:edk2-devel- > > bounces@lists.01.org] On Behalf Of > > > Michael D Kinney > > > Sent: Wednesday, November 8, 2017 12:24 PM > > > To: edk2-devel@lists.01.org > > > Cc: Dong, Eric ; Zeng, Star > > > > > Subject: [edk2] [Patch] MdeModulePkg/TerminalDxe: Fix > > PCANSI mapping > > > for TRIANGLE and ARROW > > > > > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D761 > > > > > > When a TerminalType is set to PCANSI, characters in > > the range 0x00 to 0x1F > > > are control characters. The mapping table for PCANSI > > maps TRIANGLE glyphs, > > > ARROW_UP glyph, and ARROW_DOWN glyph into this > > control character > > > range and that causes no characters to be displayed > > by PCANSI compatible > > > terminal emulators. > > > > > > The mappings are updated so these glyphs are mapped > > to ANSI characters in > > > the range 0x20 to 0x7E. > > > > > > GEOMETRICSHAPE_UP_TRIANGLE '^' > > > GEOMETRICSHAPE_RIGHT_TRIANGLE '>' > > > GEOMETRICSHAPE_DOWN_TRIANGLE 'v' > > > GEOMETRICSHAPE_LEFT_TRIANGLE '<' > > > ARROW_UP '^' > > > ARROW_DOWN 'v' > > > > > > Cc: Star Zeng > > > Cc: Eric Dong > > > Contributed-under: TianoCore Contribution Agreement > > 1.1 > > > Signed-off-by: Michael D Kinney > > > > > --- > > > .../Universal/Console/TerminalDxe/TerminalConOut.c > > | 18 +++++++++---- > > > ----- > > > 1 file changed, 9 insertions(+), 9 deletions(-) > > > > > > diff --git > > > > > a/MdeModulePkg/Universal/Console/TerminalDxe/TerminalCo > > nOut.c > > > > > b/MdeModulePkg/Universal/Console/TerminalDxe/TerminalCo > > nOut.c > > > index e677a76e6b..5a8343162f 100644 > > > --- > > a/MdeModulePkg/Universal/Console/TerminalDxe/TerminalCo > > nOut.c > > > +++ > > b/MdeModulePkg/Universal/Console/TerminalDxe/TerminalCo > > nOut.c > > > @@ -66,15 +66,15 @@ UNICODE_TO_CHAR > > UnicodeToPcAnsiOrAscii[] =3D { > > > { BLOCKELEMENT_FULL_BLOCK, 0xdb, L'*' > > }, > > > { BLOCKELEMENT_LIGHT_SHADE, 0xb0, L'+' > > }, > > > > > > - { GEOMETRICSHAPE_UP_TRIANGLE, 0x1e, L'^' > > }, > > > - { GEOMETRICSHAPE_RIGHT_TRIANGLE, 0x10, L'>' > > }, > > > - { GEOMETRICSHAPE_DOWN_TRIANGLE, 0x1f, L'v' > > }, > > > - { GEOMETRICSHAPE_LEFT_TRIANGLE, 0x11, L'<' > > }, > > > - > > > - { ARROW_LEFT, 0x3c, L'<' > > }, > > > - { ARROW_UP, 0x18, L'^' > > }, > > > - { ARROW_RIGHT, 0x3e, L'>' > > }, > > > - { ARROW_DOWN, 0x19, L'v' > > }, > > > + { GEOMETRICSHAPE_UP_TRIANGLE, '^', L'^' }, > > > + { GEOMETRICSHAPE_RIGHT_TRIANGLE, '>', L'>' }, > > > + { GEOMETRICSHAPE_DOWN_TRIANGLE, 'v', L'v' }, > > > + { GEOMETRICSHAPE_LEFT_TRIANGLE, '<', L'<' }, > > > + > > > + { ARROW_LEFT, '<', L'<' }, > > > + { ARROW_UP, '^', L'^' }, > > > + { ARROW_RIGHT, '>', L'>' }, > > > + { ARROW_DOWN, 'v', L'v' }, > > > > > > { 0x0000, 0x00, L'\0' > > } > > > }; > > > -- > > > 2.14.2.windows.3 > > > > > > _______________________________________________ > > > edk2-devel mailing list > > > edk2-devel@lists.01.org > > > https://lists.01.org/mailman/listinfo/edk2-devel