From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.31; helo=mga06.intel.com; envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E93642034A794 for ; Mon, 27 Nov 2017 23:35:46 -0800 (PST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Nov 2017 23:40:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,467,1505804400"; d="scan'208";a="6954306" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga004.fm.intel.com with ESMTP; 27 Nov 2017 23:40:08 -0800 Received: from fmsmsx126.amr.corp.intel.com (10.18.125.43) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 27 Nov 2017 23:40:08 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX126.amr.corp.intel.com (10.18.125.43) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 27 Nov 2017 23:40:08 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.152]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.93]) with mapi id 14.03.0319.002; Tue, 28 Nov 2017 15:40:06 +0800 From: "Ni, Ruiyu" To: Ard Biesheuvel CC: "Carsey, Jaben" , "Kinney, Michael D" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [PATCH v2 2/3] ShellPkg/tftp: Convert from NULL class library to Dynamic Command Thread-Index: AQHTZ0RgtVV6b3Mw90OgwAAJB+Du/KMo4h2AgACHdKA= Date: Tue, 28 Nov 2017 07:40:05 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5BAD41C1@SHSMSX104.ccr.corp.intel.com> References: <20171127055532.320556-1-ruiyu.ni@intel.com> <20171127055532.320556-3-ruiyu.ni@intel.com> In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v2 2/3] ShellPkg/tftp: Convert from NULL class library to Dynamic Command X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Nov 2017 07:35:47 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I just realized OVMF platform is referencing the INF. I will search in all edkII code. Thanks/Ray > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Ard Biesheuvel > Sent: Tuesday, November 28, 2017 3:35 PM > To: Ni, Ruiyu > Cc: Carsey, Jaben ; Kinney, Michael D > ; edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH v2 2/3] ShellPkg/tftp: Convert from NULL class > library to Dynamic Command >=20 > On 27 November 2017 at 05:55, Ruiyu Ni wrote: > > UEFI Shell spec defines Shell Dynamic Command protocol which is just > > for the purpose to extend internal command. > > So tftp command is changed from NULL class library to be a driver > > producing DynamicCommand protocol. > > > > The guideline is: > > 1. Only use NULL class library for Shell spec defined commands. > > 2. New commands can be provided as not only a standalone application > > but also a dynamic command. So it can be used either as an > > internal command, but also as a standalone application. > > > > TftpApp.inf is to provide a standalone application. > > TftpDynamicCommand.inf is to provide a standalone driver producing > > Dynamic Command protocol. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Ruiyu Ni > > Cc: Jaben Carsey > > Cc: Michael D Kinney > > --- > > .../TftpDynamicCommand}/Tftp.c | 92 +++++++++++--= -- > > .../TftpDynamicCommand/Tftp.h} | 40 +++++-- > > .../TftpDynamicCommand/Tftp.uni} | 0 > > .../DynamicCommand/TftpDynamicCommand/TftpApp.c | 54 > +++++++++ > > .../TftpDynamicCommand/TftpApp.inf} | 34 +++--- > > .../TftpDynamicCommand/TftpDynamicCommand.c | 131 > +++++++++++++++++++++ > > .../TftpDynamicCommand/TftpDynamicCommand.inf} | 39 +++--- > > .../UefiShellTftpCommandLib.c | 97 -------------= -- > > ShellPkg/ShellPkg.dsc | 11 +- > > 9 files changed, 325 insertions(+), 173 deletions(-) >=20 > Please make sure that you fix platforms that use .inf files when renaming > them. > The ArmVirtQemu build is currently broken due to this patch. > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel