Re: [PATCH v4 2/3] ArmVirtPkg: Fix build failure due to Tftp library removal

["Ni, Ruiyu" <ruiyu.ni@intel.com>]

Laszlo,
Thank you very much for that! I will try to become a talkaholic
when writing commit messages next time.


> -----Original Message-----
> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]
> Sent: Thursday, November 30, 2017 9:16 PM
> To: Laszlo Ersek <lersek@redhat.com>
> Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; edk2-devel@lists.01.org
> Subject: Re: [edk2] [PATCH v4 2/3] ArmVirtPkg: Fix build failure due to Tftp
> library removal
> 
> On 30 November 2017 at 12:22, Laszlo Ersek <lersek@redhat.com> wrote:
> > On 11/29/17 14:53, Laszlo Ersek wrote:
> >> Ray,
> >>
> >> On 11/29/17 11:14, Ruiyu Ni wrote:
> >>> The TFTP command was converted from a NULL class library instance to
> >>> a dynamic shell command in commit 0961002352e9.
> >>>
> >>> Contributed-under: TianoCore Contribution Agreement 1.1
> >>> Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
> >>> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> >>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> >>> Cc: Julien Grall <julien.grall@linaro.org>
> >>> ---
> >>>  ArmVirtPkg/ArmVirt.dsc.inc           | 11 +++++++----
> >>>  ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc |  3 ++-
> >>>  ArmVirtPkg/ArmVirtXen.fdf            |  3 ++-
> >>>  3 files changed, 11 insertions(+), 6 deletions(-)
> >>
> >> Can you please incorporate points (2) and (3) as well, from my v3 review?
> >>
> >>   https://lists.01.org/pipermail/edk2-devel/2017-November/018191.html
> >
> > I fixed up the commit message as described above.
> >
> > I also test-built the ArmVirtQemu, ArmVirtQemuKernel and ArmVirtXen
> > platforms, with the patch applied, for ARM and AARCH64.
> >
> > [lersek@redhat.com: extend commit message]
> > Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> > Build-tested-by: Laszlo Ersek <lersek@redhat.com>
> >
> > Commit 59fcf0706bf4.
> >
> 
> Thanks for taking care of this. The build had been broken long enough