From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 613E121A10986 for ; Sat, 2 Dec 2017 00:39:52 -0800 (PST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Dec 2017 00:44:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,348,1508828400"; d="scan'208";a="8667566" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga004.fm.intel.com with ESMTP; 02 Dec 2017 00:44:19 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sat, 2 Dec 2017 00:44:18 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.152]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.93]) with mapi id 14.03.0319.002; Sat, 2 Dec 2017 16:44:17 +0800 From: "Ni, Ruiyu" To: "Steele, Kelly" , "edk2-devel@lists.01.org" CC: "Kinney, Michael D" Thread-Topic: [PATCH 2/2] QuarkPlatformPkg: Use DpDynamicCommand to replace PerformancePkg/dp Thread-Index: AQHTashc7/qzD2QeJUmYSHxXSHX3BKMvvbBw Date: Sat, 2 Dec 2017 08:44:17 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5BADC5BC@SHSMSX104.ccr.corp.intel.com> References: <20171129081439.278964-1-ruiyu.ni@intel.com> <20171129081439.278964-3-ruiyu.ni@intel.com> In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjkzZDhmMzMtYzg4OS00MzczLWE5ZTQtNDRkZWZhYzk3NTdiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX1BVQkxJQyJ9XX1dfSwiU3ViamVjdExhYmVscyI6W10sIlRNQ1ZlcnNpb24iOiIxNy4yLjUuMTgiLCJUcnVzdGVkTGFiZWxIYXNoIjoiXC8xYUVtbTBjTDVCc1FKVTM1ZU5ValFtbm90aWtTWUlzZDMzZGFKYzRHN2MrSmYwaHo4b2NDbDFRQVNJZTdGTWQifQ== x-ctpclassification: CTP_PUBLIC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 2/2] QuarkPlatformPkg: Use DpDynamicCommand to replace PerformancePkg/dp X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Dec 2017 08:39:52 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Kelly, I pushed the commit, following your below recommendation. > -----Original Message----- > From: Steele, Kelly > Sent: Saturday, December 2, 2017 1:18 AM > To: Ni, Ruiyu ; edk2-devel@lists.01.org > Cc: Kinney, Michael D > Subject: RE: [PATCH 2/2] QuarkPlatformPkg: Use DpDynamicCommand to > replace PerformancePkg/dp >=20 > Reviewed-by: Steele, Kelly >=20 > My only comment is the fix in Quark.fdf, line #575: > # File System Modules > # > -!if $(PERFORMANCE_ENABLE) > -INF > MdeModulePkg/Universal/FvSimpleFileSystemDxe/FvSimpleFileSystemDxe.inf > -!else > +!if not $(PERFORMANCE_ENABLE) > INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf > INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf > INF FatPkg/EnhancedFatDxe/Fat.inf > !endif >=20 > I would suggest going with the following to keep with the style present i= n the > rest of the file: > # File System Modules > # > !if $(PERFORMANCE_ENABLE) > -INF > MdeModulePkg/Universal/FvSimpleFileSystemDxe/FvSimpleFileSystemDxe.inf > !else > INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf > INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf > INF FatPkg/EnhancedFatDxe/Fat.inf > !endif >=20 > Thanks, > Kelly >=20 > -----Original Message----- > From: Ni, Ruiyu > Sent: November 29, 2017 00:15 > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Steele, Kelly > > Subject: [PATCH 2/2] QuarkPlatformPkg: Use DpDynamicCommand to replace > PerformancePkg/dp >=20 > Remove FvSimpleFileSystemDxe from Quark.dsc/fdf because it's not needed b= y > using DpDynamicCommand driver. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ruiyu Ni > Cc: Michael D Kinney > Cc: Kelly Steele > --- > QuarkPlatformPkg/Quark.dsc | 15 +++++++-------- > QuarkPlatformPkg/Quark.fdf | 16 +++++++++------- > QuarkPlatformPkg/QuarkMin.dsc | 13 ++++++++----- > QuarkPlatformPkg/QuarkMin.fdf | 12 ++++++++---- > 4 files changed, 32 insertions(+), 24 deletions(-) >=20 > diff --git a/QuarkPlatformPkg/Quark.dsc b/QuarkPlatformPkg/Quark.dsc inde= x > 025653eee5..5624451e12 100644 > --- a/QuarkPlatformPkg/Quark.dsc > +++ b/QuarkPlatformPkg/Quark.dsc > @@ -163,6 +163,9 @@ [LibraryClasses] >=20 > PerformanceLib|MdePkg/Library/BasePerformanceLibNull/BasePerformanceLib > Null.inf > !endif >=20 > + ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf > + FileHandleLib|MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.inf > + > OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf > IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf > BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf > @@ -864,9 +867,6 @@ [Components.IA32] > MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf > MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf > FatPkg/EnhancedFatDxe/Fat.inf > -!if $(PERFORMANCE_ENABLE) > - MdeModulePkg/Universal/FvSimpleFileSystemDxe/FvSimpleFileSystemDxe.inf > -!endif >=20 > # > # Capsule update > @@ -887,10 +887,11 @@ [Components.IA32] > # Performance Application > # > !if $(PERFORMANCE_ENABLE) > - PerformancePkg/Dp_App/Dp.inf { > + ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.inf { > + > + gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE > > - ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf > - FileHandleLib|MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.i= nf > + > + > PerformanceLib|MdeModulePkg/Library/DxeSmmPerformanceLib/DxeSmmPerf > orm > + anceLib.inf > } > !endif >=20 > @@ -910,8 +911,6 @@ [Components.IA32] >=20 > NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1Comma= n > dsLib.inf >=20 > NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Co > mmandsLib.inf >=20 > HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingL= ib.i > nf > - ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf > - FileHandleLib|MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.i= nf > PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf >=20 > BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCo > mmandLib.inf >=20 > diff --git a/QuarkPlatformPkg/Quark.fdf b/QuarkPlatformPkg/Quark.fdf inde= x > 19533b2281..5abe3b6f31 100644 > --- a/QuarkPlatformPkg/Quark.fdf > +++ b/QuarkPlatformPkg/Quark.fdf > @@ -2,7 +2,7 @@ > # FDF file of Clanton Peak CRB platform with 32-bit DXE # # This packa= ge > provides QuarkNcSocId platform specific modules. > -# Copyright (c) 2013 - 2016 Intel Corporation. > +# Copyright (c) 2013 - 2017 Intel Corporation. > # > # This program and the accompanying materials # are licensed and made > available under the terms and conditions of the BSD License @@ -574,14 > +574,19 @@ [FV.FVMAIN] # # File System Modules # -!if > $(PERFORMANCE_ENABLE) -INF > MdeModulePkg/Universal/FvSimpleFileSystemDxe/FvSimpleFileSystemDxe.inf > -!else > +!if not $(PERFORMANCE_ENABLE) > INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf > INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf > INF FatPkg/EnhancedFatDxe/Fat.inf > !endif >=20 > +# > +# Performance Application > +# > +!if $(PERFORMANCE_ENABLE) > +INF > ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.inf > +!endif > + > # > # Trusted Platform Module > # > @@ -677,9 +682,6 @@ [FV.PAYLOAD] > # Shell and Applications > # > INF RuleOverride =3D TIANOCOMPRESSED ShellPkg/Application/Shell/Shell.i= nf > -!if $(PERFORMANCE_ENABLE) > -INF RuleOverride =3D TIANOCOMPRESSED PerformancePkg/Dp_App/Dp.inf - > !endif >=20 > !if $(CAPSULE_ENABLE) || $(RECOVERY_ENABLE) >=20 > diff --git a/QuarkPlatformPkg/QuarkMin.dsc b/QuarkPlatformPkg/QuarkMin.ds= c > index 084f2f4e8f..404f507966 100644 > --- a/QuarkPlatformPkg/QuarkMin.dsc > +++ b/QuarkPlatformPkg/QuarkMin.dsc > @@ -150,6 +150,10 @@ [LibraryClasses] > !else >=20 > PerformanceLib|MdePkg/Library/BasePerformanceLibNull/BasePerformanceLib > Null.inf > !endif > + > + ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf > + FileHandleLib|MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.inf > + > !if $(SECURE_BOOT_ENABLE) > BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf >=20 > PlatformSecureLib|QuarkPlatformPkg/Library/PlatformSecureLib/PlatformSecu= r > eLib.inf > @@ -614,10 +618,11 @@ [Components.IA32] > # Performance Application > # > !if $(PERFORMANCE_ENABLE) > - PerformancePkg/Dp_App/Dp.inf { > + ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.inf { > + > + gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE > > - ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf > - FileHandleLib|MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.i= nf > + > + > PerformanceLib|MdeModulePkg/Library/DxeSmmPerformanceLib/DxeSmmPerf > orm > + anceLib.inf > } > !endif >=20 > @@ -632,8 +637,6 @@ [Components.IA32] >=20 > NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1Comma= n > dsLib.inf >=20 > NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Co > mmandsLib.inf >=20 > HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingL= ib.i > nf > - ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf > - FileHandleLib|MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.i= nf > PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf >=20 > BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCo > mmandLib.inf >=20 > diff --git a/QuarkPlatformPkg/QuarkMin.fdf b/QuarkPlatformPkg/QuarkMin.fd= f > index ac751993d0..b793fbd9a3 100644 > --- a/QuarkPlatformPkg/QuarkMin.fdf > +++ b/QuarkPlatformPkg/QuarkMin.fdf > @@ -2,7 +2,7 @@ > # FDF file of Clanton Peak CRB platform with 32-bit DXE # # This packa= ge > provides QuarkNcSocId platform specific modules. > -# Copyright (c) 2013 - 2015 Intel Corporation. > +# Copyright (c) 2013 - 2017 Intel Corporation. > # > # This program and the accompanying materials # are licensed and made > available under the terms and conditions of the BSD License @@ -435,6 +43= 5,13 > @@ [FV.FVMAIN] # INF > MdeModulePkg/Universal/FvSimpleFileSystemDxe/FvSimpleFileSystemDxe.inf >=20 > +# > +# Performance Application > +# > +!if $(PERFORMANCE_ENABLE) > +INF > ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.inf > +!endif > + >=20 > ################################################################# > ############### > # > # FV Section > @@ -502,9 +509,6 @@ [FV.PAYLOAD] > # Shell and Applications > # > INF ShellPkg/Application/Shell/Shell.inf > -!if $(PERFORMANCE_ENABLE) > -INF PerformancePkg/Dp_App/Dp.inf > -!endif >=20 >=20 > ################################################################# > ############### > # > -- > 2.15.0.gvfs.1.preview.4