From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.100; helo=mga07.intel.com; envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B230021A10986 for ; Sat, 2 Dec 2017 01:04:30 -0800 (PST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Dec 2017 01:08:57 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,348,1508828400"; d="scan'208";a="155303046" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga004.jf.intel.com with ESMTP; 02 Dec 2017 01:08:57 -0800 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sat, 2 Dec 2017 01:08:57 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sat, 2 Dec 2017 01:08:56 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.152]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.93]) with mapi id 14.03.0319.002; Sat, 2 Dec 2017 17:08:54 +0800 From: "Ni, Ruiyu" To: "Carsey, Jaben" , "edk2-devel@lists.01.org" Thread-Topic: [PATCH] ShellPkg/ShellPkg.dec: Change comments for PcdShellLibAutoInitialize Thread-Index: AQHTasXiH/Ypo6JlrU2Sa8h0AamKoKMvxHzw Date: Sat, 2 Dec 2017 09:08:53 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5BADC65A@SHSMSX104.ccr.corp.intel.com> References: <20171129082205.269556-1-ruiyu.ni@intel.com> In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNmYwY2E2ZWItOTgzYS00Y2M3LTljNmQtMWM1NmYwMTdmNTg2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJibUNFTHVKa0tSbDVibStWcFFldGxuYzg3cm5DSVVOYTNiR3lYQm5ZQlZYVFFmd2xDMmFqaDFVM2hoOHczUm1EIn0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] ShellPkg/ShellPkg.dec: Change comments for PcdShellLibAutoInitialize X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Dec 2017 09:04:30 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable That's fine. Faster than me in the review response. > -----Original Message----- > From: Carsey, Jaben > Sent: Saturday, December 2, 2017 1:00 AM > To: Ni, Ruiyu ; edk2-devel@lists.01.org > Subject: RE: [PATCH] ShellPkg/ShellPkg.dec: Change comments for > PcdShellLibAutoInitialize >=20 > Apologies for delay. I missed the email on first pass. >=20 > Reviewed-by: Jaben Carsey >=20 > > -----Original Message----- > > From: Ni, Ruiyu > > Sent: Wednesday, November 29, 2017 12:22 AM > > To: edk2-devel@lists.01.org > > Cc: Carsey, Jaben > > Subject: [PATCH] ShellPkg/ShellPkg.dec: Change comments for > > PcdShellLibAutoInitialize > > Importance: High > > > > When Dynamic command drivers links to ShellLib, the ShellLib > > constructor shouldn't be called because the Shell and ShellParameters > > protocols don't exist when the driver starts. > > So it's required to set PcdShellLibAutoInitialize to FALSE for dynamic > > command drivers. > > Update the comments in DEC file to describe such requirement for this > > PCD. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Ruiyu Ni > > Cc: Jaben Carsey > > --- > > ShellPkg/ShellPkg.dec | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/ShellPkg/ShellPkg.dec b/ShellPkg/ShellPkg.dec index > > 5859c49033..48d50b87b3 100644 > > --- a/ShellPkg/ShellPkg.dec > > +++ b/ShellPkg/ShellPkg.dec > > @@ -81,6 +81,7 @@ [PcdsFeatureFlag] > > [PcdsFixedAtBuild] > > ## This flag is used to control initialization of the shell library > > # This should be FALSE for compiling the shell application itself o= nly. > > + # This should be FALSE for compiling the dynamic command drivers. > > > > gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|TRUE|BOOLEAN|0x00 > > 000005 > > > > ## This is the max buffer for ShellLib and internal Shell printings. > > -- > > 2.15.0.gvfs.1.preview.4