public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ni, Ruiyu" <ruiyu.ni@intel.com>
To: "You, Benjamin" <benjamin.you@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Agyeman, Prince" <prince.agyeman@intel.com>
Subject: Re: [PATCH] CorebootPayloadPkg/FbGop: Produces correct PixelsPerScanLine
Date: Fri, 2 Feb 2018 03:06:45 +0000	[thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5BB744FC@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20180130083845.29616-1-benjamin.you@intel.com>

Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>

Thanks/Ray

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Benjamin You
> Sent: Tuesday, January 30, 2018 4:39 PM
> To: edk2-devel@lists.01.org
> Cc: Agyeman, Prince <prince.agyeman@intel.com>
> Subject: [edk2] [PATCH] CorebootPayloadPkg/FbGop: Produces correct
> PixelsPerScanLine
> 
> According to UEFI Spec, EFI_GRAPHICS_OUTPUT_PROTOCOL.Mode->Info->
> PixelsPerScanLine may contain padding pixel elements outside the area covered
> by HorizontalResolution for performance reasons or due to hardware
> restrictions. CorebootPayloadPkg's FbGop driver doesn't follow this requirement,
> and produces PixelsPerScanLine simply as HorizontalResolution. This needs to be
> fixed to reflect the real length of a framebuffer scanline.
> 
> Cc: Maurice Ma <maurice.ma@intel.com>
> Cc: Prince Agyeman <prince.agyeman@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Benjamin You <benjamin.you@intel.com>
> ---
>  CorebootPayloadPkg/FbGop/FbGop.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/CorebootPayloadPkg/FbGop/FbGop.c
> b/CorebootPayloadPkg/FbGop/FbGop.c
> index 6790617033..ecafc95ae3 100644
> --- a/CorebootPayloadPkg/FbGop/FbGop.c
> +++ b/CorebootPayloadPkg/FbGop/FbGop.c
> @@ -893,7 +893,7 @@ FbGopCheckForVbe (
>    FbGopPrivate->GraphicsOutput.Mode->Info->VerticalResolution   =
> VerticalResolution;
>    FbGopPrivate->GraphicsOutput.Mode->Info->PixelFormat =
> CurrentModeData->PixelFormat;
>    CopyMem (&(FbGopPrivate->GraphicsOutput.Mode->Info->PixelInformation),
> &mPixelBitMask, sizeof (EFI_PIXEL_BITMASK));
> -  FbGopPrivate->GraphicsOutput.Mode->Info->PixelsPerScanLine =
> HorizontalResolution;
> +  FbGopPrivate->GraphicsOutput.Mode->Info->PixelsPerScanLine =
> + (UINT32)(BytesPerScanLine * 8 / BitsPerPixel);
>    FbGopPrivate->GraphicsOutput.Mode->SizeOfInfo =
> sizeof(EFI_GRAPHICS_OUTPUT_MODE_INFORMATION);
>    FbGopPrivate->GraphicsOutput.Mode->FrameBufferBase =
> (EFI_PHYSICAL_ADDRESS) (UINTN) CurrentModeData->LinearFrameBuffer;
>    FbGopPrivate->GraphicsOutput.Mode->FrameBufferSize =  CurrentModeData-
> >FrameBufferSize;
> --
> 2.14.3.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel


      reply	other threads:[~2018-02-02  3:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-30  8:38 [PATCH] CorebootPayloadPkg/FbGop: Produces correct PixelsPerScanLine Benjamin You
2018-02-02  3:06 ` Ni, Ruiyu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=734D49CCEBEEF84792F5B80ED585239D5BB744FC@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox