public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ni, Ruiyu" <ruiyu.ni@intel.com>
To: "Ni, Ruiyu" <ruiyu.ni@intel.com>,
	"Zeng, Star" <star.zeng@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Wu, Hao A" <hao.a.wu@intel.com>
Subject: Re: [PATCH] SourceLevelDebugPkg DebugAgentLib: Rename IsBsp to DebugAgentIsBsp
Date: Thu, 8 Feb 2018 07:18:29 +0000	[thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5BBA21B5@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <ecf831fe-2119-299e-f034-e21935ef4b10@Intel.com>

Remember to update the copyright year when committing the patch.

Thanks/Ray

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ni,
> Ruiyu
> Sent: Wednesday, February 7, 2018 11:30 AM
> To: Zeng, Star <star.zeng@intel.com>; edk2-devel@lists.01.org
> Cc: Wu, Hao A <hao.a.wu@intel.com>
> Subject: Re: [edk2] [PATCH] SourceLevelDebugPkg DebugAgentLib: Rename
> IsBsp to DebugAgentIsBsp
> 
> On 2/6/2018 8:20 PM, Star Zeng wrote:
> > For avoiding function name confliction, rename IsBsp to
> > DebugAgentIsBsp.
> >
> > Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> > Cc: Hao Wu <hao.a.wu@intel.com>
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Star Zeng <star.zeng@intel.com>
> > ---
> >
> SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAg
> ent.c | 4 ++--
> >
> SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugM
> p.c    | 4 ++--
> >
> SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugM
> p.h    | 2 +-
> >   3 files changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git
> >
> a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Debug
> Agent.c
> >
> b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Debug
> Agent.c
> > index 36b1ef924cd2..7c05ce2f2806 100644
> > ---
> >
> a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Debug
> Agent.c
> > +++
> b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Debug
> Age
> > +++ nt.c
> > @@ -2485,7 +2485,7 @@ InterruptProcess (
> >       AcquireMpSpinLock (&mDebugMpContext.DebugPortSpinLock);
> >
> >       if (MultiProcessorDebugSupport()) {
> > -      if (IsBsp (ProcessorIndex)) {
> > +      if (DebugAgentIsBsp (ProcessorIndex)) {
> >           //
> >           // If current processor is BSP, check Apic timer's init count if changed,
> >           // it may be re-written when switching BSP.
> > @@ -2498,7 +2498,7 @@ InterruptProcess (
> >           }
> >         }
> >
> > -      if (!IsBsp (ProcessorIndex) || mDebugMpContext.IpiSentByAp) {
> > +      if (!DebugAgentIsBsp (ProcessorIndex) ||
> > + mDebugMpContext.IpiSentByAp) {
> >           ReleaseMpSpinLock (&mDebugMpContext.DebugPortSpinLock);
> >           //
> >           // If current processor is not BSP or this is one IPI sent
> > by AP diff --git
> >
> a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Debug
> Mp.c
> >
> b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Debug
> Mp.c
> > index d49d4ee32347..51f40cb56b77 100644
> > ---
> >
> a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Debug
> Mp.c
> > +++
> b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Debug
> Mp.
> > +++ c
> > @@ -75,7 +75,7 @@ HaltOtherProcessors (
> >     )
> >   {
> >     DebugAgentMsgPrint (DEBUG_AGENT_INFO, "processor[%x]:Try to halt
> > other processors.\n", CurrentProcessorIndex);
> > -  if (!IsBsp (CurrentProcessorIndex)) {
> > +  if (!DebugAgentIsBsp (CurrentProcessorIndex)) {
> >       SetIpiSentByApFlag (TRUE);;
> >     }
> >
> > @@ -137,7 +137,7 @@ GetProcessorIndex (
> >
> >   **/
> >   BOOLEAN
> > -IsBsp (
> > +DebugAgentIsBsp (
> >     IN UINT32  ProcessorIndex
> >     )
> >   {
> > diff --git
> >
> a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Debug
> Mp.h
> >
> b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Debug
> Mp.h
> > index 5bb50960ca72..d9c21efdaad1 100644
> > ---
> >
> a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Debug
> Mp.h
> > +++
> b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Debug
> Mp.
> > +++ h
> > @@ -96,7 +96,7 @@ ReleaseMpSpinLock (
> >
> >   **/
> >   BOOLEAN
> > -IsBsp (
> > +DebugAgentIsBsp (
> >     IN UINT32             ProcessorIndex
> >     );
> >
> >
> Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
> 
> --
> Thanks,
> Ray
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel


      reply	other threads:[~2018-02-08  7:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-06 12:20 [PATCH] SourceLevelDebugPkg DebugAgentLib: Rename IsBsp to DebugAgentIsBsp Star Zeng
2018-02-06 12:51 ` Wu, Hao A
2018-02-07  3:30 ` Ni, Ruiyu
2018-02-08  7:18   ` Ni, Ruiyu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=734D49CCEBEEF84792F5B80ED585239D5BBA21B5@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox