From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BDE4B22361E68 for ; Wed, 7 Feb 2018 23:14:56 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Feb 2018 23:20:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,477,1511856000"; d="scan'208";a="16526532" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga008.jf.intel.com with ESMTP; 07 Feb 2018 23:20:38 -0800 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 7 Feb 2018 23:20:38 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 7 Feb 2018 23:20:37 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.125]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.130]) with mapi id 14.03.0319.002; Thu, 8 Feb 2018 15:18:29 +0800 From: "Ni, Ruiyu" To: "Ni, Ruiyu" , "Zeng, Star" , "edk2-devel@lists.01.org" CC: "Wu, Hao A" Thread-Topic: [edk2] [PATCH] SourceLevelDebugPkg DebugAgentLib: Rename IsBsp to DebugAgentIsBsp Thread-Index: AQHTn0T4GxxY/pobi0+L46y4h8uFDaOXwzuAgAJYLDA= Date: Thu, 8 Feb 2018 07:18:29 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5BBA21B5@SHSMSX104.ccr.corp.intel.com> References: <1517919657-9016-1-git-send-email-star.zeng@intel.com> In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] SourceLevelDebugPkg DebugAgentLib: Rename IsBsp to DebugAgentIsBsp X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Feb 2018 07:14:57 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Remember to update the copyright year when committing the patch. Thanks/Ray > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ni= , > Ruiyu > Sent: Wednesday, February 7, 2018 11:30 AM > To: Zeng, Star ; edk2-devel@lists.01.org > Cc: Wu, Hao A > Subject: Re: [edk2] [PATCH] SourceLevelDebugPkg DebugAgentLib: Rename > IsBsp to DebugAgentIsBsp >=20 > On 2/6/2018 8:20 PM, Star Zeng wrote: > > For avoiding function name confliction, rename IsBsp to > > DebugAgentIsBsp. > > > > Cc: Ruiyu Ni > > Cc: Hao Wu > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Star Zeng > > --- > > > SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAg > ent.c | 4 ++-- > > > SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugM > p.c | 4 ++-- > > > SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugM > p.h | 2 +- > > 3 files changed, 5 insertions(+), 5 deletions(-) > > > > diff --git > > > a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Debug > Agent.c > > > b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Debug > Agent.c > > index 36b1ef924cd2..7c05ce2f2806 100644 > > --- > > > a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Debug > Agent.c > > +++ > b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Debug > Age > > +++ nt.c > > @@ -2485,7 +2485,7 @@ InterruptProcess ( > > AcquireMpSpinLock (&mDebugMpContext.DebugPortSpinLock); > > > > if (MultiProcessorDebugSupport()) { > > - if (IsBsp (ProcessorIndex)) { > > + if (DebugAgentIsBsp (ProcessorIndex)) { > > // > > // If current processor is BSP, check Apic timer's init count= if changed, > > // it may be re-written when switching BSP. > > @@ -2498,7 +2498,7 @@ InterruptProcess ( > > } > > } > > > > - if (!IsBsp (ProcessorIndex) || mDebugMpContext.IpiSentByAp) { > > + if (!DebugAgentIsBsp (ProcessorIndex) || > > + mDebugMpContext.IpiSentByAp) { > > ReleaseMpSpinLock (&mDebugMpContext.DebugPortSpinLock); > > // > > // If current processor is not BSP or this is one IPI sent > > by AP diff --git > > > a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Debug > Mp.c > > > b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Debug > Mp.c > > index d49d4ee32347..51f40cb56b77 100644 > > --- > > > a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Debug > Mp.c > > +++ > b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Debug > Mp. > > +++ c > > @@ -75,7 +75,7 @@ HaltOtherProcessors ( > > ) > > { > > DebugAgentMsgPrint (DEBUG_AGENT_INFO, "processor[%x]:Try to halt > > other processors.\n", CurrentProcessorIndex); > > - if (!IsBsp (CurrentProcessorIndex)) { > > + if (!DebugAgentIsBsp (CurrentProcessorIndex)) { > > SetIpiSentByApFlag (TRUE);; > > } > > > > @@ -137,7 +137,7 @@ GetProcessorIndex ( > > > > **/ > > BOOLEAN > > -IsBsp ( > > +DebugAgentIsBsp ( > > IN UINT32 ProcessorIndex > > ) > > { > > diff --git > > > a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Debug > Mp.h > > > b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Debug > Mp.h > > index 5bb50960ca72..d9c21efdaad1 100644 > > --- > > > a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Debug > Mp.h > > +++ > b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Debug > Mp. > > +++ h > > @@ -96,7 +96,7 @@ ReleaseMpSpinLock ( > > > > **/ > > BOOLEAN > > -IsBsp ( > > +DebugAgentIsBsp ( > > IN UINT32 ProcessorIndex > > ); > > > > > Reviewed-by: Ruiyu Ni >=20 > -- > Thanks, > Ray > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel