From: "Ni, Ruiyu" <ruiyu.ni@intel.com>
To: "Wu, Hao A" <hao.a.wu@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Carsey, Jaben" <jaben.carsey@intel.com>
Subject: Re: [PATCH] ShellPkg/ConsoleLogger: Fix a typo in UpdateDisplayFromHistory()
Date: Sat, 3 Mar 2018 07:07:44 +0000 [thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5BBC8611@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20180303030443.8080-1-hao.a.wu@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
Thanks/Ray
> -----Original Message-----
> From: Wu, Hao A
> Sent: Saturday, March 3, 2018 11:05 AM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A <hao.a.wu@intel.com>; Carsey, Jaben
> <jaben.carsey@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>
> Subject: [PATCH] ShellPkg/ConsoleLogger: Fix a typo in
> UpdateDisplayFromHistory()
>
> Within function UpdateDisplayFromHistory():
>
> When getting a character with different attribute with the current one, the
> statement to compare the character with a 'NULL' char should be:
>
> *StringSegmentEnd != CHAR_NULL
>
> rather than:
>
> StringSegmentEnd != CHAR_NULL
>
> This commit resolves this typo.
>
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Hao Wu <hao.a.wu@intel.com>
> ---
> ShellPkg/Application/Shell/ConsoleLogger.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/ShellPkg/Application/Shell/ConsoleLogger.c
> b/ShellPkg/Application/Shell/ConsoleLogger.c
> index bc96da1f1b..074e0cf046 100644
> --- a/ShellPkg/Application/Shell/ConsoleLogger.c
> +++ b/ShellPkg/Application/Shell/ConsoleLogger.c
> @@ -2,7 +2,7 @@
> Provides interface to shell console logger.
>
> (C) Copyright 2013 Hewlett-Packard Development Company, L.P.<BR>
> - Copyright (c) 2009 - 2015, Intel Corporation. All rights reserved.<BR>
> + Copyright (c) 2009 - 2018, Intel Corporation. All rights
> + reserved.<BR>
> (C) Copyright 2016 Hewlett-Packard Development Company, L.P.<BR>
> This program and the accompanying materials
> are licensed and made available under the terms and conditions of the BSD
> License @@ -322,7 +322,7 @@ UpdateDisplayFromHistory(
> //
> StringSegmentEndChar = CHAR_NULL;
> for ( StringSegmentEnd = StringSegment
> - ; StringSegmentEnd != CHAR_NULL
> + ; *StringSegmentEnd != CHAR_NULL
> ; StringSegmentEnd++
> , Column++
> ){
> --
> 2.12.0.windows.1
next prev parent reply other threads:[~2018-03-03 7:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-03 3:04 [PATCH] ShellPkg/ConsoleLogger: Fix a typo in UpdateDisplayFromHistory() Hao Wu
2018-03-03 7:07 ` Ni, Ruiyu [this message]
2018-03-05 15:12 ` Carsey, Jaben
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=734D49CCEBEEF84792F5B80ED585239D5BBC8611@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox