From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.120; helo=mga04.intel.com; envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8F84D20955F35 for ; Fri, 2 Mar 2018 23:01:38 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Mar 2018 23:07:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,416,1515484800"; d="scan'208";a="24811926" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga002.fm.intel.com with ESMTP; 02 Mar 2018 23:07:48 -0800 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 2 Mar 2018 23:07:48 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 2 Mar 2018 23:07:48 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.125]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.116]) with mapi id 14.03.0319.002; Sat, 3 Mar 2018 15:07:45 +0800 From: "Ni, Ruiyu" To: "Wu, Hao A" , "edk2-devel@lists.01.org" CC: "Carsey, Jaben" Thread-Topic: [PATCH] ShellPkg/ConsoleLogger: Fix a typo in UpdateDisplayFromHistory() Thread-Index: AQHTspxnTcFeLWc/lk+g/LYgNSeaiKO+Fvbg Date: Sat, 3 Mar 2018 07:07:44 +0000 Deferred-Delivery: Sat, 3 Mar 2018 07:07:00 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5BBC8611@SHSMSX104.ccr.corp.intel.com> References: <20180303030443.8080-1-hao.a.wu@intel.com> In-Reply-To: <20180303030443.8080-1-hao.a.wu@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] ShellPkg/ConsoleLogger: Fix a typo in UpdateDisplayFromHistory() X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Mar 2018 07:01:39 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ruiyu Ni Thanks/Ray > -----Original Message----- > From: Wu, Hao A > Sent: Saturday, March 3, 2018 11:05 AM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Carsey, Jaben > ; Ni, Ruiyu > Subject: [PATCH] ShellPkg/ConsoleLogger: Fix a typo in > UpdateDisplayFromHistory() >=20 > Within function UpdateDisplayFromHistory(): >=20 > When getting a character with different attribute with the current one, t= he > statement to compare the character with a 'NULL' char should be: >=20 > *StringSegmentEnd !=3D CHAR_NULL >=20 > rather than: >=20 > StringSegmentEnd !=3D CHAR_NULL >=20 > This commit resolves this typo. >=20 > Cc: Jaben Carsey > Cc: Ruiyu Ni > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Hao Wu > --- > ShellPkg/Application/Shell/ConsoleLogger.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/ShellPkg/Application/Shell/ConsoleLogger.c > b/ShellPkg/Application/Shell/ConsoleLogger.c > index bc96da1f1b..074e0cf046 100644 > --- a/ShellPkg/Application/Shell/ConsoleLogger.c > +++ b/ShellPkg/Application/Shell/ConsoleLogger.c > @@ -2,7 +2,7 @@ > Provides interface to shell console logger. >=20 > (C) Copyright 2013 Hewlett-Packard Development Company, L.P.
> - Copyright (c) 2009 - 2015, Intel Corporation. All rights reserved.
> + Copyright (c) 2009 - 2018, Intel Corporation. All rights > + reserved.
> (C) Copyright 2016 Hewlett-Packard Development Company, L.P.
> This program and the accompanying materials > are licensed and made available under the terms and conditions of the = BSD > License @@ -322,7 +322,7 @@ UpdateDisplayFromHistory( > // > StringSegmentEndChar =3D CHAR_NULL; > for ( StringSegmentEnd =3D StringSegment > - ; StringSegmentEnd !=3D CHAR_NULL > + ; *StringSegmentEnd !=3D CHAR_NULL > ; StringSegmentEnd++ > , Column++ > ){ > -- > 2.12.0.windows.1