From: "Ni, Ruiyu" <ruiyu.ni@intel.com>
To: Laszlo Ersek <lersek@redhat.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Gao, Liming" <liming.gao@intel.com>, "Zeng, Star" <star.zeng@intel.com>
Subject: Re: [PATCH 1/3] MdeModulePkg/DxeResetSystemLib: Avoid depending on UefiRuntimeLib
Date: Mon, 4 Jun 2018 03:02:05 +0000 [thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5BD232D6@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <b2bf9a53-0ddc-6044-619e-1bf8c0f9c35b@redhat.com>
Haha, you are correct! I forgot to update the commit messages!
My bad!!
I will post a new version to address all concerns, including Star's.
Thanks/Ray
> -----Original Message-----
> From: Laszlo Ersek <lersek@redhat.com>
> Sent: Saturday, June 2, 2018 3:06 AM
> To: Ni, Ruiyu <ruiyu.ni@intel.com>; edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>; Zeng, Star <star.zeng@intel.com>
> Subject: Re: [edk2] [PATCH 1/3] MdeModulePkg/DxeResetSystemLib: Avoid
> depending on UefiRuntimeLib
>
> Hi Ray,
>
> On 06/01/18 09:22, Ruiyu Ni wrote:
> > Current DxeResetSystemLib depends on UefiRuntimeLib because it calls
> > EfiResetSystem() API exposed by UefiRuntimeLib.
> >
> > Due to the commit XXX which reverts UefiRuntimeLib to only support
>
> I really just cursorily skimmed the commit messages here, but I think you
> forgot to update the XXX placeholder above.
>
> Thanks!
> Laszlo
next prev parent reply other threads:[~2018-06-04 3:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-01 7:22 [PATCH 0/3] Fix bugs in core ResetSystem software stack Ruiyu Ni
2018-06-01 7:22 ` [PATCH 1/3] MdeModulePkg/DxeResetSystemLib: Avoid depending on UefiRuntimeLib Ruiyu Ni
2018-06-01 19:06 ` Laszlo Ersek
2018-06-04 3:02 ` Ni, Ruiyu [this message]
2018-06-04 2:36 ` Zeng, Star
2018-06-04 3:25 ` Ni, Ruiyu
2018-06-01 7:22 ` [PATCH 2/3] MdeModulePkg: Make sure ResetSystemRuntimeDxe uses ResetSystemLibNull Ruiyu Ni
2018-06-01 7:22 ` [PATCH 3/3] MdePkg/UefiRuntimeLib: Do not allow to be linked by DXE driver Ruiyu Ni
2018-06-01 9:24 ` Gao, Liming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=734D49CCEBEEF84792F5B80ED585239D5BD232D6@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox