From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C27F62110C812 for ; Sun, 3 Jun 2018 23:49:15 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Jun 2018 23:49:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,475,1520924400"; d="scan'208";a="205082899" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga004.jf.intel.com with ESMTP; 03 Jun 2018 23:49:15 -0700 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 3 Jun 2018 23:49:14 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 3 Jun 2018 23:49:14 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.87]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.51]) with mapi id 14.03.0319.002; Mon, 4 Jun 2018 14:49:12 +0800 From: "Ni, Ruiyu" To: "Zeng, Star" , "edk2-devel@lists.01.org" Thread-Topic: [PATCH 2/4] MdeModulePkg: Add AtaAtapiPolicy protocol definition Thread-Index: AQHT+81uyKshWRnstEmc3gKg4xObO6RPqLNA Date: Mon, 4 Jun 2018 06:49:11 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5BD2365A@SHSMSX104.ccr.corp.intel.com> References: <20180601053921.34724-1-ruiyu.ni@intel.com> <20180601053921.34724-3-ruiyu.ni@intel.com> <0C09AFA07DD0434D9E2A0C6AEB0483103BB52E86@shsmsx102.ccr.corp.intel.com> In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB0483103BB52E86@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 2/4] MdeModulePkg: Add AtaAtapiPolicy protocol definition X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Jun 2018 06:49:16 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Ok. I will update the comments. Thanks/Ray > -----Original Message----- > From: Zeng, Star > Sent: Monday, June 4, 2018 2:30 PM > To: Ni, Ruiyu ; edk2-devel@lists.01.org > Cc: Zeng, Star > Subject: RE: [PATCH 2/4] MdeModulePkg: Add AtaAtapiPolicy protocol > definition >=20 > I see below definition for PuisEnable. > + /// others: Since PUIS setting is non-volatile, platform can use other= value > than 0/1 to keep hardware PUIS setting. > + /// > + UINT8 PuisEnable; >=20 >=20 > What will the code do for DeviceSleepEnable and > AggressiveDeviceSleepEnable when their value is other value than 0/1? > Could that information be also stated? >=20 >=20 >=20 > Thanks, > Star >=20 > -----Original Message----- > From: Ni, Ruiyu > Sent: Friday, June 1, 2018 1:39 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star > Subject: [PATCH 2/4] MdeModulePkg: Add AtaAtapiPolicy protocol definition >=20 > The patch adds AtaAtapiPolicy protocol which is produced by platform and > consumed by AtaAtapiPassThruDxe driver. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ruiyu Ni > Cc: Star Zeng > --- > MdeModulePkg/Include/Protocol/AtaAtapiPolicy.h | 59 > ++++++++++++++++++++++++++ > MdeModulePkg/MdeModulePkg.dec | 3 ++ > 2 files changed, 62 insertions(+) > create mode 100644 MdeModulePkg/Include/Protocol/AtaAtapiPolicy.h >=20 > diff --git a/MdeModulePkg/Include/Protocol/AtaAtapiPolicy.h > b/MdeModulePkg/Include/Protocol/AtaAtapiPolicy.h > new file mode 100644 > index 0000000000..86a6213dc9 > --- /dev/null > +++ b/MdeModulePkg/Include/Protocol/AtaAtapiPolicy.h > @@ -0,0 +1,59 @@ > +/** @file > + ATA ATAPI Policy protocol is produced by platform and consumed by > +AtaAtapiPassThruDxe > + driver. > + > + Copyright (c) 2018, Intel Corporation. All rights reserved.
This > + program and the accompanying materials are licensed and made > + available under the terms and conditions of the BSD License which > + accompanies this distribution. The full text of the license may be > + found at http://opensource.org/licenses/bsd-license.php > + > + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" > BASIS, > + WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER > EXPRESS OR IMPLIED. > + > +**/ > +#ifndef __ATA_ATAPI_POLICY_H__ > +#define __ATA_ATAPI_POLICY_H__ > + > +#define EDKII_ATA_ATAPI_POLICY_PROTOCOL_GUID \ > + { \ > + 0xe59cd769, 0x5083, 0x4f26,{ 0x90, 0x94, 0x6c, 0x91, 0x9f, 0x91, > +0x6c, 0x4e } \ > + } > + > +typedef struct { > + /// > + /// Protocol version. > + /// > + UINT32 Version; > + > + /// > + /// 0: Disable Power-up in Standby; > + /// 1: Enable Power-up in Standby; > + /// others: Since PUIS setting is non-volatile, platform can use other= value > than 0/1 to keep hardware PUIS setting. > + /// > + UINT8 PuisEnable; > + > + /// > + /// 0: Disable Device Sleep; > + /// 1: Enable Device Sleep; > + /// > + UINT8 DeviceSleepEnable; > + > + /// > + /// 0: Disable Aggressive Device Sleep; /// 1: Enable Aggressive > + Device Sleep. > + /// > + UINT8 AggressiveDeviceSleepEnable; > + > + UINT8 Reserved; > +} EDKII_ATA_ATAPI_POLICY_PROTOCOL; > + > +#define EDKII_ATA_ATAPI_POLICY_VERSION 0x00010000 > + > + > +extern EFI_GUID gEdkiiAtaAtapiPolicyProtocolGuid; > + > + > + > +#endif > + > diff --git a/MdeModulePkg/MdeModulePkg.dec > b/MdeModulePkg/MdeModulePkg.dec index cc397185f7..3d8376ffdf 100644 > --- a/MdeModulePkg/MdeModulePkg.dec > +++ b/MdeModulePkg/MdeModulePkg.dec > @@ -595,6 +595,9 @@ [Protocols] > gEdkiiPlatformSpecificResetFilterProtocolGuid =3D { 0x695d7835, 0x8d4= 7, > 0x4c11, { 0xab, 0x22, 0xfa, 0x8a, 0xcc, 0xe7, 0xae, 0x7a } } > ## Include/Protocol/PlatformSpecificResetHandler.h > gEdkiiPlatformSpecificResetHandlerProtocolGuid =3D { 0x2df6ba0b, 0x709= 2, > 0x440d, { 0xbd, 0x4, 0xfb, 0x9, 0x1e, 0xc3, 0xf3, 0xc1 } } > + > + ## Include/Protocol/AtaAtapiPolicy.h > + gEdkiiAtaAtapiPolicyProtocolGuid =3D { 0xe59cd769, 0x5083, 0x4f26,{ > + 0x90, 0x94, 0x6c, 0x91, 0x9f, 0x91, 0x6c, 0x4e } } > # > # [Error.gEfiMdeModulePkgTokenSpaceGuid] > # 0x80000001 | Invalid value provided. > -- > 2.16.1.windows.1