public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ni, Ruiyu" <ruiyu.ni@intel.com>
To: "Bi, Dandan" <dandan.bi@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Alexei.Fedorov@arm.com" <Alexei.Fedorov@arm.com>,
	Sami Mujawar <sami.mujawar@arm.com>,
	Evan Lloyd <evan.lloyd@arm.com>,
	"Carsey, Jaben" <jaben.carsey@intel.com>
Subject: Re: [patch V2 0/2] ShellPkg/UefiShellAcpiViewCommandLib: Fix ECC issues
Date: Mon, 11 Jun 2018 02:03:10 +0000	[thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5BD2DC99@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20180606124952.77236-1-dandan.bi@intel.com>

Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>

Thanks/Ray

> -----Original Message-----
> From: Bi, Dandan
> Sent: Wednesday, June 6, 2018 8:50 PM
> To: edk2-devel@lists.01.org
> Cc: Alexei.Fedorov@arm.com; Sami Mujawar <sami.mujawar@arm.com>;
> Evan Lloyd <evan.lloyd@arm.com>; Carsey, Jaben
> <jaben.carsey@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>
> Subject: [patch V2 0/2] ShellPkg/UefiShellAcpiViewCommandLib: Fix ECC
> issues
> 
> ECC tool report some coding style issue in UefiShellAcpiViewCommandLib.
> This patch series is to clean these issues.
> 
> V2: Remove the updates of guard macros in header files in patch 2.
> 
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Evan Lloyd <evan.lloyd@arm.com>
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> 
> Dandan Bi (2):
>   ShellPkg/UefiShellAcpiViewCommandLib: Fix ECC issues
>   ShellPkg/UefiShellAcpiViewCommandLib: Fix ECC issues
> 
>  .../UefiShellAcpiViewCommandLib/AcpiParser.c       | 174 +++++++++-------
>  .../UefiShellAcpiViewCommandLib/AcpiParser.h       | 223 ++++++++++++----
> -----
>  .../UefiShellAcpiViewCommandLib/AcpiTableParser.c  |  77 +++----
>   .../UefiShellAcpiViewCommandLib/AcpiTableParser.h  |  39 ++--
>   .../Library/UefiShellAcpiViewCommandLib/AcpiView.c | 113 +++++++----
>   .../Library/UefiShellAcpiViewCommandLib/AcpiView.h |  69 ++++---
>  .../Parsers/Bgrt/BgrtParser.c                      |  12 +-
>  .../Parsers/Dbg2/Dbg2Parser.c                      |  34 ++--
>  .../Parsers/Dsdt/DsdtParser.c                      |   7 +-
>  .../Parsers/Fadt/FadtParser.c                      |  68 +++++--
>  .../Parsers/Gtdt/GtdtParser.c                      |  57 ++++--
>  .../Parsers/Iort/IortParser.c                      | 159 ++++++++-------
>  .../Parsers/Madt/MadtParser.c                      |  67 ++++---
>  .../Parsers/Mcfg/McfgParser.c                      |  18 +-
>  .../Parsers/Rsdp/RsdpParser.c                      |  42 ++--
>  .../Parsers/Slit/SlitParser.c                      |  61 +++---
>  .../Parsers/Spcr/SpcrParser.c                      |  42 ++--
>  .../Parsers/Srat/SratParser.c                      |  82 +++++---
>  .../Parsers/Ssdt/SsdtParser.c                      |   7 +-
>  .../Parsers/Xsdt/XsdtParser.c                      |  11 +-
>  .../UefiShellAcpiViewCommandLib.c                  |  18 +-
>  .../UefiShellAcpiViewCommandLib.h                  |   4 +-
>  .../UefiShellAcpiViewCommandLib.inf                |   3 +
>  23 files changed, 823 insertions(+), 564 deletions(-)
> 
> --
> 2.14.3.windows.1



      parent reply	other threads:[~2018-06-11  2:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-06 12:49 [patch V2 0/2] ShellPkg/UefiShellAcpiViewCommandLib: Fix ECC issues Dandan Bi
2018-06-06 12:49 ` [patch V2 1/2] " Dandan Bi
2018-06-06 12:49 ` [patch V2 2/2] " Dandan Bi
2018-06-11  2:03 ` Ni, Ruiyu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=734D49CCEBEEF84792F5B80ED585239D5BD2DC99@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox