From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.65; helo=mga03.intel.com; envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4734C211D0C79 for ; Wed, 13 Jun 2018 20:35:04 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Jun 2018 20:35:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,221,1526367600"; d="scan'208";a="237303592" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga006.fm.intel.com with ESMTP; 13 Jun 2018 20:35:03 -0700 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 13 Jun 2018 20:35:03 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 13 Jun 2018 20:35:02 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.87]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.82]) with mapi id 14.03.0319.002; Thu, 14 Jun 2018 11:35:00 +0800 From: "Ni, Ruiyu" To: =?iso-8859-1?Q?Marvin_H=E4user?= , "edk2-devel@lists.01.org" CC: "Carsey, Jaben" Thread-Topic: [PATCH v2] ShellPkg/UefiShellLevel2CommandsLib: Support unspecified local Timezone. Thread-Index: AQHT7dyPP02JU0LAdUmmha366FmPxqQz9xxQgCrXKhCAAHcicA== Date: Thu, 14 Jun 2018 03:34:43 +0000 Deferred-Delivery: Thu, 14 Jun 2018 03:35:00 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5BD33AF7@SHSMSX104.ccr.corp.intel.com> References: In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v2] ShellPkg/UefiShellLevel2CommandsLib: Support unspecified local Timezone. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jun 2018 03:35:04 -0000 Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ruiyu Ni Thanks/Ray > -----Original Message----- > From: Marvin H=E4user > Sent: Thursday, June 14, 2018 4:30 AM > To: edk2-devel@lists.01.org; Ni, Ruiyu > Cc: Carsey, Jaben > Subject: RE: [PATCH v2] ShellPkg/UefiShellLevel2CommandsLib: Support > unspecified local Timezone. >=20 > Good day Ruiyu, >=20 > Sorry, but you have not ack'd this V2 yet. Is there anything wrong you wa= nt > me to correct? >=20 > Thanks, > Marvin. >=20 > > -----Original Message----- > > From: Carsey, Jaben > > Sent: Thursday, May 17, 2018 4:15 PM > > To: Marvin H=E4user ; edk2- > > devel@lists.01.org > > Cc: Ni, Ruiyu > > Subject: RE: [PATCH v2] ShellPkg/UefiShellLevel2CommandsLib: Support > > unspecified local Timezone. > > > > Still looks good to me. Ray? > > > > > -----Original Message----- > > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf > > > Of Marvin H=E4user > > > Sent: Thursday, May 17, 2018 5:43 AM > > > To: edk2-devel@lists.01.org > > > Cc: Carsey, Jaben ; Ni, Ruiyu > > > > > > Subject: [edk2] [PATCH v2] ShellPkg/UefiShellLevel2CommandsLib: > > > Support unspecified local Timezone. > > > Importance: High > > > > > > EFI_RUNTIME_SERVICES.GetTime() might return an unspecified > Timezone, > > > such as when SetTime() has not been called after the PC-AT CMOS RTC > > > was cut off power. Consider this case by not attempting Timezone > > > translations for when it is invalid. > > > > > > V2: > > > - Do not change the copyright date as requested. > > > - Added R-bs from V1 as no functional changes have been made. > > > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > Signed-off-by: Marvin Haeuser > > > Reviewed-by: Jaben Carsey > > > Reviewed-by: Ruiyu Ni > > > --- > > > ShellPkg/Library/UefiShellLevel2CommandsLib/Ls.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/ShellPkg/Library/UefiShellLevel2CommandsLib/Ls.c > > > b/ShellPkg/Library/UefiShellLevel2CommandsLib/Ls.c > > > index 7d2e15f5206b..e502685a1dbb 100644 > > > --- a/ShellPkg/Library/UefiShellLevel2CommandsLib/Ls.c > > > +++ b/ShellPkg/Library/UefiShellLevel2CommandsLib/Ls.c > > > @@ -506,7 +506,7 @@ PrintLsOutput( > > > // Change the file time to local time. > > > // > > > Status =3D gRT->GetTime(&LocalTime, NULL); > > > - if (!EFI_ERROR (Status)) { > > > + if (!EFI_ERROR (Status) && (LocalTime.TimeZone !=3D > > > EFI_UNSPECIFIED_TIMEZONE)) { > > > if ((Node->Info->CreateTime.TimeZone !=3D > > > EFI_UNSPECIFIED_TIMEZONE) && > > > (Node->Info->CreateTime.Month >=3D 1 && Node->Info- > > > >CreateTime.Month <=3D 12)) { > > > // > > > -- > > > 2.17.0.windows.1 > > > > > > _______________________________________________ > > > edk2-devel mailing list > > > edk2-devel@lists.01.org > > > https://lists.01.org/mailman/listinfo/edk2-devel