public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ni, Ruiyu" <ruiyu.ni@intel.com>
To: "Wu, Hao A" <hao.a.wu@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Zeng, Star" <star.zeng@intel.com>,
	"Dong, Eric" <eric.dong@intel.com>,
	"Yao, Jiewen" <jiewen.yao@intel.com>
Subject: Re: [PATCH 3/4] MdeModulePkg: Add GUID for recovery capsule on NVM Express devices
Date: Thu, 21 Jun 2018 07:54:09 +0000	[thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5BD40C52@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20180615070342.13388-4-hao.a.wu@intel.com>

Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>

Thanks/Ray

> -----Original Message-----
> From: Wu, Hao A
> Sent: Friday, June 15, 2018 3:04 PM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A <hao.a.wu@intel.com>; Zeng, Star <star.zeng@intel.com>;
> Dong, Eric <eric.dong@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>; Yao,
> Jiewen <jiewen.yao@intel.com>
> Subject: [PATCH 3/4] MdeModulePkg: Add GUID for recovery capsule on
> NVM Express devices
> 
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Hao Wu <hao.a.wu@intel.com>
> ---
>  MdeModulePkg/Include/Guid/RecoveryDevice.h | 9 +++++++++
>  MdeModulePkg/MdeModulePkg.dec              | 3 +++
>  2 files changed, 12 insertions(+)
> 
> diff --git a/MdeModulePkg/Include/Guid/RecoveryDevice.h
> b/MdeModulePkg/Include/Guid/RecoveryDevice.h
> index b79c51c4d1..2d2cea68ec 100644
> --- a/MdeModulePkg/Include/Guid/RecoveryDevice.h
> +++ b/MdeModulePkg/Include/Guid/RecoveryDevice.h
> @@ -52,9 +52,18 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY
> KIND, EITHER EXPRESS OR IMPLIED.
>      0x0ffbce19, 0x324c, 0x4690, {0xa0, 0x09, 0x98, 0xc6, 0xae, 0x2e, 0xb1, 0x86 }
> \
>    }
> 
> +///
> +/// The Global ID used to identify a recovery capsule that was loaded from
> NVM Express device.
> +///
> +#define RECOVERY_ON_FAT_NVME_DISK_GUID \
> +  { \
> +    0xc770a27f, 0x956a, 0x497a, {0x85, 0x48, 0xe0, 0x61, 0x97, 0x58,
> +0x8b, 0xf6 } \
> +  }
> +
>  extern EFI_GUID gRecoveryOnDataCdGuid;
>  extern EFI_GUID gRecoveryOnFatFloppyDiskGuid;  extern EFI_GUID
> gRecoveryOnFatIdeDiskGuid;  extern EFI_GUID gRecoveryOnFatUsbDiskGuid;
> +extern EFI_GUID gRecoveryOnFatNvmeDiskGuid;
> 
>  #endif
> diff --git a/MdeModulePkg/MdeModulePkg.dec
> b/MdeModulePkg/MdeModulePkg.dec index 8d7c97ee91..492b67d251
> 100644
> --- a/MdeModulePkg/MdeModulePkg.dec
> +++ b/MdeModulePkg/MdeModulePkg.dec
> @@ -300,6 +300,9 @@
>    ## Include/Guid/RecoveryDevice.h
>    gRecoveryOnDataCdGuid              = { 0x5CAC0099, 0x0DC9, 0x48E5, { 0x80,
> 0x68, 0xBB, 0x95, 0xF5, 0x40, 0x0A, 0x9F }}
> 
> +  ## Include/Guid/RecoveryDevice.h
> +  gRecoveryOnFatNvmeDiskGuid         = { 0xC770A27F, 0x956A, 0x497A, { 0x85,
> 0x48, 0xE0, 0x61, 0x97, 0x58, 0x8B, 0xF6 }}
> +
>    ## Include/Guid/SmmLockBox.h
>    gEfiSmmLockBoxCommunicationGuid    = { 0x2a3cfebd, 0x27e8, 0x4d0a,
> { 0x8b, 0x79, 0xd6, 0x88, 0xc2, 0xa3, 0xe1, 0xc0 }}
> 
> --
> 2.12.0.windows.1



  reply	other threads:[~2018-06-21  7:54 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-15  7:03 [PATCH 0/4] Add PEI BlockIo support for NVM Express devices Hao Wu
2018-06-15  7:03 ` [PATCH 1/4] MdeModulePkg: Add definitions for EDKII PEI NVME host controller PPI Hao Wu
2018-06-21  7:35   ` Ni, Ruiyu
2018-06-21  8:31     ` Wu, Hao A
2018-06-22  1:42   ` Zeng, Star
2018-06-15  7:03 ` [PATCH 2/4] MdeModulePkg/NvmExpressPei: Add the NVME device PEI BlockIo support Hao Wu
2018-06-21  7:45   ` Ni, Ruiyu
2018-06-21  8:31     ` Wu, Hao A
2018-06-22  1:43   ` Zeng, Star
2018-06-15  7:03 ` [PATCH 3/4] MdeModulePkg: Add GUID for recovery capsule on NVM Express devices Hao Wu
2018-06-21  7:54   ` Ni, Ruiyu [this message]
2018-06-22  1:42   ` Zeng, Star
2018-06-15  7:03 ` [PATCH 4/4] FatPkg/FatPei: Add the recognition of recovery capsule on NVME device Hao Wu
2018-06-21  7:52   ` Ni, Ruiyu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=734D49CCEBEEF84792F5B80ED585239D5BD40C52@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox