public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ni, Ruiyu" <ruiyu.ni@intel.com>
To: "Gao, Liming" <liming.gao@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Zeng, Star" <star.zeng@intel.com>
Subject: Re: [Patch] MdeModulePkg BdsDxe: Correct VariableLockProtocol usage to match code logic
Date: Fri, 22 Jun 2018 03:09:17 +0000	[thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5BD4320E@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20180618145744.9480-1-liming.gao@intel.com>

Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>

Thanks/Ray

> -----Original Message-----
> From: Gao, Liming
> Sent: Monday, June 18, 2018 10:58 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; Zeng, Star <star.zeng@intel.com>
> Subject: [Patch] MdeModulePkg BdsDxe: Correct VariableLockProtocol usage
> to match code logic
> 
> BdsEntry marks the read-only variables if the Variable Lock protocol exists.
> So, this protocol usage is updated from CONSUMES to
> SOMETIMES_CONSUMES.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> ---
>  MdeModulePkg/Universal/BdsDxe/BdsDxe.inf | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/MdeModulePkg/Universal/BdsDxe/BdsDxe.inf
> b/MdeModulePkg/Universal/BdsDxe/BdsDxe.inf
> index b8c5aa9795..eb78d06176 100644
> --- a/MdeModulePkg/Universal/BdsDxe/BdsDxe.inf
> +++ b/MdeModulePkg/Universal/BdsDxe/BdsDxe.inf
> @@ -83,7 +83,7 @@
>  [Protocols]
>    gEfiBdsArchProtocolGuid                       ## PRODUCES
>    gEfiSimpleTextInputExProtocolGuid             ## CONSUMES
> -  gEdkiiVariableLockProtocolGuid                ## CONSUMES
> +  gEdkiiVariableLockProtocolGuid                ## SOMETIMES_CONSUMES
>    gEfiDeferredImageLoadProtocolGuid             ## CONSUMES
> 
>  [FeaturePcd]
> --
> 2.16.2.windows.1



      parent reply	other threads:[~2018-06-22  3:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-18 14:57 [Patch] MdeModulePkg BdsDxe: Correct VariableLockProtocol usage to match code logic Liming Gao
2018-06-19  2:54 ` Zeng, Star
2018-06-22  3:09 ` Ni, Ruiyu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=734D49CCEBEEF84792F5B80ED585239D5BD4320E@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox