From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ruiyu.ni@intel.com>
Received-SPF: Pass (sender SPF authorized) identity=mailfrom;
 client-ip=134.134.136.65; helo=mga03.intel.com;
 envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org 
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 4F2E6210C27A9
 for <edk2-devel@lists.01.org>; Thu, 26 Jul 2018 01:37:33 -0700 (PDT)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 26 Jul 2018 01:37:32 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.51,404,1526367600"; d="scan'208";a="70049565"
Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203])
 by orsmga003.jf.intel.com with ESMTP; 26 Jul 2018 01:36:13 -0700
Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by
 FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS)
 id 14.3.319.2; Thu, 26 Jul 2018 01:36:12 -0700
Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by
 fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS)
 id 14.3.319.2; Thu, 26 Jul 2018 01:36:12 -0700
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.81]) by
 shsmsx102.ccr.corp.intel.com ([169.254.2.124]) with mapi id 14.03.0319.002;
 Thu, 26 Jul 2018 16:36:10 +0800
From: "Ni, Ruiyu" <ruiyu.ni@intel.com>
To: "Dong, Eric" <eric.dong@intel.com>, "edk2-devel@lists.01.org"
 <edk2-devel@lists.01.org>
CC: Laszlo Ersek <lersek@redhat.com>
Thread-Topic: [Patch v3 3/3] UefiCpuPkg/MpInitLib: Not use disabled AP when
 call  StartAllAPs.
Thread-Index: AQHUI+xUdfXAKTeYg0WlSj3prYZhaaShLxoA
Date: Thu, 26 Jul 2018 08:36:09 +0000
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5BD8C4FA@SHSMSX104.ccr.corp.intel.com>
References: <20180725075020.240-1-eric.dong@intel.com>
 <20180725075020.240-4-eric.dong@intel.com>
In-Reply-To: <20180725075020.240-4-eric.dong@intel.com>
Accept-Language: en-US, zh-CN
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
MIME-Version: 1.0
Subject: Re: [Patch v3 3/3] UefiCpuPkg/MpInitLib: Not use disabled AP when call StartAllAPs.
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Thu, 26 Jul 2018 08:37:33 -0000
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

> +        if (GetApState (CpuData) =3D=3D CpuStateDisabled && !WakeUpDisab=
ledAps) {
> +          continue;
> +        }
> +
>          CpuData->ApFunction         =3D (UINTN) Procedure;
>          CpuData->ApFunctionArgument =3D (UINTN) ProcedureArgument;
>          SetApState (CpuData, CpuStateReady);

Eric, can you add more comments here to say ALL AP will be woke up by INIT-=
SIPI-SIPI,
but the AP procedure will be skipped when AP state is not Ready.