From: "Ni, Ruiyu" <ruiyu.ni@intel.com>
To: "Dong, Eric" <eric.dong@intel.com>,
"'edk2-devel@lists.01.org'" <edk2-devel@lists.01.org>
Cc: 'Laszlo Ersek' <lersek@redhat.com>
Subject: Re: [Patch v3 3/3] UefiCpuPkg/MpInitLib: Not use disabled AP when call StartAllAPs.
Date: Thu, 26 Jul 2018 08:36:26 +0000 [thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5BD8C517@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5BD8C4FA@SHSMSX104.ccr.corp.intel.com>
With that, Reviewed-by: Ruiyu Ni <Ruiyu.ni@intel.com>
Thanks/Ray
> -----Original Message-----
> From: Ni, Ruiyu
> Sent: Thursday, July 26, 2018 4:36 PM
> To: Dong, Eric <eric.dong@intel.com>; edk2-devel@lists.01.org
> Cc: Laszlo Ersek <lersek@redhat.com>
> Subject: RE: [Patch v3 3/3] UefiCpuPkg/MpInitLib: Not use disabled AP when call
> StartAllAPs.
>
> > + if (GetApState (CpuData) == CpuStateDisabled && !WakeUpDisabledAps)
> {
> > + continue;
> > + }
> > +
> > CpuData->ApFunction = (UINTN) Procedure;
> > CpuData->ApFunctionArgument = (UINTN) ProcedureArgument;
> > SetApState (CpuData, CpuStateReady);
>
> Eric, can you add more comments here to say ALL AP will be woke up by INIT-
> SIPI-SIPI, but the AP procedure will be skipped when AP state is not Ready.
next prev parent reply other threads:[~2018-07-26 8:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-25 7:50 [Patch V3 0/3] StartAllAPs should not use disabled APs Eric Dong
2018-07-25 7:50 ` [Patch v3 1/3] UefiCpuPkg/MpInitLib: Remove redundant CpuStateFinished State Eric Dong
2018-07-25 10:54 ` Laszlo Ersek
2018-07-25 11:15 ` Dong, Eric
2018-07-26 5:18 ` Ni, Ruiyu
2018-07-25 7:50 ` [Patch v3 2/3] UefiCpuPkg/MpInitLib: Remove StartCount and volatile definition Eric Dong
2018-07-25 11:47 ` Laszlo Ersek
2018-07-25 12:09 ` Dong, Eric
2018-07-25 15:18 ` Laszlo Ersek
2018-07-26 5:22 ` Ni, Ruiyu
2018-07-25 7:50 ` [Patch v3 3/3] UefiCpuPkg/MpInitLib: Not use disabled AP when call StartAllAPs Eric Dong
2018-07-25 12:11 ` Laszlo Ersek
2018-07-25 12:44 ` Dong, Eric
2018-07-26 8:36 ` Ni, Ruiyu
2018-07-26 8:36 ` Ni, Ruiyu [this message]
2018-07-25 12:12 ` [Patch V3 0/3] StartAllAPs should not use disabled APs Laszlo Ersek
2018-07-25 15:18 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=734D49CCEBEEF84792F5B80ED585239D5BD8C517@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox