From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.24; helo=mga09.intel.com; envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BC35A210DF749 for ; Tue, 7 Aug 2018 22:06:06 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Aug 2018 22:06:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,456,1526367600"; d="scan'208";a="64405723" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga006.jf.intel.com with ESMTP; 07 Aug 2018 22:06:03 -0700 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 7 Aug 2018 22:06:02 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 7 Aug 2018 22:06:02 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.143]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.150]) with mapi id 14.03.0319.002; Wed, 8 Aug 2018 13:06:00 +0800 From: "Ni, Ruiyu" To: "Zhang, Shenglei" , "edk2-devel@lists.01.org" CC: "Gao, Liming" Thread-Topic: [edk2] [PATCH 3/6] IntelFrameworkModulePkg IdeBusDxe: Remove redundant functions Thread-Index: AQHULsVb4AQ2XwMUTUOMU/Tf6bunRaS1TTPQ Date: Wed, 8 Aug 2018 05:05:24 +0000 Deferred-Delivery: Wed, 8 Aug 2018 05:06:00 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5BDC41A1@SHSMSX104.ccr.corp.intel.com> References: <20180808030854.30124-1-shenglei.zhang@intel.com> <20180808030854.30124-4-shenglei.zhang@intel.com> In-Reply-To: <20180808030854.30124-4-shenglei.zhang@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 3/6] IntelFrameworkModulePkg IdeBusDxe: Remove redundant functions X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Aug 2018 05:06:06 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ruiyu Ni Thanks/Ray > -----Original Message----- > From: edk2-devel On Behalf Of shenglei > Sent: Wednesday, August 8, 2018 11:09 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [edk2] [PATCH 3/6] IntelFrameworkModulePkg IdeBusDxe: Remove > redundant functions >=20 > The redundant functions which are never called have been removed. > They are AtaNonDataCommandInExt,IDEBusDriverConfigurationSetOptions, > GetResponse,IDEBusDriverConfigurationOptionsValid and > IDEBusDriverConfigurationForceDefaults. > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1063 >=20 > Cc: Liming Gao > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: shenglei > --- > .../Bus/Pci/IdeBusDxe/Ata.c | 119 -------- > .../Bus/Pci/IdeBusDxe/DriverConfiguration.c | 261 ------------------ > .../Bus/Pci/IdeBusDxe/Ide.h | 24 -- > .../Bus/Pci/IdeBusDxe/IdeBus.h | 113 -------- > 4 files changed, 517 deletions(-) >=20 > diff --git a/IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/Ata.c > b/IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/Ata.c > index 7819773f38..2ca06806d5 100644 > --- a/IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/Ata.c > +++ b/IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/Ata.c > @@ -2676,124 +2676,5 @@ AtaNonDataCommandIn ( > return EFI_SUCCESS; > } >=20 > -/** > - Send ATA Ext command into device with NON_DATA protocol > - > - @param IdeDev Standard IDE device private data structure > - @param AtaCommand The ATA command to be sent > - @param Device The value in Device register > - @param Feature The value in Feature register > - @param SectorCount The value in SectorCount register > - @param LbaAddress The LBA address in 48-bit mode > - > - @retval EFI_SUCCESS Reading succeed > - @retval EFI_ABORTED Command failed > - @retval EFI_DEVICE_ERROR Device status error. > - > -**/ > -EFI_STATUS > -AtaNonDataCommandInExt ( > - IN IDE_BLK_IO_DEV *IdeDev, > - IN UINT8 AtaCommand, > - IN UINT8 Device, > - IN UINT16 Feature, > - IN UINT16 SectorCount, > - IN EFI_LBA LbaAddress > - ) > -{ > - EFI_STATUS Status; > - UINT8 StatusRegister; > - UINT8 SectorCount8; > - UINT8 Feature8; > - UINT8 LbaLow; > - UINT8 LbaMid; > - UINT8 LbaHigh; > - > - Status =3D WaitForBSYClear (IdeDev, ATATIMEOUT); > - if (EFI_ERROR (Status)) { > - return EFI_DEVICE_ERROR; > - } > - > - // > - // Select device (bit4), set LBA mode(bit6) (use 0xe0 for compatibilit= y) > - // > - IDEWritePortB ( > - IdeDev->PciIo, > - IdeDev->IoPort->Head, > - (UINT8) ((IdeDev->Device << 4) | 0xe0) > - ); > - > - // > - // ATA commands for ATA device must be issued when DRDY is set > - // > - Status =3D DRDYReady (IdeDev, ATATIMEOUT); > - if (EFI_ERROR (Status)) { > - return EFI_DEVICE_ERROR; > - } > - > - // > - // Pass parameter into device register block > - // > - IDEWritePortB (IdeDev->PciIo, IdeDev->IoPort->Head, Device); > - > - // > - // Fill the feature register, which is a two-byte FIFO. Need write twi= ce. > - // > - Feature8 =3D (UINT8) (Feature >> 8); > - IDEWritePortB (IdeDev->PciIo, IdeDev->IoPort->Reg1.Feature, Feature8); > - > - Feature8 =3D (UINT8) Feature; > - IDEWritePortB (IdeDev->PciIo, IdeDev->IoPort->Reg1.Feature, Feature8); > - > - // > - // Fill the sector count register, which is a two-byte FIFO. Need writ= e twice. > - // > - SectorCount8 =3D (UINT8) (SectorCount >> 8); > - IDEWritePortB (IdeDev->PciIo, IdeDev->IoPort->SectorCount, > SectorCount8); > - > - SectorCount8 =3D (UINT8) SectorCount; > - IDEWritePortB (IdeDev->PciIo, IdeDev->IoPort->SectorCount, > SectorCount8); > - > - // > - // Fill the start LBA registers, which are also two-byte FIFO > - // > - LbaLow =3D (UINT8) RShiftU64 (LbaAddress, 24); > - LbaMid =3D (UINT8) RShiftU64 (LbaAddress, 32); > - LbaHigh =3D (UINT8) RShiftU64 (LbaAddress, 40); > - IDEWritePortB (IdeDev->PciIo, IdeDev->IoPort->SectorNumber, LbaLow); > - IDEWritePortB (IdeDev->PciIo, IdeDev->IoPort->CylinderLsb, LbaMid); > - IDEWritePortB (IdeDev->PciIo, IdeDev->IoPort->CylinderMsb, LbaHigh); > - > - LbaLow =3D (UINT8) LbaAddress; > - LbaMid =3D (UINT8) RShiftU64 (LbaAddress, 8); > - LbaHigh =3D (UINT8) RShiftU64 (LbaAddress, 16); > - IDEWritePortB (IdeDev->PciIo, IdeDev->IoPort->SectorNumber, LbaLow); > - IDEWritePortB (IdeDev->PciIo, IdeDev->IoPort->CylinderLsb, LbaMid); > - IDEWritePortB (IdeDev->PciIo, IdeDev->IoPort->CylinderMsb, LbaHigh); > - > - // > - // Send command via Command Register > - // > - IDEWritePortB (IdeDev->PciIo, IdeDev->IoPort->Reg.Command, > AtaCommand); > - > - // > - // Wait for command completion > - // > - Status =3D WaitForBSYClear (IdeDev, ATATIMEOUT); > - if (EFI_ERROR (Status)) { > - return EFI_DEVICE_ERROR; > - } > - > - StatusRegister =3D IDEReadPortB (IdeDev->PciIo, IdeDev->IoPort- > >Reg.Status); > - if ((StatusRegister & ATA_STSREG_ERR) =3D=3D ATA_STSREG_ERR) { > - // > - // Failed to execute command, abort operation > - // > - return EFI_ABORTED; > - } > - > - return EFI_SUCCESS; > -} > - >=20 >=20 > diff --git > a/IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/DriverConfiguration.c > b/IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/DriverConfiguration.c > index 3a5d3c6f6b..8f72240386 100644 > --- a/IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/DriverConfiguration.c > +++ b/IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/DriverConfiguration.c > @@ -26,267 +26,6 @@ CHAR16 *OptionString[4] =3D { // // EFI Driver > Configuration Protocol // -EFI_DRIVER_CONFIGURATION_PROTOCOL > gIDEBusDriverConfiguration =3D { > - IDEBusDriverConfigurationSetOptions, > - IDEBusDriverConfigurationOptionsValid, > - IDEBusDriverConfigurationForceDefaults, > - "eng" > -}; > - > -/** > - Interprete keyboard input. > - > - @retval EFI_ABORTED Get an 'ESC' key inputed. > - @retval EFI_SUCCESS Get an 'Y' or 'y' inputed. > - @retval EFI_NOT_FOUND Get an 'N' or 'n' inputed.. > - > -**/ > -EFI_STATUS > -GetResponse ( > - VOID > - ) > -{ > - EFI_STATUS Status; > - EFI_INPUT_KEY Key; > - > - while (TRUE) { > - Status =3D gST->ConIn->ReadKeyStroke (gST->ConIn, &Key); > - if (!EFI_ERROR (Status)) { > - if (Key.ScanCode =3D=3D SCAN_ESC) { > - return EFI_ABORTED; > - } > - > - switch (Key.UnicodeChar) { > - > - // > - // fall through > - // > - case L'y': > - case L'Y': > - gST->ConOut->OutputString (gST->ConOut, L"Y\n"); > - return EFI_SUCCESS; > - > - // > - // fall through > - // > - case L'n': > - case L'N': > - gST->ConOut->OutputString (gST->ConOut, L"N\n"); > - return EFI_NOT_FOUND; > - } > - > - } > - } > -} > - > -/** > - Allows the user to set controller specific options for a controller th= at a > - driver is currently managing. > - > - @param This A pointer to the EFI_DRIVER_CONFIGURATION_ > PROTOCOL instance. > - @param ControllerHandle The handle of the controller to set options = on. > - @param ChildHandle The handle of the child controller to set op= tions on. > - This is an optional parameter that may be NU= LL. > - It will be NULL for device drivers, and for = a bus drivers > - that wish to set options for the bus control= ler. > - It will not be NULL for a bus driver that wi= shes to set > - options for one of its child controllers. > - @param Language A pointer to a three character ISO 639-2 lan= guage > identifier. > - This is the language of the user interface t= hat should be > presented > - to the user, and it must match one of the la= nguages specified > in > - SupportedLanguages. The number of languages = supported by > a driver is up to > - the driver writer. > - @param ActionRequired A pointer to the action that the calling age= nt is > required > - to perform when this function returns. > - > - > - @retval EFI_SUCCESS The driver specified by This successful= ly set the > configuration > - options for the controller specified by= ControllerHandle.. > - @retval EFI_INVALID_PARAMETER ControllerHandle is not a valid > EFI_HANDLE. > - @retval EFI_INVALID_PARAMETER ChildHandle is not NULL and it is not a > valid EFI_HANDLE. > - @retval EFI_INVALID_PARAMETER ActionRequired is NULL. > - @retval EFI_UNSUPPORTED The driver specified by This does not > support setting configuration options for > - the controller specified by ControllerH= andle and > ChildHandle. > - @retval EFI_UNSUPPORTED The driver specified by This does not > support the language specified by Language. > - @retval EFI_DEVICE_ERROR A device error occurred while attempt t= o > set the configuration options for the > - controller specified by ControllerHandl= e and ChildHandle. > - @retval EFI_OUT_RESOURCES There are not enough resources availabl= e > to set the configuration options for the > - controller specified by ControllerHandl= e and ChildHandle > -**/ > -EFI_STATUS > -EFIAPI > -IDEBusDriverConfigurationSetOptions ( > - IN EFI_DRIVER_CONFIGURATION_PROTOCOL *This, > - IN EFI_HANDLE ControllerH= andle, > - IN EFI_HANDLE ChildHandle= OPTIONAL, > - IN CHAR8 *Language, > - OUT EFI_DRIVER_CONFIGURATION_ACTION_REQUIRED > *ActionRequired > - ) > -{ > - EFI_STATUS Status; > - UINT8 Value; > - UINT8 NewValue; > - UINTN DataSize; > - UINTN Index; > - > - if (ChildHandle !=3D NULL) { > - return EFI_UNSUPPORTED; > - } > - > - *ActionRequired =3D EfiDriverConfigurationActionNone; >=20 > - DataSize =3D sizeof (Value); > - Status =3D gRT->GetVariable ( > - L"Configuration", > - &gEfiCallerIdGuid, > - NULL, > - &DataSize, > - &Value > - ); > - > - gST->ConOut->OutputString (gST->ConOut, L"IDE Bus Driver > Configuration\n"); > - gST->ConOut->OutputString (gST->ConOut, > L"=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D\n"); > - > - NewValue =3D 0; > - for (Index =3D 0; Index < 4; Index++) { > - gST->ConOut->OutputString (gST->ConOut, OptionString[Index]); > - > - Status =3D GetResponse (); > - if (Status =3D=3D EFI_ABORTED) { > - return EFI_SUCCESS; > - } > - > - if (!EFI_ERROR (Status)) { > - NewValue =3D (UINT8) (NewValue | (1 << Index)); > - } > - } > - > - if (EFI_ERROR (Status) || (NewValue !=3D Value)) { > - gRT->SetVariable ( > - L"Configuration", > - &gEfiCallerIdGuid, > - EFI_VARIABLE_NON_VOLATILE | > EFI_VARIABLE_BOOTSERVICE_ACCESS, > - sizeof (NewValue), > - &NewValue > - ); > - > - *ActionRequired =3D EfiDriverConfigurationActionRestartController; > - } else { > - *ActionRequired =3D EfiDriverConfigurationActionNone; > - } > - > - return EFI_SUCCESS; > -} > - > -/** > - Tests to see if a controller's current configuration options are valid= . > - > - @param This A pointer to the > EFI_DRIVER_CONFIGURATION_PROTOCOL instance. > - @param ControllerHandle The handle of the controller to test if it's = current > configuration options > - are valid. > - @param ChildHandle The handle of the child controller to test if= it's > current configuration > - options are valid. This is an optional param= eter that may be > NULL. It will > - be NULL for device drivers. It will also be = NULL for a bus drivers > that > - wish to test the configuration options for th= e bus controller. It > will > - not be NULL for a bus driver that wishes to t= est configuration > options for > - one of its child controllers. > - @retval EFI_SUCCESS The controller specified by ControllerH= andle > and ChildHandle that is being > - managed by the driver specified by This= has a valid set of > configuration > - options. > - @retval EFI_INVALID_PARAMETER ControllerHandle is not a valid > EFI_HANDLE. > - @retval EFI_INVALID_PARAMETER ChildHandle is not NULL and it is not a > valid EFI_HANDLE. > - @retval EFI_UNSUPPORTED The driver specified by This is not cur= rently > managing the controller > - specified by ControllerHandle and Child= Handle. > - @retval EFI_DEVICE_ERROR The controller specified by ControllerH= andle > and ChildHandle that is being > - managed by the driver specified by This= has an invalid set of > configuration > - options. > -**/ > -EFI_STATUS > -EFIAPI > -IDEBusDriverConfigurationOptionsValid ( > - IN EFI_DRIVER_CONFIGURATION_PROTOCOL *This, > - IN EFI_HANDLE ControllerHandle, > - IN EFI_HANDLE ChildHandle OPTIO= NAL > - ) > -{ > - EFI_STATUS Status; > - UINT8 Value; > - UINTN DataSize; > - > - if (ChildHandle !=3D NULL) { > - return EFI_UNSUPPORTED; > - } > - > - DataSize =3D sizeof (Value); > - Status =3D gRT->GetVariable ( > - L"Configuration", > - &gEfiCallerIdGuid, > - NULL, > - &DataSize, > - &Value > - ); > - if (EFI_ERROR (Status) || Value > 0x0f) { > - return EFI_DEVICE_ERROR; > - } > - > - return EFI_SUCCESS; > -} > -/** > - Forces a driver to set the default configuration options for a control= ler. > - > - @param This A pointer to the EFI_DRIVER_CONFIGURATION_ > PROTOCOL instance. > - @param ControllerHandle The handle of the controller to force default > configuration options on. > - @param ChildHandle The handle of the child controller to force d= efault > configuration > - options on This is an optional parameter tha= t may be NULL. It > - will be NULL for device drivers. It will also= be NULL for a bus > - drivers that wish to force default configurat= ion options for the > bus > - controller. It will not be NULL for a bus dr= iver that wishes to > force > - default configuration options for one of its = child controllers. > - @param DefaultType The type of default configuration options to = force > on the controller > - specified by ControllerHandle and ChildHandle= . > - @param ActionRequired A pointer to the action that the calling agen= t is > required to perform > - when this function returns. > - > - @retval EFI_SUCCESS The driver specified by This successful= ly forced > the > - default configuration options on the co= ntroller specified by > - ControllerHandle and ChildHandle. > - @retval EFI_INVALID_PARAMETER ControllerHandle is not a valid > EFI_HANDLE. > - @retval EFI_INVALID_PARAMETER ChildHandle is not NULL and it is not a > valid EFI_HANDLE. > - @retval EFI_INVALID_PARAMETER ActionRequired is NULL. > - @retval EFI_UNSUPPORTED The driver specified by This does not > support forcing the default > - configuration options on the controller= specified by > ControllerHandle > - and ChildHandle. > - @retval EFI_UNSUPPORTED The driver specified by This does not > support the configuration type > - specified by DefaultType. > - @retval EFI_DEVICE_ERROR A device error occurred while attempt t= o > force the default configuration > - options on the controller specified by = ControllerHandle and > ChildHandle. > - @retval EFI_OUT_RESOURCES There are not enough resources availabl= e > to force the default configuration > - options on the controller specified by = ControllerHandle and > ChildHandle. > -**/ > -EFI_STATUS > -EFIAPI > -IDEBusDriverConfigurationForceDefaults ( > - IN EFI_DRIVER_CONFIGURATION_PROTOCOL *This, > - IN EFI_HANDLE ControllerH= andle, > - IN EFI_HANDLE ChildHandle= OPTIONAL, > - IN UINT32 DefaultType= , > - OUT EFI_DRIVER_CONFIGURATION_ACTION_REQUIRED > *ActionRequired > - ) > -{ > - UINT8 Value; >=20 > - if (ChildHandle !=3D NULL) { > - return EFI_UNSUPPORTED; > - } >=20 > - Value =3D 0x0f; > - gRT->SetVariable ( > - L"Configuration", > - &gEfiCallerIdGuid, > - EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS, > - sizeof (Value), > - &Value > - ); > - *ActionRequired =3D EfiDriverConfigurationActionRestartController; > - return EFI_SUCCESS; > -} > diff --git a/IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/Ide.h > b/IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/Ide.h > index 0fe6c6d502..5d2bf2cacd 100644 > --- a/IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/Ide.h > +++ b/IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/Ide.h > @@ -768,30 +768,6 @@ AtaNonDataCommandIn ( > IN UINT8 LbaHigh > ); >=20 > -/** > - Send ATA Ext command into device with NON_DATA protocol. > - > - @param IdeDev Standard IDE device private data structure > - @param AtaCommand The ATA command to be sent > - @param Device The value in Device register > - @param Feature The value in Feature register > - @param SectorCount The value in SectorCount register > - @param LbaAddress The Lba address in 48-bit mode > - > - @retval EFI_SUCCESS Reading succeed > - @retval EFI_ABORTED Command failed > - @retval EFI_DEVICE_ERROR Device status error. > - > -**/ > -EFI_STATUS > -AtaNonDataCommandInExt ( > - IN IDE_BLK_IO_DEV *IdeDev, > - IN UINT8 AtaCommand, > - IN UINT8 Device, > - IN UINT16 Feature, > - IN UINT16 SectorCount, > - IN EFI_LBA LbaAddress > - ); > /** > Enable Long Physical Sector Feature for ATA device. >=20 > diff --git a/IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/IdeBus.h > b/IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/IdeBus.h > index 7ec872275d..830661e39a 100644 > --- a/IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/IdeBus.h > +++ b/IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/IdeBus.h > @@ -180,122 +180,9 @@ IDEBusDriverBindingStop ( // // EFI Driver > Configuration Functions // > -/** > - Allows the user to set controller specific options for a controller th= at a > - driver is currently managing. > - > - @param This A pointer to the EFI_DRIVER_CONFIGURATION_ > PROTOCOL instance. > - @param ControllerHandle The handle of the controller to set options = on. > - @param ChildHandle The handle of the child controller to set op= tions on. > - This is an optional parameter that may be NU= LL. > - It will be NULL for device drivers, and for = a bus drivers > - that wish to set options for the bus control= ler. > - It will not be NULL for a bus driver that wi= shes to set > - options for one of its child controllers. > - @param Language A pointer to a three character ISO 639-2 lan= guage > identifier. > - This is the language of the user interface t= hat should be > presented > - to the user, and it must match one of the la= nguages specified > in > - SupportedLanguages. The number of languages = supported by > a driver is up to > - the driver writer. > - @param ActionRequired A pointer to the action that the calling age= nt is > required > - to perform when this function returns. > - > - > - @retval EFI_SUCCESS The driver specified by This successful= ly set the > configuration > - options for the controller specified by= ControllerHandle.. > - @retval EFI_INVALID_PARAMETER ControllerHandle is not a valid > EFI_HANDLE. > - @retval EFI_INVALID_PARAMETER ChildHandle is not NULL and it is not a > valid EFI_HANDLE. > - @retval EFI_INVALID_PARAMETER ActionRequired is NULL. > - @retval EFI_UNSUPPORTED The driver specified by This does not > support setting configuration options for > - the controller specified by ControllerH= andle and > ChildHandle. > - @retval EFI_UNSUPPORTED The driver specified by This does not > support the language specified by Language. > - @retval EFI_DEVICE_ERROR A device error occurred while attempt t= o > set the configuration options for the > - controller specified by ControllerHandl= e and ChildHandle. > - @retval EFI_OUT_RESOURCES There are not enough resources availabl= e > to set the configuration options for the > - controller specified by ControllerHandl= e and ChildHandle > -**/ > -EFI_STATUS > -EFIAPI > -IDEBusDriverConfigurationSetOptions ( > - IN EFI_DRIVER_CONFIGURATION_PROTOCOL *This, > - IN EFI_HANDLE ControllerH= andle, > - IN EFI_HANDLE ChildHandle= OPTIONAL, > - IN CHAR8 *Language, > - OUT EFI_DRIVER_CONFIGURATION_ACTION_REQUIRED > *ActionRequired > - ); >=20 > -/** > - Tests to see if a controller's current configuration options are valid= . > - > - @param This A pointer to the > EFI_DRIVER_CONFIGURATION_PROTOCOL instance. > - @param ControllerHandle The handle of the controller to test if it's = current > configuration options > - are valid. > - @param ChildHandle The handle of the child controller to test if= it's > current configuration > - options are valid. This is an optional param= eter that may be > NULL. It will > - be NULL for device drivers. It will also be = NULL for a bus drivers > that > - wish to test the configuration options for th= e bus controller. It > will > - not be NULL for a bus driver that wishes to t= est configuration > options for > - one of its child controllers. > - @retval EFI_SUCCESS The controller specified by ControllerH= andle > and ChildHandle that is being > - managed by the driver specified by This= has a valid set of > configuration > - options. > - @retval EFI_INVALID_PARAMETER ControllerHandle is not a valid > EFI_HANDLE. > - @retval EFI_INVALID_PARAMETER ChildHandle is not NULL and it is not a > valid EFI_HANDLE. > - @retval EFI_UNSUPPORTED The driver specified by This is not cur= rently > managing the controller > - specified by ControllerHandle and Child= Handle. > - @retval EFI_DEVICE_ERROR The controller specified by ControllerH= andle > and ChildHandle that is being > - managed by the driver specified by This= has an invalid set of > configuration > - options. > -**/ > -EFI_STATUS > -EFIAPI > -IDEBusDriverConfigurationOptionsValid ( > - IN EFI_DRIVER_CONFIGURATION_PROTOCOL *This, > - IN EFI_HANDLE ControllerHandle, > - IN EFI_HANDLE ChildHandle OPTIO= NAL > - ); >=20 > -/** > - Forces a driver to set the default configuration options for a control= ler. > - > - @param This A pointer to the EFI_DRIVER_CONFIGURATION_ > PROTOCOL instance. > - @param ControllerHandle The handle of the controller to force default > configuration options on. > - @param ChildHandle The handle of the child controller to force d= efault > configuration > - options on This is an optional parameter tha= t may be NULL. It > - will be NULL for device drivers. It will also= be NULL for a bus > - drivers that wish to force default configurat= ion options for the > bus > - controller. It will not be NULL for a bus dr= iver that wishes to > force > - default configuration options for one of its = child controllers. > - @param DefaultType The type of default configuration options to = force > on the controller > - specified by ControllerHandle and ChildHandle= . > - @param ActionRequired A pointer to the action that the calling agen= t is > required to perform > - when this function returns. >=20 > - @retval EFI_SUCCESS The driver specified by This successful= ly forced > the > - default configuration options on the co= ntroller specified by > - ControllerHandle and ChildHandle. > - @retval EFI_INVALID_PARAMETER ControllerHandle is not a valid > EFI_HANDLE. > - @retval EFI_INVALID_PARAMETER ChildHandle is not NULL and it is not a > valid EFI_HANDLE. > - @retval EFI_INVALID_PARAMETER ActionRequired is NULL. > - @retval EFI_UNSUPPORTED The driver specified by This does not > support forcing the default > - configuration options on the controller= specified by > ControllerHandle > - and ChildHandle. > - @retval EFI_UNSUPPORTED The driver specified by This does not > support the configuration type > - specified by DefaultType. > - @retval EFI_DEVICE_ERROR A device error occurred while attempt t= o > force the default configuration > - options on the controller specified by = ControllerHandle and > ChildHandle. > - @retval EFI_OUT_RESOURCES There are not enough resources availabl= e > to force the default configuration > - options on the controller specified by = ControllerHandle and > ChildHandle. > -**/ > -EFI_STATUS > -EFIAPI > -IDEBusDriverConfigurationForceDefaults ( > - IN EFI_DRIVER_CONFIGURATION_PROTOCOL *This, > - IN EFI_HANDLE ControllerH= andle, > - IN EFI_HANDLE ChildHandle= OPTIONAL, > - IN UINT32 DefaultType= , > - OUT EFI_DRIVER_CONFIGURATION_ACTION_REQUIRED > *ActionRequired > - ); >=20 > // > // EFI Driver Diagnostics Functions > -- > 2.18.0.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel