public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ni, Ruiyu" <ruiyu.ni@intel.com>
To: "Zhang, Shenglei" <shenglei.zhang@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Gao, Liming" <liming.gao@intel.com>
Subject: Re: [PATCH 1/6] IntelFrameworkModulePkg IsaIoDxe: Remove a redundant protocol
Date: Wed, 8 Aug 2018 05:05:24 +0000	[thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5BDC41A6@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20180808030854.30124-2-shenglei.zhang@intel.com>

Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>

Thanks/Ray

> -----Original Message-----
> From: edk2-devel <edk2-devel-bounces@lists.01.org> On Behalf Of shenglei
> Sent: Wednesday, August 8, 2018 11:09 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>
> Subject: [edk2] [PATCH 1/6] IntelFrameworkModulePkg IsaIoDxe: Remove a
> redundant protocol
> 
> Remove a redundant protocol which is gEfiGenericMemTestProtocolGuid.
> https://bugzilla.tianocore.org/show_bug.cgi?id=1063
> 
> Cc: Liming Gao <liming.gao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: shenglei <shenglei.zhang@intel.com>
> ---
>  IntelFrameworkModulePkg/Bus/Isa/IsaIoDxe/IsaDriver.h  | 1 -
> IntelFrameworkModulePkg/Bus/Isa/IsaIoDxe/IsaIoDxe.inf | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/IntelFrameworkModulePkg/Bus/Isa/IsaIoDxe/IsaDriver.h
> b/IntelFrameworkModulePkg/Bus/Isa/IsaIoDxe/IsaDriver.h
> index 9639d18318..6b1aaeda0e 100644
> --- a/IntelFrameworkModulePkg/Bus/Isa/IsaIoDxe/IsaDriver.h
> +++ b/IntelFrameworkModulePkg/Bus/Isa/IsaIoDxe/IsaDriver.h
> @@ -24,7 +24,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY
> KIND, EITHER EXPRESS OR IMPLIED.
>  #include <Protocol/IsaIo.h>
>  #include <Protocol/DevicePath.h>
>  #include <Protocol/DriverBinding.h>
> -#include <Protocol/GenericMemoryTest.h>  #include
> <Guid/StatusCodeDataTypeId.h>
> 
>  #include <Library/DebugLib.h>
> diff --git a/IntelFrameworkModulePkg/Bus/Isa/IsaIoDxe/IsaIoDxe.inf
> b/IntelFrameworkModulePkg/Bus/Isa/IsaIoDxe/IsaIoDxe.inf
> index 6f02aea7af..247c66151b 100644
> --- a/IntelFrameworkModulePkg/Bus/Isa/IsaIoDxe/IsaIoDxe.inf
> +++ b/IntelFrameworkModulePkg/Bus/Isa/IsaIoDxe/IsaIoDxe.inf
> @@ -62,7 +62,6 @@
>    gEfiSioProtocolGuid                           ## TO_START
>    gEfiPciIoProtocolGuid                         ## TO_START
>    gEfiDevicePathProtocolGuid                    ## TO_START
> -  gEfiGenericMemTestProtocolGuid                ## TO_START
> 
>  [Pcd]
> 
> gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdIsaBusSupportedFeatur
> es  ## CONSUMES
> --
> 2.18.0.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel


  reply	other threads:[~2018-08-08  5:06 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-08  3:08 [PATCH 0/6] IntelFrameworkModulePkg: Remove something reduntdant shenglei
2018-08-08  3:08 ` [PATCH 1/6] IntelFrameworkModulePkg IsaIoDxe: Remove a redundant protocol shenglei
2018-08-08  5:05   ` Ni, Ruiyu [this message]
2018-08-08  3:08 ` [PATCH 2/6] IntelFrameworkModulePkg Ps2KeyboardDxe: Remove a redundant function shenglei
2018-08-08  5:05   ` Ni, Ruiyu
2018-08-08  3:08 ` [PATCH 3/6] IntelFrameworkModulePkg IdeBusDxe: Remove redundant functions shenglei
2018-08-08  5:05   ` Ni, Ruiyu
2018-08-08  3:08 ` [PATCH 4/6] IntelFrameworkModulePkg Snp16Dxe: " shenglei
     [not found]   ` <C0706E73DB8C124D9B9C38AA364E5D5E5E1B89@shsmsx102.ccr.corp.intel.com>
2018-08-24  3:28     ` Ni, Ruiyu
2018-08-08  3:08 ` [PATCH 5/6] IntelFrameworkModulePkg LegacyBiosDxe: Remove redundant LibraryClasses shenglei
2018-08-08  5:04   ` Ni, Ruiyu
2018-08-08  3:08 ` [PATCH 6/6] IntelFrameworkModulePkg BdsDxe: Remove redundant functions shenglei
2018-08-08  5:04   ` Ni, Ruiyu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=734D49CCEBEEF84792F5B80ED585239D5BDC41A6@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox