Re: [PATCH 2/6] IntelFrameworkModulePkg Ps2KeyboardDxe: Remove a redundant function

["Ni, Ruiyu" <ruiyu.ni@intel.com>]

Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>

Thanks/Ray

> -----Original Message-----
> From: edk2-devel <edk2-devel-bounces@lists.01.org> On Behalf Of shenglei
> Sent: Wednesday, August 8, 2018 11:09 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>
> Subject: [edk2] [PATCH 2/6] IntelFrameworkModulePkg Ps2KeyboardDxe:
> Remove a redundant function
> 
> The redundant function DisableKeyboard which is never called has been
> removed.
> https://bugzilla.tianocore.org/show_bug.cgi?id=1063
> 
> Cc: Liming Gao <liming.gao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: shenglei <shenglei.zhang@intel.com>
> ---
>  .../Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c    | 25 -------------------
>  .../Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h      | 11 --------
>  2 files changed, 36 deletions(-)
> 
> diff --git
> a/IntelFrameworkModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c
> b/IntelFrameworkModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c
> index 78c4e3b391..202588191e 100644
> --- a/IntelFrameworkModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c
> +++ b/IntelFrameworkModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c
> @@ -1848,32 +1848,7 @@ Done:
> 
>  }
> 
> -/**
> -  Disable the keyboard interface of the 8042 controller.
> -
> -  @param ConsoleIn   The device instance
> -
> -  @return status of issuing disable command
> -
> -**/
> -EFI_STATUS
> -DisableKeyboard (
> -  IN KEYBOARD_CONSOLE_IN_DEV *ConsoleIn
> -  )
> -{
> -  EFI_STATUS  Status;
> 
> -  //
> -  // Disable keyboard interface
> -  //
> -  Status = KeyboardCommand (ConsoleIn,
> KEYBOARD_8042_COMMAND_DISABLE_KEYBOARD_INTERFACE);
> -  if (EFI_ERROR (Status)) {
> -    KeyboardError (ConsoleIn, L"\n\r");
> -    return EFI_DEVICE_ERROR;
> -  }
> -
> -  return Status;
> -}
> 
>  /**
>    Check whether there is Ps/2 Keyboard device in system by 0xF4 Keyboard
> Command diff --git
> a/IntelFrameworkModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h
> b/IntelFrameworkModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h
> index 613f176401..220d17419c 100644
> --- a/IntelFrameworkModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h
> +++ b/IntelFrameworkModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h
> @@ -299,18 +299,7 @@ InitKeyboard (
>    IN BOOLEAN                     ExtendedVerification
>    );
> 
> -/**
> -  Disable the keyboard interface of the 8042 controller.
> -
> -  @param ConsoleIn   - the device instance
> 
> -  @return status of issuing disable command
> -
> -**/
> -EFI_STATUS
> -DisableKeyboard (
> -  IN KEYBOARD_CONSOLE_IN_DEV *ConsoleIn
> -  );
> 
>  /**
>    Timer event handler: read a series of scancodes from 8042
> --
> 2.18.0.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel