From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.31; helo=mga06.intel.com; envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8FA5C210DF749 for ; Tue, 7 Aug 2018 22:06:09 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Aug 2018 22:06:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,456,1526367600"; d="scan'208";a="79476993" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga001.fm.intel.com with ESMTP; 07 Aug 2018 22:06:03 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 7 Aug 2018 22:06:02 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 7 Aug 2018 22:06:02 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.143]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.205]) with mapi id 14.03.0319.002; Wed, 8 Aug 2018 13:06:00 +0800 From: "Ni, Ruiyu" To: "Zhang, Shenglei" , "edk2-devel@lists.01.org" CC: "Gao, Liming" Thread-Topic: [edk2] [PATCH 2/6] IntelFrameworkModulePkg Ps2KeyboardDxe: Remove a redundant function Thread-Index: AQHULsVYUGGrQD+5y0CDRnNnz16Sr6S1TUkg Date: Wed, 8 Aug 2018 05:05:24 +0000 Deferred-Delivery: Wed, 8 Aug 2018 05:06:00 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5BDC41AB@SHSMSX104.ccr.corp.intel.com> References: <20180808030854.30124-1-shenglei.zhang@intel.com> <20180808030854.30124-3-shenglei.zhang@intel.com> In-Reply-To: <20180808030854.30124-3-shenglei.zhang@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 2/6] IntelFrameworkModulePkg Ps2KeyboardDxe: Remove a redundant function X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Aug 2018 05:06:09 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ruiyu Ni Thanks/Ray > -----Original Message----- > From: edk2-devel On Behalf Of shenglei > Sent: Wednesday, August 8, 2018 11:09 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [edk2] [PATCH 2/6] IntelFrameworkModulePkg Ps2KeyboardDxe: > Remove a redundant function >=20 > The redundant function DisableKeyboard which is never called has been > removed. > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1063 >=20 > Cc: Liming Gao > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: shenglei > --- > .../Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c | 25 ------------------- > .../Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h | 11 -------- > 2 files changed, 36 deletions(-) >=20 > diff --git > a/IntelFrameworkModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c > b/IntelFrameworkModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c > index 78c4e3b391..202588191e 100644 > --- a/IntelFrameworkModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c > +++ b/IntelFrameworkModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c > @@ -1848,32 +1848,7 @@ Done: >=20 > } >=20 > -/** > - Disable the keyboard interface of the 8042 controller. > - > - @param ConsoleIn The device instance > - > - @return status of issuing disable command > - > -**/ > -EFI_STATUS > -DisableKeyboard ( > - IN KEYBOARD_CONSOLE_IN_DEV *ConsoleIn > - ) > -{ > - EFI_STATUS Status; >=20 > - // > - // Disable keyboard interface > - // > - Status =3D KeyboardCommand (ConsoleIn, > KEYBOARD_8042_COMMAND_DISABLE_KEYBOARD_INTERFACE); > - if (EFI_ERROR (Status)) { > - KeyboardError (ConsoleIn, L"\n\r"); > - return EFI_DEVICE_ERROR; > - } > - > - return Status; > -} >=20 > /** > Check whether there is Ps/2 Keyboard device in system by 0xF4 Keyboard > Command diff --git > a/IntelFrameworkModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h > b/IntelFrameworkModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h > index 613f176401..220d17419c 100644 > --- a/IntelFrameworkModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h > +++ b/IntelFrameworkModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h > @@ -299,18 +299,7 @@ InitKeyboard ( > IN BOOLEAN ExtendedVerification > ); >=20 > -/** > - Disable the keyboard interface of the 8042 controller. > - > - @param ConsoleIn - the device instance >=20 > - @return status of issuing disable command > - > -**/ > -EFI_STATUS > -DisableKeyboard ( > - IN KEYBOARD_CONSOLE_IN_DEV *ConsoleIn > - ); >=20 > /** > Timer event handler: read a series of scancodes from 8042 > -- > 2.18.0.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel