From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.20; helo=mga02.intel.com; envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 586E821959CB2 for ; Wed, 8 Aug 2018 20:10:04 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Aug 2018 20:10:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,213,1531810800"; d="scan'208";a="63475801" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga007.jf.intel.com with ESMTP; 08 Aug 2018 20:10:03 -0700 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 8 Aug 2018 20:10:03 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 8 Aug 2018 20:10:02 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.143]) by shsmsx102.ccr.corp.intel.com ([169.254.2.226]) with mapi id 14.03.0319.002; Thu, 9 Aug 2018 11:10:00 +0800 From: "Ni, Ruiyu" To: "Zhang, Shenglei" , "edk2-devel@lists.01.org" CC: "Dong, Eric" , "Zeng, Star" Thread-Topic: [edk2] [PATCH 06/26] MdeModulePkg PciBusDxe: Remove redundant functions Thread-Index: AQHULvR/bdzcUdGfWEuXqMXuSyf3r6S2vuIQ Date: Thu, 9 Aug 2018 03:09:29 +0000 Deferred-Delivery: Thu, 9 Aug 2018 03:10:00 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5BDC9573@SHSMSX104.ccr.corp.intel.com> References: <20180808084712.34696-1-shenglei.zhang@intel.com> <20180808084712.34696-7-shenglei.zhang@intel.com> In-Reply-To: <20180808084712.34696-7-shenglei.zhang@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 06/26] MdeModulePkg PciBusDxe: Remove redundant functions X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Aug 2018 03:10:04 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ruiyu Ni Thanks/Ray > -----Original Message----- > From: edk2-devel On Behalf Of shenglei > Sent: Wednesday, August 8, 2018 4:47 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric ; Zeng, Star > Subject: [edk2] [PATCH 06/26] MdeModulePkg PciBusDxe: Remove > redundant functions >=20 > The functions that are never called have been removed. > They are UpStreamBridgesAttributes and GetHpcPciAddressFromRootBridge. > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1062 >=20 > Cc: Star Zeng > Cc: Eric Dong > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: shenglei > --- > .../Bus/Pci/PciBusDxe/PciDeviceSupport.c | 80 ------------------- > .../Bus/Pci/PciBusDxe/PciDeviceSupport.h | 17 ---- > MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c | 41 ---------- > MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.h | 21 ----- > 4 files changed, 159 deletions(-) >=20 > diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciDeviceSupport.c > b/MdeModulePkg/Bus/Pci/PciBusDxe/PciDeviceSupport.c > index 48cf57a24f..f7039da992 100644 > --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciDeviceSupport.c > +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciDeviceSupport.c > @@ -1061,85 +1061,5 @@ ActiveVGADeviceOnTheRootBridge ( } >=20 >=20 > -/** > - Get HPC PCI address according to its device path. > - > - @param RootBridge Root bridege Io instance. > - @param RemainingDevicePath Given searching device path. > - @param PciAddress Buffer holding searched result. > - > - @retval EFI_SUCCESS PCI address was stored in PciAddress > - @retval EFI_NOT_FOUND Can not find the specific device path. > - > -**/ > -EFI_STATUS > -GetHpcPciAddressFromRootBridge ( > - IN PCI_IO_DEVICE *RootBridge, > - IN EFI_DEVICE_PATH_PROTOCOL *RemainingDevicePath, > - OUT UINT64 *PciAddress > - ) > -{ > - EFI_DEV_PATH_PTR Node; > - PCI_IO_DEVICE *Temp; > - EFI_DEVICE_PATH_PROTOCOL *CurrentDevicePath; > - LIST_ENTRY *CurrentLink; > - BOOLEAN MisMatch; > - > - MisMatch =3D FALSE; > - > - CurrentDevicePath =3D RemainingDevicePath; > - Node.DevPath =3D CurrentDevicePath; > - Temp =3D NULL; > - > - while (!IsDevicePathEnd (CurrentDevicePath)) { > - > - CurrentLink =3D RootBridge->ChildList.ForwardLink; > - Node.DevPath =3D CurrentDevicePath; > - > - while (CurrentLink !=3D NULL && CurrentLink !=3D &RootBridge->ChildL= ist) { > - Temp =3D PCI_IO_DEVICE_FROM_LINK (CurrentLink); > - > - if (Node.Pci->Device =3D=3D Temp->DeviceNumber && > - Node.Pci->Function =3D=3D Temp->FunctionNumber) { > - RootBridge =3D Temp; > - break; > - } > - > - CurrentLink =3D CurrentLink->ForwardLink; > - } > - > - // > - // Check if we find the bridge > - // > - if (CurrentLink =3D=3D &RootBridge->ChildList) { > - > - MisMatch =3D TRUE; > - break; > - > - } > - > - CurrentDevicePath =3D NextDevicePathNode (CurrentDevicePath); > - } > - > - if (MisMatch) { > - > - CurrentDevicePath =3D NextDevicePathNode (CurrentDevicePath); > - > - if (IsDevicePathEnd (CurrentDevicePath)) { > - *PciAddress =3D EFI_PCI_ADDRESS (RootBridge->BusNumber, Node.Pci- > >Device, Node.Pci->Function, 0); > - return EFI_SUCCESS; > - } > - > - return EFI_NOT_FOUND; > - } >=20 > - if (Temp !=3D NULL) { > - *PciAddress =3D EFI_PCI_ADDRESS (Temp->BusNumber, Temp- > >DeviceNumber, Temp->FunctionNumber, 0); > - } else { > - return EFI_NOT_FOUND; > - } > - > - return EFI_SUCCESS; > - > -} >=20 > diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciDeviceSupport.h > b/MdeModulePkg/Bus/Pci/PciBusDxe/PciDeviceSupport.h > index 1a01e72b1e..c282381f85 100644 > --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciDeviceSupport.h > +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciDeviceSupport.h > @@ -255,23 +255,6 @@ ActiveVGADeviceOnTheRootBridge ( > IN PCI_IO_DEVICE *RootBridge > ); >=20 > -/** > - Get HPC PCI address according to its device path. > - > - @param RootBridge Root bridege Io instance. > - @param RemainingDevicePath Given searching device path. > - @param PciAddress Buffer holding searched result. > - > - @retval EFI_SUCCESS PCI address was stored in PciAddress. > - @retval EFI_NOT_FOUND Can not find the specific device path. > - > -**/ > -EFI_STATUS > -GetHpcPciAddressFromRootBridge ( > - IN PCI_IO_DEVICE *RootBridge, > - IN EFI_DEVICE_PATH_PROTOCOL *RemainingDevicePath, > - OUT UINT64 *PciAddress > - ); >=20 > /** > Destroy a pci device node. > diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c > b/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c > index 87b0b9884a..291578c63c 100644 > --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c > +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c > @@ -2061,47 +2061,6 @@ PciIoSetBarAttributes ( > return EFI_SUCCESS; > } >=20 > -/** > - Program parent bridge's attribute recurrently. > - > - @param PciIoDevice Child Pci device instance > - @param Operation The operation to perform on the attributes for thi= s > PCI controller. > - @param Attributes The mask of attributes that are used for Set, Enab= le, > and Disable > - operations. > - > - @retval EFI_SUCCESS The operation on the PCI controller's at= tributes > was completed. > - @retval EFI_INVALID_PARAMETER One or more parameters are invalid. > - @retval EFI_UNSUPPORTED one or more of the bits set in > - Attributes are not supported by this PCI= controller or one of > - its parent bridges when Operation is Set= , Enable or Disable. > - > -**/ > -EFI_STATUS > -UpStreamBridgesAttributes ( > - IN PCI_IO_DEVICE *PciIoDevice, > - IN EFI_PCI_IO_PROTOCOL_ATTRIBUTE_OPERATION Operation, > - IN UINT64 Attributes > - ) > -{ > - PCI_IO_DEVICE *Parent; > - EFI_PCI_IO_PROTOCOL *PciIo; > - > - Parent =3D PciIoDevice->Parent; > - > - while (Parent !=3D NULL && IS_PCI_BRIDGE (&Parent->Pci)) { > - > - // > - // Get the PciIo Protocol > - // > - PciIo =3D &Parent->PciIo; > - > - PciIo->Attributes (PciIo, Operation, Attributes, NULL); > - > - Parent =3D Parent->Parent; > - } > - > - return EFI_SUCCESS; > -} >=20 > /** > Test whether two Pci devices has same parent bridge. > diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.h > b/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.h > index b7e38ded3f..69e7c32881 100644 > --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.h > +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.h > @@ -646,27 +646,6 @@ PciIoSetBarAttributes ( > IN OUT UINT64 *Length > ); >=20 > -/** > - Program parent bridge's attribute recurrently. > - > - @param PciIoDevice Child Pci device instance > - @param Operation The operation to perform on the attributes for thi= s > PCI controller. > - @param Attributes The mask of attributes that are used for Set, Enab= le, > and Disable > - operations. > - > - @retval EFI_SUCCESS The operation on the PCI controller's at= tributes > was completed. > - @retval EFI_INVALID_PARAMETER One or more parameters are invalid. > - @retval EFI_UNSUPPORTED one or more of the bits set in > - Attributes are not supported by this PCI= controller or one of > - its parent bridges when Operation is Set= , Enable or Disable. > - > -**/ > -EFI_STATUS > -UpStreamBridgesAttributes ( > - IN PCI_IO_DEVICE *PciIoDevice, > - IN EFI_PCI_IO_PROTOCOL_ATTRIBUTE_OPERATION Operation, > - IN UINT64 Attributes > - ); >=20 > /** > Test whether two Pci devices has same parent bridge. > -- > 2.18.0.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel