From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.24; helo=mga09.intel.com; envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7AB43210E2DDD for ; Wed, 8 Aug 2018 20:13:05 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Aug 2018 20:13:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,213,1531810800"; d="scan'208";a="78761103" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga004.fm.intel.com with ESMTP; 08 Aug 2018 20:13:04 -0700 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 8 Aug 2018 20:13:04 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 8 Aug 2018 20:13:04 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.143]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.240]) with mapi id 14.03.0319.002; Thu, 9 Aug 2018 11:13:00 +0800 From: "Ni, Ruiyu" To: "Zhang, Shenglei" , "edk2-devel@lists.01.org" CC: "Dong, Eric" , "Zeng, Star" Thread-Topic: [edk2] [PATCH 10/26] MdeModulePkg XhciPei: Remove redundant functions Thread-Index: AQHULvSccVZTeL731kSigZRq87gNIKS2v6JA Date: Thu, 9 Aug 2018 03:12:45 +0000 Deferred-Delivery: Thu, 9 Aug 2018 03:13:00 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5BDC95E5@SHSMSX104.ccr.corp.intel.com> References: <20180808084712.34696-1-shenglei.zhang@intel.com> <20180808084712.34696-11-shenglei.zhang@intel.com> In-Reply-To: <20180808084712.34696-11-shenglei.zhang@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 10/26] MdeModulePkg XhciPei: Remove redundant functions X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Aug 2018 03:13:05 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ruiyu Ni Thanks/Ray > -----Original Message----- > From: edk2-devel On Behalf Of shenglei > Sent: Wednesday, August 8, 2018 4:47 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric ; Zeng, Star > Subject: [edk2] [PATCH 10/26] MdeModulePkg XhciPei: Remove redundant > functions >=20 > The functions that are never called have been removed. > They are XhcPeiReadDoorBellReg and UsbHcUnlinkMemBlock. > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1062 >=20 > Cc: Star Zeng > Cc: Eric Dong > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: shenglei > --- > MdeModulePkg/Bus/Pci/XhciPei/UsbHcMem.c | 24 ------------------------ > MdeModulePkg/Bus/Pci/XhciPei/XhcPeim.c | 22 ---------------------- > MdeModulePkg/Bus/Pci/XhciPei/XhciReg.h | 14 -------------- > 3 files changed, 60 deletions(-) >=20 > diff --git a/MdeModulePkg/Bus/Pci/XhciPei/UsbHcMem.c > b/MdeModulePkg/Bus/Pci/XhciPei/UsbHcMem.c > index 5d0232ca56..442a613095 100644 > --- a/MdeModulePkg/Bus/Pci/XhciPei/UsbHcMem.c > +++ b/MdeModulePkg/Bus/Pci/XhciPei/UsbHcMem.c > @@ -328,31 +328,7 @@ UsbHcIsMemBlockEmpty ( > return TRUE; > } >=20 > -/** > - Unlink the memory block from the pool's list. > - > - @param Head The block list head of the memory's pool. > - @param BlockToUnlink The memory block to unlink. >=20 > -**/ > -VOID > -UsbHcUnlinkMemBlock ( > - IN USBHC_MEM_BLOCK *Head, > - IN USBHC_MEM_BLOCK *BlockToUnlink > - ) > -{ > - USBHC_MEM_BLOCK *Block; > - > - ASSERT ((Head !=3D NULL) && (BlockToUnlink !=3D NULL)); > - > - for (Block =3D Head; Block !=3D NULL; Block =3D Block->Next) { > - if (Block->Next =3D=3D BlockToUnlink) { > - Block->Next =3D BlockToUnlink->Next; > - BlockToUnlink->Next =3D NULL; > - break; > - } > - } > -} >=20 > /** > Initialize the memory management pool for the host controller. > diff --git a/MdeModulePkg/Bus/Pci/XhciPei/XhcPeim.c > b/MdeModulePkg/Bus/Pci/XhciPei/XhcPeim.c > index c5631e87ca..ee4d1f97bd 100644 > --- a/MdeModulePkg/Bus/Pci/XhciPei/XhcPeim.c > +++ b/MdeModulePkg/Bus/Pci/XhciPei/XhcPeim.c > @@ -211,29 +211,7 @@ XhcPeiReadCapRegister ( > return Data; > } >=20 > -/** > - Read XHCI door bell register. > - > - @param Xhc The XHCI device. > - @param Offset The offset of the door bell register. > - > - @return The register content read >=20 > -**/ > -UINT32 > -XhcPeiReadDoorBellReg ( > - IN PEI_XHC_DEV *Xhc, > - IN UINT32 Offset > - ) > -{ > - UINT32 Data; > - > - ASSERT (Xhc->DBOff !=3D 0); > - > - Data =3D MmioRead32 (Xhc->UsbHostControllerBaseAddress + Xhc->DBOff + > Offset); > - > - return Data; > -} >=20 > /** > Write the data to the XHCI door bell register. > diff --git a/MdeModulePkg/Bus/Pci/XhciPei/XhciReg.h > b/MdeModulePkg/Bus/Pci/XhciPei/XhciReg.h > index 0297072ffd..3787aeccf5 100644 > --- a/MdeModulePkg/Bus/Pci/XhciPei/XhciReg.h > +++ b/MdeModulePkg/Bus/Pci/XhciPei/XhciReg.h > @@ -302,20 +302,6 @@ XhcPeiWaitOpRegBit ( > IN UINT32 Timeout > ); >=20 > -/** > - Read XHCI door bell register. > - > - @param Xhc The XHCI device. > - @param Offset The offset of the door bell register. > - > - @return The register content read > - > -**/ > -UINT32 > -XhcPeiReadDoorBellReg ( > - IN PEI_XHC_DEV *Xhc, > - IN UINT32 Offset > - ); >=20 > /** > Write the data to the XHCI door bell register. > -- > 2.18.0.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel