From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.24; helo=mga09.intel.com; envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 743A2210E2DCA for ; Wed, 8 Aug 2018 20:13:04 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Aug 2018 20:13:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,213,1531810800"; d="scan'208";a="78761097" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga004.fm.intel.com with ESMTP; 08 Aug 2018 20:13:03 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 8 Aug 2018 20:13:02 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 8 Aug 2018 20:13:02 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.143]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.150]) with mapi id 14.03.0319.002; Thu, 9 Aug 2018 11:13:00 +0800 From: "Ni, Ruiyu" To: "Zhang, Shenglei" , "edk2-devel@lists.01.org" CC: "Dong, Eric" , "Zeng, Star" Thread-Topic: [edk2] [PATCH 15/26] MdeModulePkg UsbBusPei: Remove redundant functions Thread-Index: AQHULvSi/x9QdFD9okWnMeovaOZgBqS2v9Dw Date: Thu, 9 Aug 2018 03:12:45 +0000 Deferred-Delivery: Thu, 9 Aug 2018 03:13:00 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5BDC95EA@SHSMSX104.ccr.corp.intel.com> References: <20180808084712.34696-1-shenglei.zhang@intel.com> <20180808084712.34696-16-shenglei.zhang@intel.com> In-Reply-To: <20180808084712.34696-16-shenglei.zhang@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 15/26] MdeModulePkg UsbBusPei: Remove redundant functions X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Aug 2018 03:13:04 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ruiyu Ni Thanks/Ray > -----Original Message----- > From: edk2-devel On Behalf Of shenglei > Sent: Wednesday, August 8, 2018 4:47 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric ; Zeng, Star > Subject: [edk2] [PATCH 15/26] MdeModulePkg UsbBusPei: Remove > redundant functions >=20 > The functions that are never called have been removed. > They are PeiHubSetHubFeature,IsPortConnectChange and > PeiUsbClearDeviceFeature. > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1062 >=20 > Cc: Star Zeng > Cc: Eric Dong > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: shenglei > --- > MdeModulePkg/Bus/Usb/UsbBusPei/HubPeim.c | 39 ----------- > MdeModulePkg/Bus/Usb/UsbBusPei/HubPeim.h | 18 ----- > MdeModulePkg/Bus/Usb/UsbBusPei/PeiUsbLib.c | 77 ---------------------- > MdeModulePkg/Bus/Usb/UsbBusPei/PeiUsbLib.h | 35 ---------- > 4 files changed, 169 deletions(-) >=20 > diff --git a/MdeModulePkg/Bus/Usb/UsbBusPei/HubPeim.c > b/MdeModulePkg/Bus/Usb/UsbBusPei/HubPeim.c > index 806602511c..5607c65b13 100644 > --- a/MdeModulePkg/Bus/Usb/UsbBusPei/HubPeim.c > +++ b/MdeModulePkg/Bus/Usb/UsbBusPei/HubPeim.c > @@ -193,46 +193,7 @@ PeiHubGetHubStatus ( > ); > } >=20 > -/** > - Set specified feature to a given hub. > - > - @param PeiServices General-purpose services that are available to e= very > PEIM. > - @param UsbIoPpi Indicates the PEI_USB_IO_PPI instance. > - @param Value New feature value. > - > - @retval EFI_SUCCESS Port feature is set successfully. > - @retval EFI_DEVICE_ERROR Cannot set the port feature due to a hardwar= e > error. > - @retval Others Other failure occurs. > - > -**/ > -EFI_STATUS > -PeiHubSetHubFeature ( > - IN EFI_PEI_SERVICES **PeiServices, > - IN PEI_USB_IO_PPI *UsbIoPpi, > - IN UINT8 Value > - ) > -{ > - EFI_USB_DEVICE_REQUEST DeviceRequest; >=20 > - ZeroMem (&DeviceRequest, sizeof (EFI_USB_DEVICE_REQUEST)); > - > - // > - // Fill Device request packet > - // > - DeviceRequest.RequestType =3D USB_HUB_SET_HUB_FEATURE_REQ_TYPE; > - DeviceRequest.Request =3D USB_HUB_SET_HUB_FEATURE; > - DeviceRequest.Value =3D Value; > - > - return UsbIoPpi->UsbControlTransfer ( > - PeiServices, > - UsbIoPpi, > - &DeviceRequest, > - EfiUsbNoData, > - PcdGet32 (PcdUsbTransferTimeoutValue), > - NULL, > - 0 > - ); > -} >=20 > /** > Clear specified feature on a given hub. > diff --git a/MdeModulePkg/Bus/Usb/UsbBusPei/HubPeim.h > b/MdeModulePkg/Bus/Usb/UsbBusPei/HubPeim.h > index 385a14ec0d..d21057c349 100644 > --- a/MdeModulePkg/Bus/Usb/UsbBusPei/HubPeim.h > +++ b/MdeModulePkg/Bus/Usb/UsbBusPei/HubPeim.h > @@ -145,24 +145,6 @@ PeiHubSetPortFeature ( > IN UINT8 Value > ); >=20 > -/** > - Set specified feature to a given hub. > - > - @param PeiServices General-purpose services that are available to e= very > PEIM. > - @param UsbIoPpi Indicates the PEI_USB_IO_PPI instance. > - @param Value New feature value. > - > - @retval EFI_SUCCESS Port feature is set successfully. > - @retval EFI_DEVICE_ERROR Cannot set the port feature due to a hardwar= e > error. > - @retval Others Other failure occurs. > - > -**/ > -EFI_STATUS > -PeiHubSetHubFeature ( > - IN EFI_PEI_SERVICES **PeiServices, > - IN PEI_USB_IO_PPI *UsbIoPpi, > - IN UINT8 Value > - ); >=20 > /** > Get a given hub status. > diff --git a/MdeModulePkg/Bus/Usb/UsbBusPei/PeiUsbLib.c > b/MdeModulePkg/Bus/Usb/UsbBusPei/PeiUsbLib.c > index c5e599e2f7..73a163e7a0 100644 > --- a/MdeModulePkg/Bus/Usb/UsbBusPei/PeiUsbLib.c > +++ b/MdeModulePkg/Bus/Usb/UsbBusPei/PeiUsbLib.c > @@ -104,62 +104,7 @@ PeiUsbSetDeviceAddress ( > ); > } >=20 > -/** > - Clear a given usb feature. > - > - @param PeiServices General-purpose services that are available = to > every PEIM. > - @param UsbIoPpi Indicates the PEI_USB_IO_PPI instance. > - @param Recipient The recipient of ClearFeature Request, shoul= d be > one of Device/Interface/Endpoint. > - @param Value Request Value. > - @param Target Request Index. > - > - @retval EFI_SUCCESS Usb feature is cleared successfully. > - @retval EFI_DEVICE_ERROR Cannot clear the usb feature due to a > hardware error. > - @retval Others Other failure occurs. >=20 > -**/ > -EFI_STATUS > -PeiUsbClearDeviceFeature ( > - IN EFI_PEI_SERVICES **PeiServices, > - IN PEI_USB_IO_PPI *UsbIoPpi, > - IN EFI_USB_RECIPIENT Recipient, > - IN UINT16 Value, > - IN UINT16 Target > - ) > -{ > - EFI_USB_DEVICE_REQUEST DevReq; > - > - ASSERT (UsbIoPpi !=3D NULL); > - > - switch (Recipient) { > - case EfiUsbDevice: > - DevReq.RequestType =3D USB_DEV_CLEAR_FEATURE_REQ_TYPE_D; > - break; > - > - case EfiUsbInterface: > - DevReq.RequestType =3D USB_DEV_CLEAR_FEATURE_REQ_TYPE_I; > - break; > - > - case EfiUsbEndpoint: > - DevReq.RequestType =3D USB_DEV_CLEAR_FEATURE_REQ_TYPE_E; > - break; > - } > - > - DevReq.Request =3D USB_DEV_CLEAR_FEATURE; > - DevReq.Value =3D Value; > - DevReq.Index =3D Target; > - DevReq.Length =3D 0; > - > - return UsbIoPpi->UsbControlTransfer ( > - PeiServices, > - UsbIoPpi, > - &DevReq, > - EfiUsbNoData, > - PcdGet32 (PcdUsbTransferTimeoutValue), > - NULL, > - 0 > - ); > -} >=20 > /** > Configure a usb device to Configuration 1. > @@ -244,26 +189,4 @@ PeiUsbGetDeviceSpeed ( > } > } >=20 > -/** > - Judge if the port is in "connection change" status or not. > - > - @param PortChangeStatus The usb port change status gotten. > - > - @retval TRUE The port is in "connection change" status. > - @retval FALSE The port is NOT in "connection change" statu= s. >=20 > -**/ > -BOOLEAN > -IsPortConnectChange ( > - IN UINT16 PortChangeStatus > - ) > -{ > - // > - // return the bit 0 value of PortChangeStatus > - // > - if ((PortChangeStatus & USB_PORT_STAT_C_CONNECTION) !=3D 0) { > - return TRUE; > - } else { > - return FALSE; > - } > -} > diff --git a/MdeModulePkg/Bus/Usb/UsbBusPei/PeiUsbLib.h > b/MdeModulePkg/Bus/Usb/UsbBusPei/PeiUsbLib.h > index 35f47a35ec..e3afee6e84 100644 > --- a/MdeModulePkg/Bus/Usb/UsbBusPei/PeiUsbLib.h > +++ b/MdeModulePkg/Bus/Usb/UsbBusPei/PeiUsbLib.h > @@ -148,28 +148,6 @@ PeiUsbSetDeviceAddress ( > IN UINT16 AddressValue > ); >=20 > -/** > - Clear a given usb feature. > - > - @param PeiServices General-purpose services that are available = to > every PEIM. > - @param UsbIoPpi Indicates the PEI_USB_IO_PPI instance. > - @param Recipient The recipient of ClearFeature Request, shoul= d be > one of Device/Interface/Endpoint. > - @param Value Request Value. > - @param Target Request Index. > - > - @retval EFI_SUCCESS Usb feature is cleared successfully. > - @retval EFI_DEVICE_ERROR Cannot clear the usb feature due to a > hardware error. > - @retval Others Other failure occurs. > - > -**/ > -EFI_STATUS > -PeiUsbClearDeviceFeature ( > - IN EFI_PEI_SERVICES **PeiServices, > - IN PEI_USB_IO_PPI *UsbIoPpi, > - IN EFI_USB_RECIPIENT Recipient, > - IN UINT16 Value, > - IN UINT16 Target > - ); >=20 > /** > Configure a usb device to Configuration 1. > @@ -215,17 +193,4 @@ PeiUsbGetDeviceSpeed ( > IN UINT16 PortStatus > ); >=20 > -/** > - Judge if the port is in "connection change" status or not. > - > - @param PortChangeStatus The usb port change status gotten. > - > - @retval TRUE The port is in "connection change" status. > - @retval FALSE The port is NOT in "connection change" statu= s. > - > -**/ > -BOOLEAN > -IsPortConnectChange ( > - IN UINT16 PortChangeStatus > - ); > #endif > -- > 2.18.0.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel