From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.20; helo=mga02.intel.com; envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1E087210E2DDA for ; Wed, 8 Aug 2018 20:13:39 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Aug 2018 20:13:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,213,1531810800"; d="scan'208";a="247339269" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga005.jf.intel.com with ESMTP; 08 Aug 2018 20:13:31 -0700 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 8 Aug 2018 20:13:14 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 8 Aug 2018 20:13:13 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.143]) by shsmsx102.ccr.corp.intel.com ([169.254.2.226]) with mapi id 14.03.0319.002; Thu, 9 Aug 2018 11:13:00 +0800 From: "Ni, Ruiyu" To: "Zhang, Shenglei" , "edk2-devel@lists.01.org" CC: "Dong, Eric" , "Zeng, Star" Thread-Topic: [edk2] [PATCH 18/26] MdeModulePkg Ps2KeyboardDxe: Remove a redundant function Thread-Index: AQHULvSs7gD1xNvMT0qaE+mCykTWs6S2v9bQ Date: Thu, 9 Aug 2018 03:12:45 +0000 Deferred-Delivery: Thu, 9 Aug 2018 03:13:00 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5BDC95EF@SHSMSX104.ccr.corp.intel.com> References: <20180808084712.34696-1-shenglei.zhang@intel.com> <20180808084712.34696-19-shenglei.zhang@intel.com> In-Reply-To: <20180808084712.34696-19-shenglei.zhang@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 18/26] MdeModulePkg Ps2KeyboardDxe: Remove a redundant function X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Aug 2018 03:13:39 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ruiyu Ni Thanks/Ray > -----Original Message----- > From: edk2-devel On Behalf Of shenglei > Sent: Wednesday, August 8, 2018 4:47 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric ; Zeng, Star > Subject: [edk2] [PATCH 18/26] MdeModulePkg Ps2KeyboardDxe: Remove a > redundant function >=20 > The function DisableKeyboard that is never calld has been removed. > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1062 >=20 > Cc: Star Zeng > Cc: Eric Dong > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: shenglei > --- > .../Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c | 26 ------------------- > .../Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h | 12 --------- > 2 files changed, 38 deletions(-) >=20 > diff --git a/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c > b/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c > index 4def6d9271..2ee293d64d 100644 > --- a/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c > +++ b/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c > @@ -1812,32 +1812,6 @@ Done: >=20 > } >=20 > -/** > - Disable the keyboard interface of the 8042 controller. > - > - @param ConsoleIn The device instance > - > - @return status of issuing disable command > - > -**/ > -EFI_STATUS > -DisableKeyboard ( > - IN KEYBOARD_CONSOLE_IN_DEV *ConsoleIn > - ) > -{ > - EFI_STATUS Status; > - > - // > - // Disable keyboard interface > - // > - Status =3D KeyboardCommand (ConsoleIn, > KEYBOARD_8042_COMMAND_DISABLE_KEYBOARD_INTERFACE); > - if (EFI_ERROR (Status)) { > - KeyboardError (ConsoleIn, L"\n\r"); > - return EFI_DEVICE_ERROR; > - } > - > - return Status; > -} >=20 > /** > Check whether there is Ps/2 Keyboard device in system by 0xF4 Keyboard > Command diff --git > a/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h > b/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h > index b6a4f3c6b9..e0950ce113 100644 > --- a/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h > +++ b/MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h > @@ -300,18 +300,6 @@ InitKeyboard ( > IN BOOLEAN ExtendedVerification > ); >=20 > -/** > - Disable the keyboard interface of the 8042 controller. > - > - @param ConsoleIn - the device instance > - > - @return status of issuing disable command > - > -**/ > -EFI_STATUS > -DisableKeyboard ( > - IN KEYBOARD_CONSOLE_IN_DEV *ConsoleIn > - ); >=20 > /** > Timer event handler: read a series of scancodes from 8042 > -- > 2.18.0.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel