From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.31; helo=mga06.intel.com; envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 14242210E2DDA for ; Wed, 8 Aug 2018 20:14:03 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Aug 2018 20:14:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,213,1531810800"; d="scan'208";a="79778453" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga001.fm.intel.com with ESMTP; 08 Aug 2018 20:14:02 -0700 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 8 Aug 2018 20:14:02 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 8 Aug 2018 20:14:02 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.143]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.205]) with mapi id 14.03.0319.002; Thu, 9 Aug 2018 11:14:00 +0800 From: "Ni, Ruiyu" To: "Zhang, Shenglei" , "edk2-devel@lists.01.org" CC: "Dong, Eric" , "Zeng, Star" Thread-Topic: [edk2] [PATCH 21/26] MdeModulePkg TerminalDxe: Remove a redundant function Thread-Index: AQHULvSxX2SKgjkkOUGwlsxB5yraNqS2v/XA Date: Thu, 9 Aug 2018 03:13:52 +0000 Deferred-Delivery: Thu, 9 Aug 2018 03:14:00 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5BDC966E@SHSMSX104.ccr.corp.intel.com> References: <20180808084712.34696-1-shenglei.zhang@intel.com> <20180808084712.34696-22-shenglei.zhang@intel.com> In-Reply-To: <20180808084712.34696-22-shenglei.zhang@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 21/26] MdeModulePkg TerminalDxe: Remove a redundant function X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Aug 2018 03:14:03 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ruiyu Ni Thanks/Ray > -----Original Message----- > From: edk2-devel On Behalf Of shenglei > Sent: Wednesday, August 8, 2018 4:47 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric ; Zeng, Star > Subject: [edk2] [PATCH 21/26] MdeModulePkg TerminalDxe: Remove a > redundant function >=20 > The function UnicodeFiFoGetKeyCount that is never calld has been removed. > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1062 >=20 > Cc: Star Zeng > Cc: Eric Dong > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: shenglei > --- > .../Universal/Console/TerminalDxe/Terminal.h | 12 --------- > .../Console/TerminalDxe/TerminalConIn.c | 25 ------------------- > 2 files changed, 37 deletions(-) >=20 > diff --git a/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.h > b/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.h > index a4543fc8de..84808d55a0 100644 > --- a/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.h > +++ b/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.h > @@ -1131,18 +1131,6 @@ IsUnicodeFiFoFull ( > TERMINAL_DEV *TerminalDevice > ); >=20 > -/** > - Count Unicode FIFO buffer. > - > - @param TerminalDevice Terminal driver private structure > - > - @return The count in bytes of Unicode FIFO. > - > -**/ > -UINT8 > -UnicodeFiFoGetKeyCount ( > - TERMINAL_DEV *TerminalDevice > - ); >=20 > /** > Translate raw data into Unicode (according to different encode), and d= iff -- > git a/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c > b/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c > index 80c4f6b483..33f9b6e585 100644 > --- a/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c > +++ b/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c > @@ -1200,31 +1200,6 @@ IsUnicodeFiFoFull ( > return FALSE; > } >=20 > -/** > - Count Unicode FIFO buffer. > - > - @param TerminalDevice Terminal driver private structure > - > - @return The count in bytes of Unicode FIFO. > - > -**/ > -UINT8 > -UnicodeFiFoGetKeyCount ( > - TERMINAL_DEV *TerminalDevice > - ) > -{ > - UINT8 Tail; > - UINT8 Head; > - > - Tail =3D TerminalDevice->UnicodeFiFo->Tail; > - Head =3D TerminalDevice->UnicodeFiFo->Head; > - > - if (Tail >=3D Head) { > - return (UINT8) (Tail - Head); > - } else { > - return (UINT8) (Tail + FIFO_MAX_NUMBER + 1 - Head); > - } > -} >=20 > /** > Update the Unicode characters from a terminal input device into EFI Ke= ys > FIFO. > -- > 2.18.0.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel