From: "Ni, Ruiyu" <ruiyu.ni@intel.com>
To: "Zhang, Shenglei" <shenglei.zhang@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Carsey, Jaben" <jaben.carsey@intel.com>
Subject: Re: [PATCH 4/5] ShellPkg: Remove unused PCDs
Date: Thu, 16 Aug 2018 06:03:00 +0000 [thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5BDD79C7@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20180816053225.22356-5-shenglei.zhang@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
Thanks/Ray
> -----Original Message-----
> From: Zhang, Shenglei
> Sent: Thursday, August 16, 2018 1:32 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>
> Subject: [PATCH 4/5] ShellPkg: Remove unused PCDs
>
> The PCDs below are unused, so they have been removed from inf.
> gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize
> gEfiShellPkgTokenSpaceGuid.PcdShellMapNameLength
> gEfiMdePkgTokenSpaceGuid.PcdUefiLibMaxPrintBufferSize
> gEfiMdePkgTokenSpaceGuid.PcdUefiLibMaxPrintBufferSize
> gEfiShellPkgTokenSpaceGuid.PcdShellPrintBufferSize
> gEfiShellPkgTokenSpaceGuid.PcdShellFileOperationSize
> gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength
>
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: shenglei <shenglei.zhang@intel.com>
> ---
> ShellPkg/Application/Shell/Shell.inf | 2 --
> ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf | 2 --
> ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.inf |
> 3 ---
> ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf | 1 -
> .../UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf | 2 --
> 5 files changed, 10 deletions(-)
>
> diff --git a/ShellPkg/Application/Shell/Shell.inf
> b/ShellPkg/Application/Shell/Shell.inf
> index d89f85bb76..83049844d6 100644
> --- a/ShellPkg/Application/Shell/Shell.inf
> +++ b/ShellPkg/Application/Shell/Shell.inf
> @@ -102,10 +102,8 @@
> gEfiShellPkgTokenSpaceGuid.PcdShellRequireHiiPlatform ## CONSUMES
> gEfiShellPkgTokenSpaceGuid.PcdShellSupportFrameworkHii ## CONSUMES
> gEfiShellPkgTokenSpaceGuid.PcdShellPageBreakDefault ## CONSUMES
> - gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize ## CONSUMES
> gEfiShellPkgTokenSpaceGuid.PcdShellInsertModeDefault ## CONSUMES
> gEfiShellPkgTokenSpaceGuid.PcdShellScreenLogCount ## CONSUMES
> - gEfiShellPkgTokenSpaceGuid.PcdShellMapNameLength ## CONSUMES
> gEfiShellPkgTokenSpaceGuid.PcdShellPrintBufferSize ## CONSUMES
> gEfiShellPkgTokenSpaceGuid.PcdShellForceConsole ## CONSUMES
> gEfiShellPkgTokenSpaceGuid.PcdShellSupplier ## CONSUMES
> diff --git a/ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf
> b/ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf
> index cedb333b28..c35a3087cf 100644
> --- a/ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf
> +++ b/ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf
> @@ -69,5 +69,3 @@
> gEfiLoadedImageDevicePathProtocolGuid ##
> SOMETIMES_CONSUMES
> gEfiHiiPackageListProtocolGuid ## CONSUMES
>
> -[Pcd]
> - gEfiMdePkgTokenSpaceGuid.PcdUefiLibMaxPrintBufferSize ## CONSUMES
> diff --git
> a/ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.inf
> b/ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.inf
> index 8fd3bbd5df..2d07b32266 100644
> ---
> a/ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.inf
> +++
> b/ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.inf
> @@ -71,8 +71,5 @@
> gEfiHiiPackageListProtocolGuid ## CONSUMES
> gEfiShellDynamicCommandProtocolGuid ## PRODUCES
>
> -[Pcd]
> - gEfiMdePkgTokenSpaceGuid.PcdUefiLibMaxPrintBufferSize ## CONSUMES
> -
> [DEPEX]
> TRUE
> diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> index e5e007bef3..a795fb92de 100644
> --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> @@ -353,5 +353,4 @@
> gEfiAdapterInfoUndiIpv6SupportGuid ## SOMETIMES_CONSUMES
> ## GUID
>
> [Pcd.common]
> - gEfiShellPkgTokenSpaceGuid.PcdShellPrintBufferSize ## CONSUMES
> gEfiShellPkgTokenSpaceGuid.PcdShellIncludeNtGuids ## CONSUMES
> diff --git
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLi
> b.inf
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLi
> b.inf
> index 3ea51ec082..ec1f87ae19 100644
> ---
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLi
> b.inf
> +++
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLi
> b.inf
> @@ -119,8 +119,6 @@
>
> [Pcd]
> gEfiShellPkgTokenSpaceGuid.PcdShellProfileMask ## CONSUMES
> - gEfiShellPkgTokenSpaceGuid.PcdShellFileOperationSize ## CONSUMES
> - gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength ##
> CONSUMES
>
> [Protocols]
> gEfiPciRootBridgeIoProtocolGuid ## SOMETIMES_CONSUMES
> --
> 2.18.0.windows.1
next prev parent reply other threads:[~2018-08-16 6:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-16 5:32 [PATCH 0/5] Removed unused PCDs shenglei
2018-08-16 5:32 ` [PATCH 1/5] MdeModulePkg: Remove " shenglei
2018-08-16 6:30 ` Zeng, Star
2018-08-16 14:55 ` Laszlo Ersek
2018-08-16 5:32 ` [PATCH 2/5] IntelFsp2Pkg: " shenglei
2018-08-16 6:32 ` Chiu, Chasel
2018-08-16 5:32 ` [PATCH 3/5] SecurityPkg: " shenglei
2018-08-16 23:59 ` Zhang, Chao B
2018-08-16 5:32 ` [PATCH 4/5] ShellPkg: " shenglei
2018-08-16 6:03 ` Ni, Ruiyu [this message]
2018-08-16 5:32 ` [PATCH 5/5] UefiCpuPkg: Remove an unused PCD shenglei
2018-08-16 6:26 ` Dong, Eric
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=734D49CCEBEEF84792F5B80ED585239D5BDD79C7@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox