From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.93; helo=mga11.intel.com; envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 44EDA210E128D for ; Wed, 15 Aug 2018 23:03:05 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Aug 2018 23:03:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,246,1531810800"; d="scan'208";a="77222601" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga002.fm.intel.com with ESMTP; 15 Aug 2018 23:03:04 -0700 Received: from fmsmsx126.amr.corp.intel.com (10.18.125.43) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 15 Aug 2018 23:03:04 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX126.amr.corp.intel.com (10.18.125.43) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 15 Aug 2018 23:03:04 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.143]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.205]) with mapi id 14.03.0319.002; Thu, 16 Aug 2018 14:03:00 +0800 From: "Ni, Ruiyu" To: "Zhang, Shenglei" , "edk2-devel@lists.01.org" CC: "Carsey, Jaben" Thread-Topic: [PATCH 4/5] ShellPkg: Remove unused PCDs Thread-Index: AQHUNSKUJAuGauuuMEOxKuNIHvpC/aTB4zrg Date: Thu, 16 Aug 2018 06:03:00 +0000 Deferred-Delivery: Thu, 16 Aug 2018 06:03:00 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5BDD79C7@SHSMSX104.ccr.corp.intel.com> References: <20180816053225.22356-1-shenglei.zhang@intel.com> <20180816053225.22356-5-shenglei.zhang@intel.com> In-Reply-To: <20180816053225.22356-5-shenglei.zhang@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 4/5] ShellPkg: Remove unused PCDs X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Aug 2018 06:03:05 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ruiyu Ni Thanks/Ray > -----Original Message----- > From: Zhang, Shenglei > Sent: Thursday, August 16, 2018 1:32 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Ni, Ruiyu > Subject: [PATCH 4/5] ShellPkg: Remove unused PCDs >=20 > The PCDs below are unused, so they have been removed from inf. > gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize > gEfiShellPkgTokenSpaceGuid.PcdShellMapNameLength > gEfiMdePkgTokenSpaceGuid.PcdUefiLibMaxPrintBufferSize > gEfiMdePkgTokenSpaceGuid.PcdUefiLibMaxPrintBufferSize > gEfiShellPkgTokenSpaceGuid.PcdShellPrintBufferSize > gEfiShellPkgTokenSpaceGuid.PcdShellFileOperationSize > gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength >=20 > Cc: Jaben Carsey > Cc: Ruiyu Ni > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: shenglei > --- > ShellPkg/Application/Shell/Shell.inf | 2 -- > ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf | 2 -- > ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.inf | > 3 --- > ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf | 1 - > .../UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf | 2 -- > 5 files changed, 10 deletions(-) >=20 > diff --git a/ShellPkg/Application/Shell/Shell.inf > b/ShellPkg/Application/Shell/Shell.inf > index d89f85bb76..83049844d6 100644 > --- a/ShellPkg/Application/Shell/Shell.inf > +++ b/ShellPkg/Application/Shell/Shell.inf > @@ -102,10 +102,8 @@ > gEfiShellPkgTokenSpaceGuid.PcdShellRequireHiiPlatform ## CONSUMES > gEfiShellPkgTokenSpaceGuid.PcdShellSupportFrameworkHii ## CONSUMES > gEfiShellPkgTokenSpaceGuid.PcdShellPageBreakDefault ## CONSUMES > - gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize ## CONSUMES > gEfiShellPkgTokenSpaceGuid.PcdShellInsertModeDefault ## CONSUMES > gEfiShellPkgTokenSpaceGuid.PcdShellScreenLogCount ## CONSUMES > - gEfiShellPkgTokenSpaceGuid.PcdShellMapNameLength ## CONSUMES > gEfiShellPkgTokenSpaceGuid.PcdShellPrintBufferSize ## CONSUMES > gEfiShellPkgTokenSpaceGuid.PcdShellForceConsole ## CONSUMES > gEfiShellPkgTokenSpaceGuid.PcdShellSupplier ## CONSUMES > diff --git a/ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf > b/ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf > index cedb333b28..c35a3087cf 100644 > --- a/ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf > +++ b/ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf > @@ -69,5 +69,3 @@ > gEfiLoadedImageDevicePathProtocolGuid ## > SOMETIMES_CONSUMES > gEfiHiiPackageListProtocolGuid ## CONSUMES >=20 > -[Pcd] > - gEfiMdePkgTokenSpaceGuid.PcdUefiLibMaxPrintBufferSize ## CONSUMES > diff --git > a/ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.inf > b/ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.inf > index 8fd3bbd5df..2d07b32266 100644 > --- > a/ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.inf > +++ > b/ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.inf > @@ -71,8 +71,5 @@ > gEfiHiiPackageListProtocolGuid ## CONSUMES > gEfiShellDynamicCommandProtocolGuid ## PRODUCES >=20 > -[Pcd] > - gEfiMdePkgTokenSpaceGuid.PcdUefiLibMaxPrintBufferSize ## CONSUMES > - > [DEPEX] > TRUE > diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.i= nf > b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf > index e5e007bef3..a795fb92de 100644 > --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf > +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf > @@ -353,5 +353,4 @@ > gEfiAdapterInfoUndiIpv6SupportGuid ## SOMETIMES_C= ONSUMES > ## GUID >=20 > [Pcd.common] > - gEfiShellPkgTokenSpaceGuid.PcdShellPrintBufferSize ## CONSUMES > gEfiShellPkgTokenSpaceGuid.PcdShellIncludeNtGuids ## CONSUMES > diff --git > a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLi > b.inf > b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLi > b.inf > index 3ea51ec082..ec1f87ae19 100644 > --- > a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLi > b.inf > +++ > b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLi > b.inf > @@ -119,8 +119,6 @@ >=20 > [Pcd] > gEfiShellPkgTokenSpaceGuid.PcdShellProfileMask ## CONSUME= S > - gEfiShellPkgTokenSpaceGuid.PcdShellFileOperationSize ## CONSUME= S > - gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength ## > CONSUMES >=20 > [Protocols] > gEfiPciRootBridgeIoProtocolGuid ## SOMETIMES_CONSUMES > -- > 2.18.0.windows.1