Re: [PATCH 00/10] Quality improvement for EmulatorPkg Win Host

From: "Ni, Ruiyu" <ruiyu.ni@intel.com>
To: "Wu, Hao A" <hao.a.wu@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH 00/10] Quality improvement for EmulatorPkg Win Host
Date: Wed, 29 Aug 2018 03:41:43 +0000	[thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5BDEA42F@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <B80AF82E9BFB8E4FBD8C89DA810C6A0931E3CDC4@SHSMSX104.ccr.corp.intel.com>

Hao,
Thanks for the comments.
I just sent out a patch with title "[edk2] [PATCH] EmulatorPkg: formalize line endings".
My patch sets will be re-generated after the line ending formalization patch is commit. 

Thanks/Ray

> -----Original Message-----
> From: Wu, Hao A
> Sent: Wednesday, August 29, 2018 9:58 AM
> To: Ni, Ruiyu <ruiyu.ni@intel.com>; edk2-devel@lists.01.org
> Subject: RE: [edk2] [PATCH 00/10] Quality improvement for EmulatorPkg Win
> Host
> 
> Hi Ray,
> 
> One general-level comment, I saw some file was originally with Unix line
> ending format (LF), but after the series, the line ending is in a mixed state
> (both containing Unix LF & Windows CRLF). Can you help to perform the line
> ending format cleanup for those files?
> 
> Also, please help to run the PatchCheck tool to verify the format of the
> commits. Thanks in advance.
> 
> Best Regards,
> Hao Wu
> 
> 
> > -----Original Message-----
> > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> > Ruiyu Ni
> > Sent: Monday, August 27, 2018 3:53 PM
> > To: edk2-devel@lists.01.org
> > Subject: [edk2] [PATCH 00/10] Quality improvement for EmulatorPkg Win
> > Host
> >
> > The patch sets make Win Host boot in 64 bit, fix all SCT issues
> > regarding to console input/output, switch to use MdeModulePkg/Bds.
> >
> > Ruiyu Ni (10):
> >   EmulatorPkg/EmuGopDxe: Fix TxtInEx.SetState SCT conformance failure
> >   EmulatorPkg/EmuGopDxe: Clear screen to black in GOP.SetMode
> >   EmulatorPkg/Win: Use FrameBufferBltLib for BLT operation
> >   EmulatorPkg/Win: ReadKeyStrokeEx() always returns correct KeyState
> >   EmulatorPkg/Win: Do not zero out file content
> >   EmulatorPkg/Win: Enable 64bit (SEC,PEI,DXE all run at 64bit)
> >   EmulatorPkg/AutoScanPei: Report the correct CPU address size
> >   EmulatorPkg/Win: Add VS2017 project file
> >   EmulatorPkg: Use MdeModulePkg/Bds module
> >   EmulatorPkg: IoThunk->Close() is called too early, may causing hang
> >
> >  EmulatorPkg/AutoScanPei/AutoScanPei.c              |  17 +-
> >  EmulatorPkg/EmuBlockIoDxe/EmuBlockIo.c             |  14 +-
> >  EmulatorPkg/EmuGopDxe/GopInput.c                   |  11 +-
> >  EmulatorPkg/EmuGopDxe/GopScreen.c                  |   8 +-
> >  .../EmuSimpleFileSystemDxe/EmuSimpleFileSystem.c   |  10 +-
> >  EmulatorPkg/EmuSnpDxe/EmuSnpDxe.c                  |  32 +-
> >  EmulatorPkg/EmulatorPkg.dsc                        |  38 +-
> >  EmulatorPkg/EmulatorPkg.fdf                        |  21 +-
> >  EmulatorPkg/Library/EmuBdsLib/BdsPlatform.c        | 559 ---------------------
> >  EmulatorPkg/Library/PlatformBmLib/PlatformBm.c     | 435
> > ++++++++++++++++
> >  .../BdsPlatform.h => PlatformBmLib/PlatformBm.h}   |  57 +--
> >  .../PlatformBmData.c}                              |  13 +-
> >  .../PlatformBmLib.inf}                             |  28 +-
> >  .../Library/PlatformBmLib/PlatformBmMemoryTest.c   | 133 +++++
> >  EmulatorPkg/Win/Host/WinBlockIo.c                  |  30 +-
> >  EmulatorPkg/Win/Host/WinGop.h                      |   4 +-
> >  EmulatorPkg/Win/Host/WinGopInput.c                 |  17 +
> >  EmulatorPkg/Win/Host/WinGopScreen.c                | 218 +++-----
> >  EmulatorPkg/Win/Host/WinHost.c                     |   2 +-
> >  EmulatorPkg/Win/Host/WinHost.inf                   |   1 +
> >  EmulatorPkg/Win/VS2017/BuildVS.bat                 |   3 +
> >  EmulatorPkg/Win/VS2017/Win.sln                     |  31 ++
> >  EmulatorPkg/Win/VS2017/Win.vcxproj                 | 120 +++++
> >  EmulatorPkg/Win/VS2017/Win.vcxproj.filters         |  50 ++
> >  EmulatorPkg/Win/VS2017/Win.vcxproj.user            |  13 +
> >  25 files changed, 1046 insertions(+), 819 deletions(-)  delete mode
> > 100644 EmulatorPkg/Library/EmuBdsLib/BdsPlatform.c
> >  create mode 100644 EmulatorPkg/Library/PlatformBmLib/PlatformBm.c
> >  rename EmulatorPkg/Library/{EmuBdsLib/BdsPlatform.h =>
> > PlatformBmLib/PlatformBm.h} (62%)  rename
> > EmulatorPkg/Library/{EmuBdsLib/PlatformData.c =>
> > PlatformBmLib/PlatformBmData.c} (77%)  rename
> > EmulatorPkg/Library/{EmuBdsLib/EmuBdsLib.inf =>
> > PlatformBmLib/PlatformBmLib.inf} (71%)  create mode 100644
> > EmulatorPkg/Library/PlatformBmLib/PlatformBmMemoryTest.c
> >  create mode 100644 EmulatorPkg/Win/VS2017/BuildVS.bat
> >  create mode 100644 EmulatorPkg/Win/VS2017/Win.sln  create mode
> 100644
> > EmulatorPkg/Win/VS2017/Win.vcxproj
> >  create mode 100644 EmulatorPkg/Win/VS2017/Win.vcxproj.filters
> >  create mode 100644 EmulatorPkg/Win/VS2017/Win.vcxproj.user
> >
> > --
> > 2.16.1.windows.1
> >
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel