public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ni, Ruiyu" <ruiyu.ni@intel.com>
To: "Chen, Chen A" <chen.a.chen@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [PATCH 25/37] OptionRomPkg: Removing ipf which is no longer supported from edk2.
Date: Thu, 6 Sep 2018 01:53:20 +0000	[thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5BDF5A25@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20180613034511.7660-1-chen.a.chen@intel.com>

Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>

Thanks/Ray

> -----Original Message-----
> From: Chen, Chen A
> Sent: Wednesday, June 13, 2018 11:45 AM
> To: edk2-devel@lists.01.org
> Cc: Chen, Chen A <chen.a.chen@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>;
> Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: [PATCH 25/37] OptionRomPkg: Removing ipf which is no longer
> supported from edk2.
> 
> Removing rules for Ipf sources file:
> * Remove the source file which path with "ipf" and also listed in
>   [Sources.IPF] section of INF file.
> * Remove the source file which listed in [Components.IPF] section
>   of DSC file and not listed in any other [Components] section.
> * Remove the embedded Ipf code for MDE_CPU_IPF.
> 
> Removing rules for Inf file:
> * Remove IPF from VALID_ARCHITECTURES comments.
> * Remove DXE_SAL_DRIVER from LIBRARY_CLASS in [Defines] section.
> * Remove the INF which only listed in [Components.IPF] section in DSC.
> * Remove statements from [BuildOptions] that provide IPF specific flags.
> * Remove any IPF sepcific sections.
> 
> Removing rules for Dec file:
> * Remove [Includes.IPF] section from Dec.
> 
> Removing rules for Dsc file:
> * Remove IPF from SUPPORTED_ARCHITECTURES in [Defines] section of DSC.
> * Remove any IPF specific sections.
> * Remove statements from [BuildOptions] that provide IPF specific flags.
> 
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Signed-off-by: chenc2 <chen.a.chen@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> ---
>  OptionRomPkg/Application/BltLibSample/BltLibSample.c       | 2 --
>  OptionRomPkg/AtapiPassThruDxe/AtapiPassThruDxe.inf         | 2 +-
>  OptionRomPkg/Bus/Usb/FtdiUsbSerialDxe/FtdiUsbSerialDxe.inf | 2 +-
>  OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772/Ax88772.inf     | 2 +-
>  OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf   | 2 +-
>  OptionRomPkg/CirrusLogic5430Dxe/CirrusLogic5430Dxe.inf     | 2 +-
>  OptionRomPkg/OptionRomPkg.dsc                              | 4 ++--
>  OptionRomPkg/UndiRuntimeDxe/UndiRuntimeDxe.inf             | 2 +-
>  8 files changed, 8 insertions(+), 10 deletions(-)
> 
> diff --git a/OptionRomPkg/Application/BltLibSample/BltLibSample.c
> b/OptionRomPkg/Application/BltLibSample/BltLibSample.c
> index c21eb7a49c..c817819be5 100644
> --- a/OptionRomPkg/Application/BltLibSample/BltLibSample.c
> +++ b/OptionRomPkg/Application/BltLibSample/BltLibSample.c
> @@ -27,8 +27,6 @@ ReadTimestamp (
>  {
>  #if defined (MDE_CPU_IA32) || defined (MDE_CPU_X64)
>    return AsmReadTsc ();
> -#elif defined (MDE_CPU_IPF)
> -  return AsmReadItc ();
>  #else
>  #error ReadTimestamp not supported for this architecture!
>  #endif
> diff --git a/OptionRomPkg/AtapiPassThruDxe/AtapiPassThruDxe.inf
> b/OptionRomPkg/AtapiPassThruDxe/AtapiPassThruDxe.inf
> index 8709f1583d..81effde198 100644
> --- a/OptionRomPkg/AtapiPassThruDxe/AtapiPassThruDxe.inf
> +++ b/OptionRomPkg/AtapiPassThruDxe/AtapiPassThruDxe.inf
> @@ -32,7 +32,7 @@
>  #
>  # The following information is for reference only and not required by the
> build tools.
>  #
> -#  VALID_ARCHITECTURES           = IA32 X64 IPF EBC
> +#  VALID_ARCHITECTURES           = IA32 X64 EBC
>  #
>  #  DRIVER_BINDING                =  gAtapiScsiPassThruDriverBinding
>  #  COMPONENT_NAME                =  gAtapiScsiPassThruComponentName
> diff --git a/OptionRomPkg/Bus/Usb/FtdiUsbSerialDxe/FtdiUsbSerialDxe.inf
> b/OptionRomPkg/Bus/Usb/FtdiUsbSerialDxe/FtdiUsbSerialDxe.inf
> index e0381b1c44..06dca80bb0 100644
> --- a/OptionRomPkg/Bus/Usb/FtdiUsbSerialDxe/FtdiUsbSerialDxe.inf
> +++ b/OptionRomPkg/Bus/Usb/FtdiUsbSerialDxe/FtdiUsbSerialDxe.inf
> @@ -30,7 +30,7 @@
>    UNLOAD_IMAGE                   = FtdiUsbSerialUnload
> 
>  #
> -#  VALID_ARCHITECTURES           = IA32 X64 IPF EBC
> +#  VALID_ARCHITECTURES           = IA32 X64 EBC
>  #
> 
>  [Sources]
> diff --git a/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772/Ax88772.inf
> b/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772/Ax88772.inf
> index 5507cbbf3b..b059ac5b64 100644
> --- a/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772/Ax88772.inf
> +++ b/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772/Ax88772.inf
> @@ -24,7 +24,7 @@
>    ENTRY_POINT                    = EntryPoint
> 
>  #
> -#  VALID_ARCHITECTURES           = IA32 X64 IPF EBC
> +#  VALID_ARCHITECTURES           = IA32 X64 EBC
>  #
> 
>  [Sources.common]
> diff --git a/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf
> b/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf
> index 32a62f620d..874ee681ff 100644
> --- a/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf
> +++ b/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf
> @@ -24,7 +24,7 @@
>    ENTRY_POINT                    = EntryPoint
> 
>  #
> -#  VALID_ARCHITECTURES           = IA32 X64 IPF EBC
> +#  VALID_ARCHITECTURES           = IA32 X64 EBC
>  #
> 
>  [Sources.common]
> diff --git a/OptionRomPkg/CirrusLogic5430Dxe/CirrusLogic5430Dxe.inf
> b/OptionRomPkg/CirrusLogic5430Dxe/CirrusLogic5430Dxe.inf
> index fd380d1e81..955360fd2a 100644
> --- a/OptionRomPkg/CirrusLogic5430Dxe/CirrusLogic5430Dxe.inf
> +++ b/OptionRomPkg/CirrusLogic5430Dxe/CirrusLogic5430Dxe.inf
> @@ -39,7 +39,7 @@
>  #
>  # The following information is for reference only and not required by the
> build tools.
>  #
> -#  VALID_ARCHITECTURES           = IA32 X64 IPF EBC
> +#  VALID_ARCHITECTURES           = IA32 X64 EBC
>  #
>  #  DRIVER_BINDING                =  gCirrusLogic5430DriverBinding
>  #  COMPONENT_NAME                =  gCirrusLogic5430ComponentName
> diff --git a/OptionRomPkg/OptionRomPkg.dsc
> b/OptionRomPkg/OptionRomPkg.dsc index 3365556710..fdd4a67f22 100644
> --- a/OptionRomPkg/OptionRomPkg.dsc
> +++ b/OptionRomPkg/OptionRomPkg.dsc
> @@ -30,7 +30,7 @@
>    PLATFORM_VERSION               = 0.1
>    DSC_SPECIFICATION              = 0x00010005
>    OUTPUT_DIRECTORY               = Build/OptionRomPkg
> -  SUPPORTED_ARCHITECTURES        = IA32|IPF|X64|EBC|ARM|AARCH64
> +  SUPPORTED_ARCHITECTURES        = IA32|X64|EBC|ARM|AARCH64
>    BUILD_TARGETS                  = DEBUG|RELEASE
>    SKUID_IDENTIFIER               = DEFAULT
> 
> @@ -115,5 +115,5 @@
>    OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772/Ax88772.inf
>    OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf
> 
> -[Components.IA32, Components.X64, Components.IPF]
> +[Components.IA32, Components.X64]
>    OptionRomPkg/Application/BltLibSample/BltLibSample.inf
> diff --git a/OptionRomPkg/UndiRuntimeDxe/UndiRuntimeDxe.inf
> b/OptionRomPkg/UndiRuntimeDxe/UndiRuntimeDxe.inf
> index b07c04e2cf..23d6f6bb74 100644
> --- a/OptionRomPkg/UndiRuntimeDxe/UndiRuntimeDxe.inf
> +++ b/OptionRomPkg/UndiRuntimeDxe/UndiRuntimeDxe.inf
> @@ -26,7 +26,7 @@
>    ENTRY_POINT                    = InitializeUndi
> 
>  #
> -#  VALID_ARCHITECTURES           = IA32 X64 IPF EBC
> +#  VALID_ARCHITECTURES           = IA32 X64 EBC
>  #
> 
>  [Sources]
> --
> 2.16.2.windows.1



      reply	other threads:[~2018-09-06  1:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-13  3:45 [PATCH 25/37] OptionRomPkg: Removing ipf which is no longer supported from edk2 chenc2
2018-09-06  1:53 ` Ni, Ruiyu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=734D49CCEBEEF84792F5B80ED585239D5BDF5A25@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox