[PATCH] ShellPkg Shell: Remove an unused global variable

[PATCH] ShellPkg Shell: Remove an unused global variable

[shenglei]

The unused global variable InvalidChars is removed.
It is only used in the function IsValidCommandName which
was removed previously.
https://bugzilla.tianocore.org/show_bug.cgi?id=1066

Cc: Jaben Carsey <jaben.carsey@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: shenglei <shenglei.zhang@intel.com>
---
 ShellPkg/Application/Shell/Shell.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/ShellPkg/Application/Shell/Shell.c b/ShellPkg/Application/Shell/Shell.c
index 397cfd1994..3f3bcbb4b0 100644
--- a/ShellPkg/Application/Shell/Shell.c
+++ b/ShellPkg/Application/Shell/Shell.c
@@ -2750,9 +2750,6 @@ RunCommand(
   return (RunShellCommand(CmdLine, NULL));
 }
 
-
-STATIC CONST UINT16 InvalidChars[] = {L'*', L'?', L'<', L'>', L'\\', L'/', L'\"', 0x0001, 0x0002};
-
 /**
   Function to process a NSH script file via SHELL_FILE_HANDLE.
 
-- 
2.18.0.windows.1

Re: [PATCH] ShellPkg Shell: Remove an unused global variable

[Ni, Ruiyu]

Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>

Thanks/Ray

> -----Original Message-----
> From: edk2-devel <edk2-devel-bounces@lists.01.org> On Behalf Of shenglei
> Sent: Friday, September 7, 2018 9:52 AM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>
> Subject: [edk2] [PATCH] ShellPkg Shell: Remove an unused global variable
> 
> The unused global variable InvalidChars is removed.
> It is only used in the function IsValidCommandName which was removed
> previously.
> https://bugzilla.tianocore.org/show_bug.cgi?id=1066
> 
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: shenglei <shenglei.zhang@intel.com>
> ---
>  ShellPkg/Application/Shell/Shell.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/ShellPkg/Application/Shell/Shell.c
> b/ShellPkg/Application/Shell/Shell.c
> index 397cfd1994..3f3bcbb4b0 100644
> --- a/ShellPkg/Application/Shell/Shell.c
> +++ b/ShellPkg/Application/Shell/Shell.c
> @@ -2750,9 +2750,6 @@ RunCommand(
>    return (RunShellCommand(CmdLine, NULL));  }
> 
> -
> -STATIC CONST UINT16 InvalidChars[] = {L'*', L'?', L'<', L'>', L'\\', L'/', L'\"',
> 0x0001, 0x0002};
> -
>  /**
>    Function to process a NSH script file via SHELL_FILE_HANDLE.
> 
> --
> 2.18.0.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel

Re: [PATCH] ShellPkg Shell: Remove an unused global variable

[Laszlo Ersek]

On 09/07/18 06:39, Ni, Ruiyu wrote:
> Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>

Commit 98257f982072.

Thanks
Laszlo


>> -----Original Message-----
>> From: edk2-devel <edk2-devel-bounces@lists.01.org> On Behalf Of shenglei
>> Sent: Friday, September 7, 2018 9:52 AM
>> To: edk2-devel@lists.01.org
>> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>
>> Subject: [edk2] [PATCH] ShellPkg Shell: Remove an unused global variable
>>
>> The unused global variable InvalidChars is removed.
>> It is only used in the function IsValidCommandName which was removed
>> previously.
>> https://bugzilla.tianocore.org/show_bug.cgi?id=1066
>>
>> Cc: Jaben Carsey <jaben.carsey@intel.com>
>> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: shenglei <shenglei.zhang@intel.com>
>> ---
>>  ShellPkg/Application/Shell/Shell.c | 3 ---
>>  1 file changed, 3 deletions(-)
>>
>> diff --git a/ShellPkg/Application/Shell/Shell.c
>> b/ShellPkg/Application/Shell/Shell.c
>> index 397cfd1994..3f3bcbb4b0 100644
>> --- a/ShellPkg/Application/Shell/Shell.c
>> +++ b/ShellPkg/Application/Shell/Shell.c
>> @@ -2750,9 +2750,6 @@ RunCommand(
>>    return (RunShellCommand(CmdLine, NULL));  }
>>
>> -
>> -STATIC CONST UINT16 InvalidChars[] = {L'*', L'?', L'<', L'>', L'\\', L'/', L'\"',
>> 0x0001, 0x0002};
>> -
>>  /**
>>    Function to process a NSH script file via SHELL_FILE_HANDLE.
>>
>> --
>> 2.18.0.windows.1
>>
>> _______________________________________________
>> edk2-devel mailing list
>> edk2-devel@lists.01.org
>> https://lists.01.org/mailman/listinfo/edk2-devel
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
>