Re: [PATCH] UefiCpuPkg/PeiCpuException: Fix coding style issue

["Ni, Ruiyu" <ruiyu.ni@intel.com>]

Oops.
Laszlo,
I pushed the fix with only Dandan's R-b.
Outlook groups Dandan's and your mail in different threads.

Thanks/Ray

> -----Original Message-----
> From: edk2-devel <edk2-devel-bounces@lists.01.org> On Behalf Of Laszlo
> Ersek
> Sent: Friday, September 7, 2018 6:32 PM
> To: Ni, Ruiyu <ruiyu.ni@intel.com>; edk2-devel@lists.01.org
> Cc: Bi, Dandan <dandan.bi@intel.com>
> Subject: Re: [edk2] [PATCH] UefiCpuPkg/PeiCpuException: Fix coding style
> issue
> 
> On 09/07/18 12:13, Ruiyu Ni wrote:
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
> > Cc: Dandan Bi <dandan.bi@intel.com>
> > ---
> >  UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuException.c | 6
> > +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git
> > a/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuException.c
> > b/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuException.c
> > index 5dd8423d2f..8f4d5b5e0a 100644
> > --- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuException.c
> > +++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuException.c
> > @@ -45,7 +45,7 @@ GetExceptionHandlerData (
> >
> >    AsmReadIdtr (&IdtDescriptor);
> >    IdtTable = (IA32_IDT_GATE_DESCRIPTOR *)IdtDescriptor.Base;
> > -
> > +
> >    Exception0StubHeader = (EXCEPTION0_STUB_HEADER
> *)ArchGetIdtHandler (&IdtTable[0]);
> >    return Exception0StubHeader->ExceptionHandlerData;
> >  }
> > @@ -57,7 +57,7 @@ GetExceptionHandlerData (
> >    exception handler data. The new allocated memory layout follows
> structure EXCEPTION0_STUB_HEADER.
> >    The code assumes that all processors uses the same exception handler
> for #0 exception.
> >
> > -  @param  pointer to exception handler data.
> > +  @param ExceptionHandlerData  pointer to exception handler data.
> >  **/
> >  VOID
> >  SetExceptionHandlerData (
> > @@ -73,7 +73,7 @@ SetExceptionHandlerData (
> >    //
> >    AsmReadIdtr (&IdtDescriptor);
> >    IdtTable = (IA32_IDT_GATE_DESCRIPTOR *)IdtDescriptor.Base;
> > -
> > +
> >    Exception0StubHeader = AllocatePool (sizeof (*Exception0StubHeader));
> >    ASSERT (Exception0StubHeader != NULL);
> >    CopyMem (
> >
> 
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel