* [PATCH] UefiCpuPkg/PeiCpuException: Fix coding style issue
@ 2018-09-07 10:13 Ruiyu Ni
2018-09-07 10:31 ` Laszlo Ersek
2018-09-08 4:03 ` Bi, Dandan
0 siblings, 2 replies; 4+ messages in thread
From: Ruiyu Ni @ 2018-09-07 10:13 UTC (permalink / raw)
To: edk2-devel; +Cc: Dandan Bi
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Dandan Bi <dandan.bi@intel.com>
---
UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuException.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuException.c b/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuException.c
index 5dd8423d2f..8f4d5b5e0a 100644
--- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuException.c
+++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuException.c
@@ -45,7 +45,7 @@ GetExceptionHandlerData (
AsmReadIdtr (&IdtDescriptor);
IdtTable = (IA32_IDT_GATE_DESCRIPTOR *)IdtDescriptor.Base;
-
+
Exception0StubHeader = (EXCEPTION0_STUB_HEADER *)ArchGetIdtHandler (&IdtTable[0]);
return Exception0StubHeader->ExceptionHandlerData;
}
@@ -57,7 +57,7 @@ GetExceptionHandlerData (
exception handler data. The new allocated memory layout follows structure EXCEPTION0_STUB_HEADER.
The code assumes that all processors uses the same exception handler for #0 exception.
- @param pointer to exception handler data.
+ @param ExceptionHandlerData pointer to exception handler data.
**/
VOID
SetExceptionHandlerData (
@@ -73,7 +73,7 @@ SetExceptionHandlerData (
//
AsmReadIdtr (&IdtDescriptor);
IdtTable = (IA32_IDT_GATE_DESCRIPTOR *)IdtDescriptor.Base;
-
+
Exception0StubHeader = AllocatePool (sizeof (*Exception0StubHeader));
ASSERT (Exception0StubHeader != NULL);
CopyMem (
--
2.16.1.windows.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] UefiCpuPkg/PeiCpuException: Fix coding style issue
2018-09-07 10:13 [PATCH] UefiCpuPkg/PeiCpuException: Fix coding style issue Ruiyu Ni
@ 2018-09-07 10:31 ` Laszlo Ersek
2018-09-10 2:26 ` Ni, Ruiyu
2018-09-08 4:03 ` Bi, Dandan
1 sibling, 1 reply; 4+ messages in thread
From: Laszlo Ersek @ 2018-09-07 10:31 UTC (permalink / raw)
To: Ruiyu Ni, edk2-devel; +Cc: Dandan Bi
On 09/07/18 12:13, Ruiyu Ni wrote:
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Dandan Bi <dandan.bi@intel.com>
> ---
> UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuException.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuException.c b/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuException.c
> index 5dd8423d2f..8f4d5b5e0a 100644
> --- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuException.c
> +++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuException.c
> @@ -45,7 +45,7 @@ GetExceptionHandlerData (
>
> AsmReadIdtr (&IdtDescriptor);
> IdtTable = (IA32_IDT_GATE_DESCRIPTOR *)IdtDescriptor.Base;
> -
> +
> Exception0StubHeader = (EXCEPTION0_STUB_HEADER *)ArchGetIdtHandler (&IdtTable[0]);
> return Exception0StubHeader->ExceptionHandlerData;
> }
> @@ -57,7 +57,7 @@ GetExceptionHandlerData (
> exception handler data. The new allocated memory layout follows structure EXCEPTION0_STUB_HEADER.
> The code assumes that all processors uses the same exception handler for #0 exception.
>
> - @param pointer to exception handler data.
> + @param ExceptionHandlerData pointer to exception handler data.
> **/
> VOID
> SetExceptionHandlerData (
> @@ -73,7 +73,7 @@ SetExceptionHandlerData (
> //
> AsmReadIdtr (&IdtDescriptor);
> IdtTable = (IA32_IDT_GATE_DESCRIPTOR *)IdtDescriptor.Base;
> -
> +
> Exception0StubHeader = AllocatePool (sizeof (*Exception0StubHeader));
> ASSERT (Exception0StubHeader != NULL);
> CopyMem (
>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] UefiCpuPkg/PeiCpuException: Fix coding style issue
2018-09-07 10:13 [PATCH] UefiCpuPkg/PeiCpuException: Fix coding style issue Ruiyu Ni
2018-09-07 10:31 ` Laszlo Ersek
@ 2018-09-08 4:03 ` Bi, Dandan
1 sibling, 0 replies; 4+ messages in thread
From: Bi, Dandan @ 2018-09-08 4:03 UTC (permalink / raw)
To: Ni, Ruiyu, edk2-devel@lists.01.org
Reviewed-by: Dandan Bi <dandan.bi@intel.com>
Thanks,
Dandan
-----Original Message-----
From: Ni, Ruiyu
Sent: Friday, September 7, 2018 6:13 PM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan <dandan.bi@intel.com>
Subject: [PATCH] UefiCpuPkg/PeiCpuException: Fix coding style issue
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Dandan Bi <dandan.bi@intel.com>
---
UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuException.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuException.c b/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuException.c
index 5dd8423d2f..8f4d5b5e0a 100644
--- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuException.c
+++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuException.c
@@ -45,7 +45,7 @@ GetExceptionHandlerData (
AsmReadIdtr (&IdtDescriptor);
IdtTable = (IA32_IDT_GATE_DESCRIPTOR *)IdtDescriptor.Base;
-
+
Exception0StubHeader = (EXCEPTION0_STUB_HEADER *)ArchGetIdtHandler (&IdtTable[0]);
return Exception0StubHeader->ExceptionHandlerData;
}
@@ -57,7 +57,7 @@ GetExceptionHandlerData (
exception handler data. The new allocated memory layout follows structure EXCEPTION0_STUB_HEADER.
The code assumes that all processors uses the same exception handler for #0 exception.
- @param pointer to exception handler data.
+ @param ExceptionHandlerData pointer to exception handler data.
**/
VOID
SetExceptionHandlerData (
@@ -73,7 +73,7 @@ SetExceptionHandlerData (
//
AsmReadIdtr (&IdtDescriptor);
IdtTable = (IA32_IDT_GATE_DESCRIPTOR *)IdtDescriptor.Base;
-
+
Exception0StubHeader = AllocatePool (sizeof (*Exception0StubHeader));
ASSERT (Exception0StubHeader != NULL);
CopyMem (
--
2.16.1.windows.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] UefiCpuPkg/PeiCpuException: Fix coding style issue
2018-09-07 10:31 ` Laszlo Ersek
@ 2018-09-10 2:26 ` Ni, Ruiyu
0 siblings, 0 replies; 4+ messages in thread
From: Ni, Ruiyu @ 2018-09-10 2:26 UTC (permalink / raw)
To: Laszlo Ersek, edk2-devel@lists.01.org; +Cc: Bi, Dandan
Oops.
Laszlo,
I pushed the fix with only Dandan's R-b.
Outlook groups Dandan's and your mail in different threads.
Thanks/Ray
> -----Original Message-----
> From: edk2-devel <edk2-devel-bounces@lists.01.org> On Behalf Of Laszlo
> Ersek
> Sent: Friday, September 7, 2018 6:32 PM
> To: Ni, Ruiyu <ruiyu.ni@intel.com>; edk2-devel@lists.01.org
> Cc: Bi, Dandan <dandan.bi@intel.com>
> Subject: Re: [edk2] [PATCH] UefiCpuPkg/PeiCpuException: Fix coding style
> issue
>
> On 09/07/18 12:13, Ruiyu Ni wrote:
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
> > Cc: Dandan Bi <dandan.bi@intel.com>
> > ---
> > UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuException.c | 6
> > +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git
> > a/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuException.c
> > b/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuException.c
> > index 5dd8423d2f..8f4d5b5e0a 100644
> > --- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuException.c
> > +++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuException.c
> > @@ -45,7 +45,7 @@ GetExceptionHandlerData (
> >
> > AsmReadIdtr (&IdtDescriptor);
> > IdtTable = (IA32_IDT_GATE_DESCRIPTOR *)IdtDescriptor.Base;
> > -
> > +
> > Exception0StubHeader = (EXCEPTION0_STUB_HEADER
> *)ArchGetIdtHandler (&IdtTable[0]);
> > return Exception0StubHeader->ExceptionHandlerData;
> > }
> > @@ -57,7 +57,7 @@ GetExceptionHandlerData (
> > exception handler data. The new allocated memory layout follows
> structure EXCEPTION0_STUB_HEADER.
> > The code assumes that all processors uses the same exception handler
> for #0 exception.
> >
> > - @param pointer to exception handler data.
> > + @param ExceptionHandlerData pointer to exception handler data.
> > **/
> > VOID
> > SetExceptionHandlerData (
> > @@ -73,7 +73,7 @@ SetExceptionHandlerData (
> > //
> > AsmReadIdtr (&IdtDescriptor);
> > IdtTable = (IA32_IDT_GATE_DESCRIPTOR *)IdtDescriptor.Base;
> > -
> > +
> > Exception0StubHeader = AllocatePool (sizeof (*Exception0StubHeader));
> > ASSERT (Exception0StubHeader != NULL);
> > CopyMem (
> >
>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-09-10 2:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-07 10:13 [PATCH] UefiCpuPkg/PeiCpuException: Fix coding style issue Ruiyu Ni
2018-09-07 10:31 ` Laszlo Ersek
2018-09-10 2:26 ` Ni, Ruiyu
2018-09-08 4:03 ` Bi, Dandan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox