From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BF5742110719F for ; Sun, 9 Sep 2018 19:27:50 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Sep 2018 19:27:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,354,1531810800"; d="scan'208";a="262091322" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga006.fm.intel.com with ESMTP; 09 Sep 2018 19:27:43 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 9 Sep 2018 19:27:42 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.143]) by shsmsx102.ccr.corp.intel.com ([169.254.2.226]) with mapi id 14.03.0319.002; Mon, 10 Sep 2018 10:26:47 +0800 From: "Ni, Ruiyu" To: Laszlo Ersek , "edk2-devel@lists.01.org" CC: "Bi, Dandan" Thread-Topic: [edk2] [PATCH] UefiCpuPkg/PeiCpuException: Fix coding style issue Thread-Index: AQHURpNmoa6LjFr7EkeeAc+KcDXFjKTkGLKAgAS1jaA= Date: Mon, 10 Sep 2018 02:26:47 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5BE00FF4@SHSMSX104.ccr.corp.intel.com> References: <20180907101323.50584-1-ruiyu.ni@intel.com> In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] UefiCpuPkg/PeiCpuException: Fix coding style issue X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Sep 2018 02:27:51 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Oops. Laszlo, I pushed the fix with only Dandan's R-b. Outlook groups Dandan's and your mail in different threads. Thanks/Ray > -----Original Message----- > From: edk2-devel On Behalf Of Laszlo > Ersek > Sent: Friday, September 7, 2018 6:32 PM > To: Ni, Ruiyu ; edk2-devel@lists.01.org > Cc: Bi, Dandan > Subject: Re: [edk2] [PATCH] UefiCpuPkg/PeiCpuException: Fix coding style > issue >=20 > On 09/07/18 12:13, Ruiyu Ni wrote: > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Ruiyu Ni > > Cc: Dandan Bi > > --- > > UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuException.c | 6 > > +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git > > a/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuException.c > > b/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuException.c > > index 5dd8423d2f..8f4d5b5e0a 100644 > > --- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuException.c > > +++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuException.c > > @@ -45,7 +45,7 @@ GetExceptionHandlerData ( > > > > AsmReadIdtr (&IdtDescriptor); > > IdtTable =3D (IA32_IDT_GATE_DESCRIPTOR *)IdtDescriptor.Base; > > - > > + > > Exception0StubHeader =3D (EXCEPTION0_STUB_HEADER > *)ArchGetIdtHandler (&IdtTable[0]); > > return Exception0StubHeader->ExceptionHandlerData; > > } > > @@ -57,7 +57,7 @@ GetExceptionHandlerData ( > > exception handler data. The new allocated memory layout follows > structure EXCEPTION0_STUB_HEADER. > > The code assumes that all processors uses the same exception handler > for #0 exception. > > > > - @param pointer to exception handler data. > > + @param ExceptionHandlerData pointer to exception handler data. > > **/ > > VOID > > SetExceptionHandlerData ( > > @@ -73,7 +73,7 @@ SetExceptionHandlerData ( > > // > > AsmReadIdtr (&IdtDescriptor); > > IdtTable =3D (IA32_IDT_GATE_DESCRIPTOR *)IdtDescriptor.Base; > > - > > + > > Exception0StubHeader =3D AllocatePool (sizeof (*Exception0StubHeader= )); > > ASSERT (Exception0StubHeader !=3D NULL); > > CopyMem ( > > >=20 > Reviewed-by: Laszlo Ersek > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel