From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.20; helo=mga02.intel.com; envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 780A421A07A80 for ; Tue, 25 Sep 2018 18:56:24 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Sep 2018 18:56:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,304,1534834800"; d="scan'208";a="89370050" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga002.fm.intel.com with ESMTP; 25 Sep 2018 18:54:30 -0700 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 25 Sep 2018 18:54:31 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 25 Sep 2018 18:54:30 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.183]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.27]) with mapi id 14.03.0319.002; Wed, 26 Sep 2018 09:54:28 +0800 From: "Ni, Ruiyu" To: "Carsey, Jaben" , "Tomas Pilar (tpilar)" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [PATCH] ShellPkg: Mark InvalidCharacters[] in Shell.c as unused Thread-Index: AQHUVLi8n2cTmjFDE0CBl3VfQvP7zqUAjrSAgAE/cPA= Date: Wed, 26 Sep 2018 01:54:27 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5BE4DF32@SHSMSX104.ccr.corp.intel.com> References: <3570196b-4027-284a-e332-3121621bdc7e@solarflare.com> In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZmRmMDY1OGEtZjJjYi00NWZlLTgzYzktNjAyOTM3ZjIwNDQ0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoid09cLzRkMWwwS0QwRlVzYTM1TmI5ZG1sQ09EeVB3bVpQM0ZTa2tOYWY0Um8wXC9iK1VYb1NBZUUzeWpjdTdrMGtOIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] ShellPkg: Mark InvalidCharacters[] in Shell.c as unused X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Sep 2018 01:56:24 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I agree to delete it! We have git history which can tell us how to re-add t= hem in future.:) > -----Original Message----- > From: Carsey, Jaben > Sent: Tuesday, September 25, 2018 10:51 PM > To: Tomas Pilar (tpilar) ; edk2-devel@lists.01.org= ; Ni, > Ruiyu > Subject: RE: [edk2] [PATCH] ShellPkg: Mark InvalidCharacters[] in Shell.c= as > unused >=20 > I would prefer we just delete this. >=20 > Ray, > What do you think? >=20 > > -----Original Message----- > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > > Tomas Pilar (tpilar) > > Sent: Tuesday, September 25, 2018 3:15 AM > > To: edk2-devel@lists.01.org > > Subject: [edk2] [PATCH] ShellPkg: Mark InvalidCharacters[] in Shell.c > > as unused > > Importance: High > > > > This fixes unused const variable gcc 7.3 compilation error. Array is > > not simply removed as the list of invalid characters might be salient > > in future and for easy documentation. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Tomas Pilar > > --- > > ShellPkg/Application/Shell/Shell.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/ShellPkg/Application/Shell/Shell.c > > b/ShellPkg/Application/Shell/Shell.c > > index 397cfd1994..38b002a144 100644 > > --- a/ShellPkg/Application/Shell/Shell.c > > +++ b/ShellPkg/Application/Shell/Shell.c > > @@ -2751,7 +2751,7 @@ RunCommand( > > } > > > > > > -STATIC CONST UINT16 InvalidChars[] =3D {L'*', L'?', L'<', L'>', L'\\', > > L'/', L'\"', 0x0001, 0x0002}; > > +STATIC CONST UINT16 InvalidChars[] __attribute__((unused)) =3D {L'*', > > +L'?', > > L'<', L'>', L'\\', L'/', L'\"', 0x0001, 0x0002}; > > > > /** > > Function to process a NSH script file via SHELL_FILE_HANDLE. > > -- > > 2.17.1 > > > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel