[PATCH] ShellPkg: Mark InvalidCharacters[] in Shell.c as unused

[PATCH] ShellPkg: Mark InvalidCharacters[] in Shell.c as unused

[Tomas Pilar (tpilar)]

This fixes unused const variable gcc 7.3 compilation error. Array is not
simply removed as the list of invalid characters might be salient
in future and for easy documentation.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Tomas Pilar <tpilar@solarflare.com>
---
 ShellPkg/Application/Shell/Shell.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ShellPkg/Application/Shell/Shell.c b/ShellPkg/Application/Shell/Shell.c
index 397cfd1994..38b002a144 100644
--- a/ShellPkg/Application/Shell/Shell.c
+++ b/ShellPkg/Application/Shell/Shell.c
@@ -2751,7 +2751,7 @@ RunCommand(
 }
 
 
-STATIC CONST UINT16 InvalidChars[] = {L'*', L'?', L'<', L'>', L'\\', L'/', L'\"', 0x0001, 0x0002};
+STATIC CONST UINT16 InvalidChars[] __attribute__((unused)) = {L'*', L'?', L'<', L'>', L'\\', L'/', L'\"', 0x0001, 0x0002};
 
 /**
   Function to process a NSH script file via SHELL_FILE_HANDLE.
-- 
2.17.1

Re: [PATCH] ShellPkg: Mark InvalidCharacters[] in Shell.c as unused

[Carsey, Jaben]

I would prefer we just delete this.  

Ray, 
What do you think?

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Tomas Pilar (tpilar)
> Sent: Tuesday, September 25, 2018 3:15 AM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [PATCH] ShellPkg: Mark InvalidCharacters[] in Shell.c as
> unused
> Importance: High
> 
> This fixes unused const variable gcc 7.3 compilation error. Array is not
> simply removed as the list of invalid characters might be salient
> in future and for easy documentation.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Tomas Pilar <tpilar@solarflare.com>
> ---
>  ShellPkg/Application/Shell/Shell.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ShellPkg/Application/Shell/Shell.c
> b/ShellPkg/Application/Shell/Shell.c
> index 397cfd1994..38b002a144 100644
> --- a/ShellPkg/Application/Shell/Shell.c
> +++ b/ShellPkg/Application/Shell/Shell.c
> @@ -2751,7 +2751,7 @@ RunCommand(
>  }
> 
> 
> -STATIC CONST UINT16 InvalidChars[] = {L'*', L'?', L'<', L'>', L'\\', L'/', L'\"',
> 0x0001, 0x0002};
> +STATIC CONST UINT16 InvalidChars[] __attribute__((unused)) = {L'*', L'?',
> L'<', L'>', L'\\', L'/', L'\"', 0x0001, 0x0002};
> 
>  /**
>    Function to process a NSH script file via SHELL_FILE_HANDLE.
> --
> 2.17.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel

Re: [PATCH] ShellPkg: Mark InvalidCharacters[] in Shell.c as unused

[Ni, Ruiyu]

I agree to delete it! We have git history which can tell us how to re-add them in future.:)

> -----Original Message-----
> From: Carsey, Jaben
> Sent: Tuesday, September 25, 2018 10:51 PM
> To: Tomas Pilar (tpilar) <tpilar@solarflare.com>; edk2-devel@lists.01.org; Ni,
> Ruiyu <ruiyu.ni@intel.com>
> Subject: RE: [edk2] [PATCH] ShellPkg: Mark InvalidCharacters[] in Shell.c as
> unused
> 
> I would prefer we just delete this.
> 
> Ray,
> What do you think?
> 
> > -----Original Message-----
> > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> > Tomas Pilar (tpilar)
> > Sent: Tuesday, September 25, 2018 3:15 AM
> > To: edk2-devel@lists.01.org
> > Subject: [edk2] [PATCH] ShellPkg: Mark InvalidCharacters[] in Shell.c
> > as unused
> > Importance: High
> >
> > This fixes unused const variable gcc 7.3 compilation error. Array is
> > not simply removed as the list of invalid characters might be salient
> > in future and for easy documentation.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Tomas Pilar <tpilar@solarflare.com>
> > ---
> >  ShellPkg/Application/Shell/Shell.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/ShellPkg/Application/Shell/Shell.c
> > b/ShellPkg/Application/Shell/Shell.c
> > index 397cfd1994..38b002a144 100644
> > --- a/ShellPkg/Application/Shell/Shell.c
> > +++ b/ShellPkg/Application/Shell/Shell.c
> > @@ -2751,7 +2751,7 @@ RunCommand(
> >  }
> >
> >
> > -STATIC CONST UINT16 InvalidChars[] = {L'*', L'?', L'<', L'>', L'\\',
> > L'/', L'\"', 0x0001, 0x0002};
> > +STATIC CONST UINT16 InvalidChars[] __attribute__((unused)) = {L'*',
> > +L'?',
> > L'<', L'>', L'\\', L'/', L'\"', 0x0001, 0x0002};
> >
> >  /**
> >    Function to process a NSH script file via SHELL_FILE_HANDLE.
> > --
> > 2.17.1
> >
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel

Re: [PATCH] ShellPkg: Mark InvalidCharacters[] in Shell.c as unused

[Ni, Ruiyu]

On 9/25/2018 10:50 PM, Carsey, Jaben wrote:
> I would prefer we just delete this.
> 
> Ray,
> What do you think?
> 
Not sure I sent it or not.
I also prefer to delete it. Git history can help in future if we need it 
again.

Re: [PATCH] ShellPkg: Mark InvalidCharacters[] in Shell.c as unused

[Tomas Pilar (tpilar)]

Thanks, I'll respin.

On 26/09/18 05:54, Ni, Ruiyu wrote:
> On 9/25/2018 10:50 PM, Carsey, Jaben wrote:
>> I would prefer we just delete this.
>>
>> Ray,
>> What do you think?
>>
> Not sure I sent it or not.
> I also prefer to delete it. Git history can help in future if we need it again.