From: "Ni, Ruiyu" <ruiyu.ni@intel.com>
To: "Dong, Eric" <eric.dong@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Bi, Dandan" <dandan.bi@intel.com>
Subject: Re: [Patch] UefiCpuPkg/RegisterCpuFeaturesLib: Fix build failure.
Date: Tue, 30 Oct 2018 05:00:48 +0000 [thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5BEE51A3@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20181030030439.29600-1-eric.dong@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
Thanks/Ray
> -----Original Message-----
> From: Dong, Eric
> Sent: Tuesday, October 30, 2018 11:05 AM
> To: edk2-devel@lists.01.org
> Cc: Bi, Dandan <dandan.bi@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>
> Subject: [Patch] UefiCpuPkg/RegisterCpuFeaturesLib: Fix build failure.
>
> Build UefiCpuPkg with below configuration:
> Architecture(s) = IA32
> Build target = NOOPT
> Toolchain = VS2015x86
>
> Below error info shows up:
> DxeRegisterCpuFeaturesLib.lib(CpuFeaturesInitialize.obj) :
> error LNK2001: unresolved external symbol __allmul
>
> Valid mDependTypeStr type only have 5 items, use UINT32 type cast to fix
> this error.
>
> Cc: Dandan Bi <dandan.bi@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Eric Dong <eric.dong@intel.com>
> ---
> UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
> a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c
> b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c
> index bc372a338f..8588800e4a 100644
> --- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c
> +++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c
> @@ -517,7 +517,7 @@ DumpRegisterTableOnProcessor (
> DebugPrintErrorLevel,
> "Processor: %d: Semaphore: Scope Value: %s\r\n",
> ProcessorNumber,
> - mDependTypeStr[MIN (RegisterTableEntry->Value, InvalidDepType)]
> + mDependTypeStr[MIN ((UINT32)RegisterTableEntry->Value,
> + InvalidDepType)]
> ));
> break;
>
> --
> 2.15.0.windows.1
prev parent reply other threads:[~2018-10-30 5:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-30 3:04 [Patch] UefiCpuPkg/RegisterCpuFeaturesLib: Fix build failure Eric Dong
2018-10-30 5:00 ` Ni, Ruiyu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=734D49CCEBEEF84792F5B80ED585239D5BEE51A3@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox