public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ni, Ruiyu" <ruiyu.ni@intel.com>
To: "Fu, Siyuan" <siyuan.fu@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Wu, Hao A" <hao.a.wu@intel.com>
Subject: Re: [PATCH v1 1/7] Nt32Pkg: Replace obsoleted network drivers from NT32 platform DSC/FDF.
Date: Tue, 30 Oct 2018 07:57:04 +0000	[thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5BEE55EB@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20181030073328.62924-2-siyuan.fu@intel.com>

Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>

Thanks/Ray

> -----Original Message-----
> From: edk2-devel <edk2-devel-bounces@lists.01.org> On Behalf Of Fu
> Siyuan
> Sent: Tuesday, October 30, 2018 3:33 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; Wu, Hao A <hao.a.wu@intel.com>
> Subject: [edk2] [PATCH v1 1/7] Nt32Pkg: Replace obsoleted network drivers
> from NT32 platform DSC/FDF.
> 
> This patch replaces the MdeModulePkg TCP, PXE and iSCSI driver with those
> ones in NetworkPkg. These 3 drivers in MdeModulePkg are not being
> actively maintained and will be removed from edk2 master soon.
> 
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Hao Wu <hao.a.wu@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Fu Siyuan <siyuan.fu@intel.com>
> ---
>  Nt32Pkg/Nt32Pkg.dsc | 12 ++++--------
>  Nt32Pkg/Nt32Pkg.fdf | 12 ++++--------
>  2 files changed, 8 insertions(+), 16 deletions(-)
> 
> diff --git a/Nt32Pkg/Nt32Pkg.dsc b/Nt32Pkg/Nt32Pkg.dsc index
> 58d9f8787dde..4293ca39fdec 100644
> --- a/Nt32Pkg/Nt32Pkg.dsc
> +++ b/Nt32Pkg/Nt32Pkg.dsc
> @@ -4,7 +4,7 @@
>  # The Emulation Platform can be used to debug individual modules, prior to
> creating
>  #    a real platform. This also provides an example for how an DSC is created.
>  #
> -# Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2006 - 2018, Intel Corporation. All rights
> +reserved.<BR>
>  # Copyright (c) 2015, Hewlett-Packard Development Company, L.P.<BR>  #
> (C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR>  # @@ -
> 468,20 +468,16 @@ [Components]
>    MdeModulePkg/Universal/Network/VlanConfigDxe/VlanConfigDxe.inf
>    MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf
>    MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf
> +  NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf
> +  NetworkPkg/TcpDxe/TcpDxe.inf
> +  NetworkPkg/IScsiDxe/IScsiDxe.inf
>    Nt32Pkg/SnpNt32Dxe/SnpNt32Dxe.inf
> 
>  !if $(NETWORK_IP6_ENABLE) == TRUE
>    NetworkPkg/Ip6Dxe/Ip6Dxe.inf
>    NetworkPkg/Dhcp6Dxe/Dhcp6Dxe.inf
> -  NetworkPkg/TcpDxe/TcpDxe.inf
>    NetworkPkg/Udp6Dxe/Udp6Dxe.inf
>    NetworkPkg/Mtftp6Dxe/Mtftp6Dxe.inf
> -  NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf
> -  NetworkPkg/IScsiDxe/IScsiDxe.inf
> -!else
> -  MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.inf
> -  MdeModulePkg/Universal/Network/UefiPxeBcDxe/UefiPxeBcDxe.inf
> -  MdeModulePkg/Universal/Network/IScsiDxe/IScsiDxe.inf
>  !endif
> 
>    NetworkPkg/HttpBootDxe/HttpBootDxe.inf
> diff --git a/Nt32Pkg/Nt32Pkg.fdf b/Nt32Pkg/Nt32Pkg.fdf index
> db2719fd99df..65d9bf812b5b 100644
> --- a/Nt32Pkg/Nt32Pkg.fdf
> +++ b/Nt32Pkg/Nt32Pkg.fdf
> @@ -1,7 +1,7 @@
>  ## @file
>  # This is NT32 FDF file with UEFI HII features enabled  # -# Copyright (c) 2007
> - 2017, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2007 - 2018, Intel Corporation. All rights
> +reserved.<BR>
>  # (C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR>  #
>  #    This program and the accompanying materials
> @@ -257,19 +257,15 @@ [FV.FvRecovery]
>  INF  MdeModulePkg/Universal/Network/VlanConfigDxe/VlanConfigDxe.inf
>  INF  MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf
>  INF  MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf
> +INF  NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf
> +INF  NetworkPkg/TcpDxe/TcpDxe.inf
> +INF  NetworkPkg/IScsiDxe/IScsiDxe.inf
>  INF  Nt32Pkg/SnpNt32Dxe/SnpNt32Dxe.inf
>  !if $(NETWORK_IP6_ENABLE) == TRUE
>  INF  NetworkPkg/Ip6Dxe/Ip6Dxe.inf
>  INF  NetworkPkg/Dhcp6Dxe/Dhcp6Dxe.inf
>  INF  NetworkPkg/Udp6Dxe/Udp6Dxe.inf
>  INF  NetworkPkg/Mtftp6Dxe/Mtftp6Dxe.inf
> -INF  NetworkPkg/TcpDxe/TcpDxe.inf
> -INF  NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf
> -INF  NetworkPkg/IScsiDxe/IScsiDxe.inf
> -!else
> -INF  MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.inf
> -INF  MdeModulePkg/Universal/Network/UefiPxeBcDxe/UefiPxeBcDxe.inf
> -INF  MdeModulePkg/Universal/Network/IScsiDxe/IScsiDxe.inf
>  !endif
>  INF  NetworkPkg/HttpBootDxe/HttpBootDxe.inf
>  INF  NetworkPkg/DnsDxe/DnsDxe.inf
> --
> 2.18.0.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel


  reply	other threads:[~2018-10-30  7:58 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-30  7:33 [PATCH v1 0/7] Delete TCP, PXE, iSCSI driver in MdeModulePkg Fu Siyuan
2018-10-30  7:33 ` [PATCH v1 1/7] Nt32Pkg: Replace obsoleted network drivers from NT32 platform DSC/FDF Fu Siyuan
2018-10-30  7:57   ` Ni, Ruiyu [this message]
2018-10-30  7:33 ` [PATCH v1 2/7] EmulatorPkg: Replace obsoleted network drivers from " Fu Siyuan
2018-10-30  7:57   ` Ni, Ruiyu
2018-10-30  7:33 ` [PATCH v1 3/7] OvmfPkg: " Fu Siyuan
2018-10-30  7:33 ` [PATCH v1 4/7] Vlv2TbltDevicePkg: Replace obsoleted " Fu Siyuan
2018-11-04  6:14   ` Wei, David
2018-10-30  7:33 ` [PATCH v1 5/7] ArmVirtPkg: Replace obsoleted network " Fu Siyuan
2018-10-30  7:33 ` [PATCH v1 6/7] MdeModulePkg: Delete the TCP/PXE/ISCSI drivers in MdeModulePkg Fu Siyuan
2018-10-31  8:23   ` Ni, Ruiyu
2018-10-31  8:37     ` Fu, Siyuan
2018-11-01  3:08   ` Zeng, Star
2018-10-30  7:33 ` [PATCH v1 7/7] NetworkPkg: Remove some clarification from TCP/PXE/ISCSI driver INF Fu Siyuan
2018-10-30  8:16   ` Ye, Ting
2018-10-30  7:42 ` [PATCH v1 0/7] Delete TCP, PXE, iSCSI driver in MdeModulePkg Zeng, Star
2018-10-30  8:23   ` Fu, Siyuan
2018-10-30 21:14     ` Kinney, Michael D
2018-10-31  0:51       ` Fu, Siyuan
2018-10-31 16:29         ` Kinney, Michael D
2018-10-30 10:50 ` Leif Lindholm
2018-10-31  0:41   ` Fu, Siyuan
2018-10-31 10:59     ` Leif Lindholm
2018-10-31 14:02       ` Gao, Liming
2018-11-05 22:12       ` Laszlo Ersek
2018-11-06  0:59         ` Fu, Siyuan
2018-11-06 14:38           ` Laszlo Ersek
2018-11-06 11:02         ` Leif Lindholm
2018-11-06 14:34           ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=734D49CCEBEEF84792F5B80ED585239D5BEE55EB@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox