From: "Ni, Ruiyu" <ruiyu.ni@intel.com>
To: Jeff Brasen <jbrasen@nvidia.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Gao, Liming" <liming.gao@intel.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [PATCH 2/2] MdeModulePkg/BaseSortLib: Enable for all module types
Date: Wed, 31 Oct 2018 08:56:42 +0000 [thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5BEE8DCE@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <c551bdd57ea6db99f19deefbad39cbc935defa77.1540934763.git.jbrasen@nvidia.com>
SortLib depends on MemoryAllocationLib.
How can it be a BASE type library?
Can we do it in two options?
1. Change the SortLib API to accept a temporary buffer from caller. So the MemoryAllocationlIb dependency can be removed.
2. Do not change SortLibAPI but uses a fixed-size temporary buffer internally. E.g.: UINT8 Buffer[MAX_ELEMENT_SIZE];
Thanks/Ray
> -----Original Message-----
> From: edk2-devel <edk2-devel-bounces@lists.01.org> On Behalf Of Jeff
> Brasen
> Sent: Wednesday, October 31, 2018 5:31 AM
> To: edk2-devel@lists.01.org
> Cc: Jeff Brasen <jbrasen@nvidia.com>
> Subject: [edk2] [PATCH 2/2] MdeModulePkg/BaseSortLib: Enable for all
> module types
>
> Expose BaseSortLib for use in SEC and PEI phases.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Jeff Brasen <jbrasen@nvidia.com>
> ---
> MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
> b/MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
> index f807cd7..5bd1aa1 100644
> --- a/MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
> +++ b/MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
> @@ -18,9 +18,9 @@
> BASE_NAME = BaseSortLib
> MODULE_UNI_FILE = BaseSortLib.uni
> FILE_GUID = 03F3331B-F12D-494f-BF37-E55A657F2497
> - MODULE_TYPE = UEFI_DRIVER
> + MODULE_TYPE = BASE
> VERSION_STRING = 1.0
> - LIBRARY_CLASS = SortLib|DXE_DRIVER DXE_RUNTIME_DRIVER
> UEFI_APPLICATION UEFI_DRIVER
> + LIBRARY_CLASS = SortLib
>
> #
> # VALID_ARCHITECTURES = IA32 X64 EBC
> --
> 2.7.4
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
next prev parent reply other threads:[~2018-10-31 8:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-30 21:30 [PATCH 0/2] SortLib for UEFI SEC Jeff Brasen
2018-10-30 21:30 ` [PATCH 1/2] EmbeddedPkg/PrePiMemoryAllocationLib: Added AllocateZeroPool() Jeff Brasen
2018-10-30 22:57 ` Carsey, Jaben
2018-11-08 0:29 ` Gao, Liming
2018-11-08 11:13 ` Ard Biesheuvel
2018-11-08 16:52 ` Jeff Brasen
2018-10-30 21:30 ` [PATCH 2/2] MdeModulePkg/BaseSortLib: Enable for all module types Jeff Brasen
2018-10-30 22:57 ` Carsey, Jaben
2018-10-31 8:56 ` Ni, Ruiyu [this message]
2018-11-01 6:25 ` Jeff Brasen
2018-11-01 13:31 ` Gao, Liming
2018-11-02 4:59 ` Zeng, Star
2018-11-02 7:45 ` Gao, Liming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=734D49CCEBEEF84792F5B80ED585239D5BEE8DCE@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox